[webkit-changes] [280163] trunk/Source/JavaScriptCore

[yijia_huang]

Title: [280163] trunk/Source/_javascript_Core

Revision

280163

Author

yijia_hu...@apple.com

Date

2021-07-21 15:24:28 -0700 (Wed, 21 Jul 2021)

Log Message

Fix type check error in testb3
https://bugs.webkit.org/show_bug.cgi?id=228166

Reviewed by Saam Barati.

* b3/testb3_2.cpp:
(testXorNotWithLeftShift32):
(testXorNotWithRightShift32):
(testXorNotWithUnsignedRightShift32):

Modified Paths

• trunk/Source/_javascript_Core/ChangeLog
• trunk/Source/_javascript_Core/b3/testb3_2.cpp

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (280162 => 280163)

--- trunk/Source/_javascript_Core/ChangeLog	2021-07-21 21:43:21 UTC (rev 280162)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-07-21 22:24:28 UTC (rev 280163)
@@ -1,3 +1,15 @@
+2021-07-21  Yijia Huang  <yijia_hu...@apple.com>
+
+        Fix type check error in testb3
+        https://bugs.webkit.org/show_bug.cgi?id=228166
+
+        Reviewed by Saam Barati.
+
+        * b3/testb3_2.cpp:
+        (testXorNotWithLeftShift32):
+        (testXorNotWithRightShift32):
+        (testXorNotWithUnsignedRightShift32):
+
 2021-07-21  Keith Miller  <keith_mil...@apple.com>
 
         speculateNeitherDoubleNorStringNorHeapBigInt should only have a single JSType branch

Modified: trunk/Source/_javascript_Core/b3/testb3_2.cpp (280162 => 280163)

--- trunk/Source/_javascript_Core/b3/testb3_2.cpp	2021-07-21 21:43:21 UTC (rev 280162)
+++ trunk/Source/_javascript_Core/b3/testb3_2.cpp	2021-07-21 22:24:28 UTC (rev 280163)
@@ -4511,7 +4511,7 @@
             proc, Trunc, Origin(), 
             root->appendNew<ArgumentRegValue>(proc, Origin(), GPRInfo::argumentGPR1));
         Value* amountValue = root->appendNew<Const32Value>(proc, Origin(), amount);
-        Value* minusOneValue = root->appendNew<Const64Value>(proc, Origin(), -1);
+        Value* minusOneValue = root->appendNew<Const32Value>(proc, Origin(), -1);
 
         Value* shiftValue = root->appendNew<Value>(proc, Shl, Origin(), mValue, amountValue);
         Value* xorValue = root->appendNew<Value>(proc, BitXor, Origin(), shiftValue, minusOneValue);
@@ -4558,7 +4558,7 @@
             proc, Trunc, Origin(), 
             root->appendNew<ArgumentRegValue>(proc, Origin(), GPRInfo::argumentGPR1));
         Value* amountValue = root->appendNew<Const32Value>(proc, Origin(), amount);
-        Value* minusOneValue = root->appendNew<Const64Value>(proc, Origin(), -1);
+        Value* minusOneValue = root->appendNew<Const32Value>(proc, Origin(), -1);
 
         Value* shiftValue = root->appendNew<Value>(proc, SShr, Origin(), mValue, amountValue);
         Value* xorValue = root->appendNew<Value>(proc, BitXor, Origin(), shiftValue, minusOneValue);
@@ -4605,7 +4605,7 @@
             proc, Trunc, Origin(), 
             root->appendNew<ArgumentRegValue>(proc, Origin(), GPRInfo::argumentGPR1));
         Value* amountValue = root->appendNew<Const32Value>(proc, Origin(), amount);
-        Value* minusOneValue = root->appendNew<Const64Value>(proc, Origin(), -1);
+        Value* minusOneValue = root->appendNew<Const32Value>(proc, Origin(), -1);
 
         Value* shiftValue = root->appendNew<Value>(proc, ZShr, Origin(), mValue, amountValue);
         Value* xorValue = root->appendNew<Value>(proc, BitXor, Origin(), shiftValue, minusOneValue);

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes