Title: [280179] trunk/Source/WebCore
- Revision
- 280179
- Author
- [email protected]
- Date
- 2021-07-22 10:18:20 -0700 (Thu, 22 Jul 2021)
Log Message
Compilation error with gcc version 9.3.0 (Buildroot 2020.08-14-ge5a2a90)
https://bugs.webkit.org/show_bug.cgi?id=228184
Reviewed by Chris Dumez.
Turn destructors into virtual ones for RTCRtpReceiver and RTCRtpSender.
It seems that gcc doesn't create a virtual table for these classes, while clang does. That
would the cause, when compiling clang, ImplementationLacksVTable is not needed in the IDL
file. The approach for this fix to force the virtual table creation by turning destructors
into virtual.
No new tests needed.
* Modules/mediastream/RTCRtpReceiver.h:
* Modules/mediastream/RTCRtpSender.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (280178 => 280179)
--- trunk/Source/WebCore/ChangeLog 2021-07-22 17:07:21 UTC (rev 280178)
+++ trunk/Source/WebCore/ChangeLog 2021-07-22 17:18:20 UTC (rev 280179)
@@ -1,3 +1,22 @@
+2021-07-22 Víctor Manuel Jáquez Leal <[email protected]>
+
+ Compilation error with gcc version 9.3.0 (Buildroot 2020.08-14-ge5a2a90)
+ https://bugs.webkit.org/show_bug.cgi?id=228184
+
+ Reviewed by Chris Dumez.
+
+ Turn destructors into virtual ones for RTCRtpReceiver and RTCRtpSender.
+
+ It seems that gcc doesn't create a virtual table for these classes, while clang does. That
+ would the cause, when compiling clang, ImplementationLacksVTable is not needed in the IDL
+ file. The approach for this fix to force the virtual table creation by turning destructors
+ into virtual.
+
+ No new tests needed.
+
+ * Modules/mediastream/RTCRtpReceiver.h:
+ * Modules/mediastream/RTCRtpSender.h:
+
2021-07-22 Megan Gardner <[email protected]>
Avoid Quick Note overlay when scrolling to show a highlight
Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver.h (280178 => 280179)
--- trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver.h 2021-07-22 17:07:21 UTC (rev 280178)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver.h 2021-07-22 17:18:20 UTC (rev 280179)
@@ -56,7 +56,7 @@
{
return adoptRef(*new RTCRtpReceiver(connection, WTFMove(track), WTFMove(backend)));
}
- ~RTCRtpReceiver();
+ virtual ~RTCRtpReceiver();
static std::optional<RTCRtpCapabilities> getCapabilities(ScriptExecutionContext&, const String& kind);
Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.h (280178 => 280179)
--- trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.h 2021-07-22 17:07:21 UTC (rev 280178)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.h 2021-07-22 17:18:20 UTC (rev 280179)
@@ -58,7 +58,7 @@
public:
static Ref<RTCRtpSender> create(RTCPeerConnection&, Ref<MediaStreamTrack>&&, std::unique_ptr<RTCRtpSenderBackend>&&);
static Ref<RTCRtpSender> create(RTCPeerConnection&, String&& trackKind, std::unique_ptr<RTCRtpSenderBackend>&&);
- ~RTCRtpSender();
+ virtual ~RTCRtpSender();
static std::optional<RTCRtpCapabilities> getCapabilities(ScriptExecutionContext&, const String& kind);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
