Title: [280213] trunk/Source/WebCore
Revision
280213
Author
[email protected]
Date
2021-07-22 19:00:57 -0700 (Thu, 22 Jul 2021)

Log Message

Unreviewed, reverting 280130.
https://bugs.webkit.org/show_bug.cgi?id=228212

Introduced MotionMark regression

Reverted changeset:


* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedLayout):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (280212 => 280213)


--- trunk/Source/WebCore/ChangeLog	2021-07-23 02:00:13 UTC (rev 280212)
+++ trunk/Source/WebCore/ChangeLog	2021-07-23 02:00:57 UTC (rev 280213)
@@ -1,3 +1,15 @@
+2021-07-22  Said Abou-Hallawa  <[email protected]>
+
+        Unreviewed, reverting 280130.
+        https://bugs.webkit.org/show_bug.cgi?id=228212
+
+        Introduced MotionMark regression
+
+        Reverted changeset:
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::simplifiedLayout):
+
 2021-07-22  Chris Dumez  <[email protected]>
 
         The network process fails to take a locked file assertion when executing a SQLiteStatement outside a transaction

Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (280212 => 280213)


--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2021-07-23 02:00:13 UTC (rev 280212)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2021-07-23 02:00:57 UTC (rev 280213)
@@ -940,12 +940,8 @@
     // relative positioned container. So if we can have fixed pos objects in our positioned objects list check if any of them
     // are statically positioned and thus need to move with their absolute ancestors.
     bool canContainFixedPosObjects = canContainFixedPositionObjects();
-    if (posChildNeedsLayout() || canContainFixedPosObjects) {
-        // FIXME: Remove this early return once https://webkit.org/b/228125 is fixed.
-        if (!hasPositionedObjects())
-            return false;
+    if (posChildNeedsLayout() || canContainFixedPosObjects)
         layoutPositionedObjects(false, !posChildNeedsLayout() && canContainFixedPosObjects);
-    }
 
     // Recompute our overflow information.
     // FIXME: We could do better here by computing a temporary overflow object from layoutPositionedObjects and only
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to