Title: [280243] trunk/Source/WebCore
- Revision
- 280243
- Author
- commit-qu...@webkit.org
- Date
- 2021-07-23 08:38:29 -0700 (Fri, 23 Jul 2021)
Log Message
[GStreamer][1.19] Warnings due to AppSinkCallbacks struct growth
https://bugs.webkit.org/show_bug.cgi?id=228229
Patch by Philippe Normand <pnorm...@igalia.com> on 2021-07-23
Reviewed by Xabier Rodriguez-Calvar.
A new callback was added, for event notifications.
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::handleNewDeinterleavePad):
* platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
(WebCore::AudioSourceProviderGStreamer::handleNewDeinterleavePad):
* platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
(WebCore::ImageDecoderGStreamer::InnerDecoder::connectDecoderPad):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (280242 => 280243)
--- trunk/Source/WebCore/ChangeLog 2021-07-23 11:39:35 UTC (rev 280242)
+++ trunk/Source/WebCore/ChangeLog 2021-07-23 15:38:29 UTC (rev 280243)
@@ -1,3 +1,19 @@
+2021-07-23 Philippe Normand <pnorm...@igalia.com>
+
+ [GStreamer][1.19] Warnings due to AppSinkCallbacks struct growth
+ https://bugs.webkit.org/show_bug.cgi?id=228229
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ A new callback was added, for event notifications.
+
+ * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
+ (WebCore::AudioFileReader::handleNewDeinterleavePad):
+ * platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
+ (WebCore::AudioSourceProviderGStreamer::handleNewDeinterleavePad):
+ * platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
+ (WebCore::ImageDecoderGStreamer::InnerDecoder::connectDecoderPad):
+
2021-07-23 Devin Rousso <drou...@apple.com>
[Modern Media Controls] [macOS] Only show total duration when the elapsed time is visible
Modified: trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp (280242 => 280243)
--- trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp 2021-07-23 11:39:35 UTC (rev 280242)
+++ trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp 2021-07-23 15:38:29 UTC (rev 280243)
@@ -258,6 +258,10 @@
[](GstAppSink* sink, gpointer userData) -> GstFlowReturn {
return static_cast<AudioFileReader*>(userData)->handleSample(sink);
},
+#if GST_CHECK_VERSION(1, 19, 1)
+ // new_event
+ nullptr,
+#endif
{ nullptr }
};
gst_app_sink_set_callbacks(GST_APP_SINK(sink), &callbacks, this, nullptr);
Modified: trunk/Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp (280242 => 280243)
--- trunk/Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp 2021-07-23 11:39:35 UTC (rev 280242)
+++ trunk/Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp 2021-07-23 15:38:29 UTC (rev 280243)
@@ -311,6 +311,10 @@
[](GstAppSink* sink, gpointer userData) -> GstFlowReturn {
return static_cast<AudioSourceProviderGStreamer*>(userData)->handleSample(sink, false);
},
+#if GST_CHECK_VERSION(1, 19, 0)
+ // new_event
+ nullptr,
+#endif
{ nullptr }
};
gst_app_sink_set_callbacks(GST_APP_SINK(sink), &callbacks, this, nullptr);
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp (280242 => 280243)
--- trunk/Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp 2021-07-23 11:39:35 UTC (rev 280242)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp 2021-07-23 15:38:29 UTC (rev 280243)
@@ -261,6 +261,10 @@
static_cast<ImageDecoderGStreamer*>(userData)->notifySample(WTFMove(sample));
return GST_FLOW_OK;
},
+#if GST_CHECK_VERSION(1, 19, 1)
+ // new_event
+ nullptr,
+#endif
{ nullptr }
};
gst_app_sink_set_callbacks(GST_APP_SINK(sink), &callbacks, &m_decoder, nullptr);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
