Title: [280247] trunk/Source/WebKit
- Revision
- 280247
- Author
- [email protected]
- Date
- 2021-07-23 10:33:42 -0700 (Fri, 23 Jul 2021)
Log Message
Generate simulated crash when UI process fails to get network process connection
https://bugs.webkit.org/show_bug.cgi?id=228203
Reviewed by Geoffrey Garen.
To help diagnose the issue that web process sometimes fails to get connection to the network process
(rdar://80760179), as UI process should have more information about it than web process.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (280246 => 280247)
--- trunk/Source/WebKit/ChangeLog 2021-07-23 17:27:50 UTC (rev 280246)
+++ trunk/Source/WebKit/ChangeLog 2021-07-23 17:33:42 UTC (rev 280247)
@@ -1,3 +1,16 @@
+2021-07-23 Sihui Liu <[email protected]>
+
+ Generate simulated crash when UI process fails to get network process connection
+ https://bugs.webkit.org/show_bug.cgi?id=228203
+
+ Reviewed by Geoffrey Garen.
+
+ To help diagnose the issue that web process sometimes fails to get connection to the network process
+ (rdar://80760179), as UI process should have more information about it than web process.
+
+ * UIProcess/Network/NetworkProcessProxy.cpp:
+ (WebKit::NetworkProcessProxy::getNetworkProcessConnection):
+
2021-07-23 Myles C. Maxfield <[email protected]>
[GPU Process] Migrate the DisplayList::Replayer::Delegate from RemoteImageBuffer to RemoteRenderingBackend
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (280246 => 280247)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2021-07-23 17:27:50 UTC (rev 280246)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2021-07-23 17:33:42 UTC (rev 280247)
@@ -246,13 +246,13 @@
startResponsivenessTimer(UseLazyStop::No);
sendWithAsyncReply(Messages::NetworkProcess::CreateNetworkConnectionToWebProcess { webProcessProxy.coreProcessIdentifier(), webProcessProxy.sessionID() }, [this, weakThis = makeWeakPtr(*this), reply = WTFMove(reply)](auto&& identifier, auto cookieAcceptPolicy) mutable {
if (!weakThis) {
- RELEASE_LOG_ERROR(Process, "NetworkProcessProxy::getNetworkProcessConnection: NetworkProcessProxy deallocated during connection establishment");
+ RELEASE_LOG_FAULT(Process, "NetworkProcessProxy::getNetworkProcessConnection: NetworkProcessProxy deallocated during connection establishment");
return reply({ });
}
stopResponsivenessTimer();
if (!identifier) {
- RELEASE_LOG_ERROR(Process, "NetworkProcessProxy::getNetworkProcessConnection: connection identifier is empty");
+ RELEASE_LOG_FAULT(Process, "NetworkProcessProxy::getNetworkProcessConnection: connection identifier is empty");
return reply({ });
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
