Title: [280311] trunk/Source/WebKit
- Revision
- 280311
- Author
- [email protected]
- Date
- 2021-07-26 13:40:10 -0700 (Mon, 26 Jul 2021)
Log Message
Attribution context causes some performance regressions
https://bugs.webkit.org/show_bug.cgi?id=228294
<rdar://problem/76663528>
Reviewed by Per Arne Vollan.
Attribution context is used by the networking stack for a variety of
purposes, but is not always needed and can negatively affect
performance. For these reasons, we should override it in some cases.
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(overrideAttributionContext):
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (280310 => 280311)
--- trunk/Source/WebKit/ChangeLog 2021-07-26 20:15:49 UTC (rev 280310)
+++ trunk/Source/WebKit/ChangeLog 2021-07-26 20:40:10 UTC (rev 280311)
@@ -1,3 +1,19 @@
+2021-07-26 Kate Cheney <[email protected]>
+
+ Attribution context causes some performance regressions
+ https://bugs.webkit.org/show_bug.cgi?id=228294
+ <rdar://problem/76663528>
+
+ Reviewed by Per Arne Vollan.
+
+ Attribution context is used by the networking stack for a variety of
+ purposes, but is not always needed and can negatively affect
+ performance. For these reasons, we should override it in some cases.
+
+ * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+ (overrideAttributionContext):
+ (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+
2021-07-26 Jer Noble <[email protected]>
[Cocoa] Playback stalls on bilibili.com
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (280310 => 280311)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2021-07-26 20:15:49 UTC (rev 280310)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2021-07-26 20:40:10 UTC (rev 280311)
@@ -58,6 +58,7 @@
#import <WebKitAdditions/NetworkDataTaskCocoaAdditions.h>
#else
static void processPCMRequest(WebCore::PrivateClickMeasurement::PcmDataCarried, NSMutableURLRequest *) { };
+static void overrideAttributionContext(NSMutableURLRequest *) { };
#endif
namespace WebKit {
@@ -344,6 +345,8 @@
mutableRequest.get().attribution = request.isAppInitiated() ? NSURLRequestAttributionDeveloper : NSURLRequestAttributionUser;
#endif
+ overrideAttributionContext(mutableRequest.get());
+
if (parameters.pcmDataCarried)
processPCMRequest(*parameters.pcmDataCarried, mutableRequest.get());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
