- Revision
- 280318
- Author
- [email protected]
- Date
- 2021-07-26 15:07:20 -0700 (Mon, 26 Jul 2021)
Log Message
The layout test fast/images/heic-as-background-image.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=228195
<rdar://80334724>
Reviewed by Said Abou-Hallawa.
Source/WebKit:
Call correct system function for required initialization.
No new tests, covered by existing test.
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Source/WTF:
Add HAVE macro for the system function CMPhotoIsTileDecoderAvailable.
* wtf/PlatformHave.h:
LayoutTests:
Update test expectations.
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (280317 => 280318)
--- trunk/LayoutTests/ChangeLog 2021-07-26 21:59:15 UTC (rev 280317)
+++ trunk/LayoutTests/ChangeLog 2021-07-26 22:07:20 UTC (rev 280318)
@@ -1,3 +1,15 @@
+2021-07-26 Per Arne <[email protected]>
+
+ The layout test fast/images/heic-as-background-image.html is a constant failure
+ https://bugs.webkit.org/show_bug.cgi?id=228195
+ <rdar://80334724>
+
+ Reviewed by Said Abou-Hallawa.
+
+ Update test expectations.
+
+ * platform/mac/TestExpectations:
+
2021-07-26 Frédéric Wang <[email protected]>
Crash in InsertParagraphSeparatorCommand::doApply
Modified: trunk/LayoutTests/platform/mac/TestExpectations (280317 => 280318)
--- trunk/LayoutTests/platform/mac/TestExpectations 2021-07-26 21:59:15 UTC (rev 280317)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2021-07-26 22:07:20 UTC (rev 280318)
@@ -1521,11 +1521,8 @@
# <rdar://problem/48781098>
[ Catalina+ ] fast/images/animated-heics-draw.html [ Pass ]
[ Catalina+ ] fast/images/animated-heics-verify.html [ Pass ]
-[ BigSur ] fast/images/heic-as-background-image.html [ Pass ]
+[ BigSur+ ] fast/images/heic-as-background-image.html [ Pass ]
-# rdar://80334724 ([ Monterey ] fast/images/heic-as-background-image.html is a constant failure)
-[ Monterey ] fast/images/heic-as-background-image.html [ ImageOnlyFailure ]
-
# <rdar://problem/40172428>
webkit.org/b/212172 [ Catalina ] fast/text/font-collection.html [ ImageOnlyFailure ]
[ Catalina+ ] fast/text/woff2.html [ Pass ImageOnlyFailure ]
@@ -2376,4 +2373,4 @@
# webkit.org/b/228200 Setting multiple test expectations for Monetery on OpenSource:
[ Monterey ] model-element/model-element-graphics-layers-opacity.html [ Pass Failure ]
-[ Monterey Debug arm64 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html [ Pass Failure Crash ]
\ No newline at end of file
+[ Monterey Debug arm64 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html [ Pass Failure Crash ]
Modified: trunk/Source/WTF/ChangeLog (280317 => 280318)
--- trunk/Source/WTF/ChangeLog 2021-07-26 21:59:15 UTC (rev 280317)
+++ trunk/Source/WTF/ChangeLog 2021-07-26 22:07:20 UTC (rev 280318)
@@ -1,3 +1,15 @@
+2021-07-26 Per Arne <[email protected]>
+
+ The layout test fast/images/heic-as-background-image.html is a constant failure
+ https://bugs.webkit.org/show_bug.cgi?id=228195
+ <rdar://80334724>
+
+ Reviewed by Said Abou-Hallawa.
+
+ Add HAVE macro for the system function CMPhotoIsTileDecoderAvailable.
+
+ * wtf/PlatformHave.h:
+
2021-07-26 Jer Noble <[email protected]>
[iOS] All home screen web apps resume when any home screen web app is foregrounded
Modified: trunk/Source/WTF/wtf/PlatformHave.h (280317 => 280318)
--- trunk/Source/WTF/wtf/PlatformHave.h 2021-07-26 21:59:15 UTC (rev 280317)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2021-07-26 22:07:20 UTC (rev 280318)
@@ -1098,6 +1098,10 @@
#define HAVE_WEBGL_COMPATIBLE_METAL 1
#endif
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000
+#define HAVE_CMPHOTO_TILE_DECODER_AVAILABLE 1
+#endif
+
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 110300 \
|| (PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 140500) \
|| (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED >= 70400) \
Modified: trunk/Source/WebKit/ChangeLog (280317 => 280318)
--- trunk/Source/WebKit/ChangeLog 2021-07-26 21:59:15 UTC (rev 280317)
+++ trunk/Source/WebKit/ChangeLog 2021-07-26 22:07:20 UTC (rev 280318)
@@ -1,3 +1,18 @@
+2021-07-26 Per Arne <[email protected]>
+
+ The layout test fast/images/heic-as-background-image.html is a constant failure
+ https://bugs.webkit.org/show_bug.cgi?id=228195
+ <rdar://80334724>
+
+ Reviewed by Said Abou-Hallawa.
+
+ Call correct system function for required initialization.
+
+ No new tests, covered by existing test.
+
+ * WebProcess/cocoa/WebProcessCocoa.mm:
+ (WebKit::WebProcess::platformInitializeWebProcess):
+
2021-07-26 Kate Cheney <[email protected]>
Attribution context causes some performance regressions
Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (280317 => 280318)
--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2021-07-26 21:59:15 UTC (rev 280317)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2021-07-26 22:07:20 UTC (rev 280318)
@@ -172,6 +172,11 @@
SOFT_LINK_CLASS(CoreServices, _LSDService)
SOFT_LINK_CLASS(CoreServices, _LSDOpenService)
+#if HAVE(CMPHOTO_TILE_DECODER_AVAILABLE)
+SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL(CMPhoto)
+SOFT_LINK_FUNCTION_MAY_FAIL_FOR_SOURCE(WebKit, CMPhoto, CMPhotoIsTileDecoderAvailable, Boolean, (CMVideoCodecType decoder), (decoder))
+#endif
+
#define RELEASE_LOG_SESSION_ID (m_sessionID ? m_sessionID->toUInt64() : 0)
#define WEBPROCESS_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - [sessionID=%" PRIu64 "] WebProcess::" fmt, this, RELEASE_LOG_SESSION_ID, ##__VA_ARGS__)
#define WEBPROCESS_RELEASE_LOG_ERROR(channel, fmt, ...) RELEASE_LOG_ERROR(channel, "%p - [sessionID=%" PRIu64 "] WebProcess::" fmt, this, RELEASE_LOG_SESSION_ID, ##__VA_ARGS__)
@@ -377,9 +382,14 @@
if (auto extension = SandboxExtension::create(WTFMove(*parameters.trustdAgentExtensionHandle))) {
bool ok = extension->consume();
// The purpose of calling this function is to initialize a static variable which needs
- // the service com.apple.trustd.gent. And this is why we do not use its return value.
+ // the service com.apple.trustd.agent. And this is why we do not use its return value.
+#if HAVE(CMPHOTO_TILE_DECODER_AVAILABLE)
+ if (CMPhotoLibrary() && canLoad_CMPhoto_CMPhotoIsTileDecoderAvailable())
+ softLink_CMPhoto_CMPhotoIsTileDecoderAvailable('hvc1');
+#else
if (PAL::isMediaToolboxFrameworkAvailable() && PAL::canLoad_MediaToolbox_FigPhotoSupportsHEVCHWDecode())
PAL::softLinkMediaToolboxFigPhotoSupportsHEVCHWDecode();
+#endif
ok = extension->revoke();
ASSERT_UNUSED(ok, ok);
}
