Title: [280342] trunk
- Revision
- 280342
- Author
- [email protected]
- Date
- 2021-07-27 10:20:54 -0700 (Tue, 27 Jul 2021)
Log Message
document.referrer value is missing trailing slash
https://bugs.webkit.org/show_bug.cgi?id=215080
Patch by Alex Christensen <[email protected]> on 2021-07-27
Reviewed by John Wilander.
Source/WebCore:
This matches the behavior of Chrome and Firefox.
The solution is similar to that of bug 227795.
Covered by a few layout tests.
* dom/Document.cpp:
(WebCore::Document::referrer):
LayoutTests:
* http/tests/resourceLoadStatistics/downgrade-document-referrer-nested-third-party-iframe-expected.txt:
* http/tests/resourceLoadStatistics/downgrade-document-referrer-third-party-iframe-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (280341 => 280342)
--- trunk/LayoutTests/ChangeLog 2021-07-27 16:34:34 UTC (rev 280341)
+++ trunk/LayoutTests/ChangeLog 2021-07-27 17:20:54 UTC (rev 280342)
@@ -1,3 +1,13 @@
+2021-07-27 Alex Christensen <[email protected]>
+
+ document.referrer value is missing trailing slash
+ https://bugs.webkit.org/show_bug.cgi?id=215080
+
+ Reviewed by John Wilander.
+
+ * http/tests/resourceLoadStatistics/downgrade-document-referrer-nested-third-party-iframe-expected.txt:
+ * http/tests/resourceLoadStatistics/downgrade-document-referrer-third-party-iframe-expected.txt:
+
2021-07-27 Ayumi Kojima <[email protected]>
[iOS Release] imported/w3c/web-platform-tests/worklets/audio-worklet-service-worker-interception.https.html is flaky.
Modified: trunk/LayoutTests/http/tests/resourceLoadStatistics/downgrade-document-referrer-nested-third-party-iframe-expected.txt (280341 => 280342)
--- trunk/LayoutTests/http/tests/resourceLoadStatistics/downgrade-document-referrer-nested-third-party-iframe-expected.txt 2021-07-27 16:34:34 UTC (rev 280341)
+++ trunk/LayoutTests/http/tests/resourceLoadStatistics/downgrade-document-referrer-nested-third-party-iframe-expected.txt 2021-07-27 17:20:54 UTC (rev 280342)
@@ -3,7 +3,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS document.referrer is http://127.0.0.1:8000
+PASS document.referrer is http://127.0.0.1:8000/
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/http/tests/resourceLoadStatistics/downgrade-document-referrer-third-party-iframe-expected.txt (280341 => 280342)
--- trunk/LayoutTests/http/tests/resourceLoadStatistics/downgrade-document-referrer-third-party-iframe-expected.txt 2021-07-27 16:34:34 UTC (rev 280341)
+++ trunk/LayoutTests/http/tests/resourceLoadStatistics/downgrade-document-referrer-third-party-iframe-expected.txt 2021-07-27 17:20:54 UTC (rev 280342)
@@ -3,7 +3,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS document.referrer is http://127.0.0.1:8000
+PASS document.referrer is http://127.0.0.1:8000/
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/Source/WebCore/ChangeLog (280341 => 280342)
--- trunk/Source/WebCore/ChangeLog 2021-07-27 16:34:34 UTC (rev 280341)
+++ trunk/Source/WebCore/ChangeLog 2021-07-27 17:20:54 UTC (rev 280342)
@@ -1,3 +1,17 @@
+2021-07-27 Alex Christensen <[email protected]>
+
+ document.referrer value is missing trailing slash
+ https://bugs.webkit.org/show_bug.cgi?id=215080
+
+ Reviewed by John Wilander.
+
+ This matches the behavior of Chrome and Firefox.
+ The solution is similar to that of bug 227795.
+ Covered by a few layout tests.
+
+ * dom/Document.cpp:
+ (WebCore::Document::referrer):
+
2021-07-26 Said Abou-Hallawa <[email protected]>
Regulate the WebPage RenderingUpdates from the WebProcess to the GPUProcess
Modified: trunk/Source/WebCore/dom/Document.cpp (280341 => 280342)
--- trunk/Source/WebCore/dom/Document.cpp 2021-07-27 16:34:34 UTC (rev 280341)
+++ trunk/Source/WebCore/dom/Document.cpp 2021-07-27 17:20:54 UTC (rev 280342)
@@ -5267,7 +5267,7 @@
URL referrerURL { URL(), referrerStr };
RegistrableDomain referrerRegistrableDomain { referrerURL };
if (!referrerRegistrableDomain.matches(securityOrigin().data())) {
- m_referrerOverride = referrerURL.protocolHostAndPort();
+ m_referrerOverride = URL(URL(), referrerURL.protocolHostAndPort()).string();
return m_referrerOverride;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
