Title: [280370] trunk/Source/_javascript_Core
- Revision
- 280370
- Author
- [email protected]
- Date
- 2021-07-27 19:32:49 -0700 (Tue, 27 Jul 2021)
Log Message
Web Inspector: [Cocoa] "RemoteInspector XPC connection to relay failed." messages are confusing in StdErr
https://bugs.webkit.org/show_bug.cgi?id=228303
Reviewed by Darin Adler.
Remove overly verbose and confusing `WTFLogAlways` messages added in r278413, which can confuse applications
listening to stderr of a process using _javascript_Core.
* inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::xpcConnectionFailed):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (280369 => 280370)
--- trunk/Source/_javascript_Core/ChangeLog 2021-07-28 02:20:42 UTC (rev 280369)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-07-28 02:32:49 UTC (rev 280370)
@@ -1,3 +1,16 @@
+2021-07-27 Patrick Angle <[email protected]>
+
+ Web Inspector: [Cocoa] "RemoteInspector XPC connection to relay failed." messages are confusing in StdErr
+ https://bugs.webkit.org/show_bug.cgi?id=228303
+
+ Reviewed by Darin Adler.
+
+ Remove overly verbose and confusing `WTFLogAlways` messages added in r278413, which can confuse applications
+ listening to stderr of a process using _javascript_Core.
+
+ * inspector/remote/cocoa/RemoteInspectorCocoa.mm:
+ (Inspector::RemoteInspector::xpcConnectionFailed):
+
2021-07-27 Alexey Shvayka <[email protected]>
ProxyObject callees should be skipped during Function.prototype.caller resolution
Modified: trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm (280369 => 280370)
--- trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm 2021-07-28 02:20:42 UTC (rev 280369)
+++ trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm 2021-07-28 02:32:49 UTC (rev 280370)
@@ -373,13 +373,10 @@
// The XPC connection will close itself.
m_relayConnection = nullptr;
- if (!m_shouldReconnectToRelayOnFailure) {
- WTFLogAlways("RemoteInspector XPC connection to relay failed.");
+ if (!m_shouldReconnectToRelayOnFailure)
return;
- }
m_shouldReconnectToRelayOnFailure = false;
- WTFLogAlways("RemoteInspector XPC connection to relay failed, reconnecting in 1 second...");
// Schedule setting up a new connection, since we currently are holding a lock needed to create a new connection.
dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 1 * NSEC_PER_SEC), dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
