Title: [280396] trunk/Source/WebCore
- Revision
- 280396
- Author
- [email protected]
- Date
- 2021-07-28 12:31:54 -0700 (Wed, 28 Jul 2021)
Log Message
AppHighlightStorage should not inherit privately from RefCounted
https://bugs.webkit.org/show_bug.cgi?id=228562
Reviewed by Wenson Hsieh.
AppHighlightStorage is only stored with unique_ptr. There is no reason for this class
to *privately* inherit from RefCounted.
* Modules/highlight/AppHighlightStorage.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (280395 => 280396)
--- trunk/Source/WebCore/ChangeLog 2021-07-28 19:26:49 UTC (rev 280395)
+++ trunk/Source/WebCore/ChangeLog 2021-07-28 19:31:54 UTC (rev 280396)
@@ -1,5 +1,17 @@
2021-07-28 Ryosuke Niwa <[email protected]>
+ AppHighlightStorage should not inherit privately from RefCounted
+ https://bugs.webkit.org/show_bug.cgi?id=228562
+
+ Reviewed by Wenson Hsieh.
+
+ AppHighlightStorage is only stored with unique_ptr. There is no reason for this class
+ to *privately* inherit from RefCounted.
+
+ * Modules/highlight/AppHighlightStorage.h:
+
+2021-07-28 Ryosuke Niwa <[email protected]>
+
Deploy more use of smart pointers in Document.cpp
​https://bugs.webkit.org/show_bug.cgi?id=228544
Modified: trunk/Source/WebCore/Modules/highlight/AppHighlightStorage.h (280395 => 280396)
--- trunk/Source/WebCore/Modules/highlight/AppHighlightStorage.h 2021-07-28 19:26:49 UTC (rev 280395)
+++ trunk/Source/WebCore/Modules/highlight/AppHighlightStorage.h 2021-07-28 19:31:54 UTC (rev 280396)
@@ -47,7 +47,7 @@
enum class ScrollToHighlight : bool { No, Yes };
-class AppHighlightStorage final : RefCounted<AppHighlightStorage> {
+class AppHighlightStorage final {
WTF_MAKE_FAST_ALLOCATED;
public:
AppHighlightStorage(Document&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
