[webkit-changes] [280424] trunk/Source/WebKit

Thu, 29 Jul 2021 09:28:23 -0700

Title: [280424] trunk/Source/WebKit
Revision
280424
Author
[email protected]
Date
2021-07-29 09:27:43 -0700 (Thu, 29 Jul 2021)

Log Message

[macOS Catalina] Some feature preferences have wrong default values
https://bugs.webkit.org/show_bug.cgi?id=228564

Reviewed by Tim Horton.

When `HAVE(SYSTEM_FEATURE_FLAGS)` is false, we still need to enable
some features by default.

This patch makes sure the following features are enabled by default
on macOS (consistent with the properties in WebKit-macos.plist):
- async_frame_and_overflow_scrolling
- gpu_process_canvas_rendering
- gpu_process_media
- gpu_process_webrtc
- incremental_pdf
- vp9_decoder
- webm_format_reader
- webm_parser

* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
(WebKit::defaultUseGPUProcessForDOMRenderingEnabled):
(WebKit::defaultUseGPUProcessForMediaEnabled):
(WebKit::defaultCaptureAudioInGPUProcessEnabled):
(WebKit::defaultCaptureVideoInGPUProcessEnabled):
(WebKit::defaultWebRTCCodecsInGPUProcess):
(WebKit::defaultIncrementalPDFEnabled):
(WebKit::defaultWebMFormatReaderEnabled):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (280423 => 280424)


--- trunk/Source/WebKit/ChangeLog	2021-07-29 15:16:03 UTC (rev 280423)
+++ trunk/Source/WebKit/ChangeLog	2021-07-29 16:27:43 UTC (rev 280424)
@@ -1,3 +1,34 @@
+2021-07-29  Peng Liu  <[email protected]>
+
+        [macOS Catalina] Some feature preferences have wrong default values
+        https://bugs.webkit.org/show_bug.cgi?id=228564
+
+        Reviewed by Tim Horton.
+
+        When `HAVE(SYSTEM_FEATURE_FLAGS)` is false, we still need to enable
+        some features by default.
+
+        This patch makes sure the following features are enabled by default
+        on macOS (consistent with the properties in WebKit-macos.plist):
+        - async_frame_and_overflow_scrolling
+        - gpu_process_canvas_rendering
+        - gpu_process_media
+        - gpu_process_webrtc
+        - incremental_pdf
+        - vp9_decoder
+        - webm_format_reader
+        - webm_parser
+
+        * Shared/WebPreferencesDefaultValues.cpp:
+        (WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
+        (WebKit::defaultUseGPUProcessForDOMRenderingEnabled):
+        (WebKit::defaultUseGPUProcessForMediaEnabled):
+        (WebKit::defaultCaptureAudioInGPUProcessEnabled):
+        (WebKit::defaultCaptureVideoInGPUProcessEnabled):
+        (WebKit::defaultWebRTCCodecsInGPUProcess):
+        (WebKit::defaultIncrementalPDFEnabled):
+        (WebKit::defaultWebMFormatReaderEnabled):
+
 2021-07-29  Youenn Fablet  <[email protected]>
 
         NetworkRTCUDPSocketCocoaConnections nw_listener_set_state_changed_handler callback should hold a reference to its listener

Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (280423 => 280424)


--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2021-07-29 15:16:03 UTC (rev 280423)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2021-07-29 16:27:43 UTC (rev 280424)
@@ -149,29 +149,41 @@
 
 bool defaultUseGPUProcessForCanvasRenderingEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if HAVE(SYSTEM_FEATURE_FLAGS)
     return isFeatureFlagEnabled("gpu_process_canvas_rendering");
+#else
+    return true;
+#endif // HAVE(SYSTEM_FEATURE_FLAGS)
+#else
+    return false;
 #endif
-
-    return false;
 }
 
 bool defaultUseGPUProcessForDOMRenderingEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if HAVE(SYSTEM_FEATURE_FLAGS)
     return isFeatureFlagEnabled("gpu_process_dom_rendering");
+#else
+    return false;
+#endif // HAVE(SYSTEM_FEATURE_FLAGS)
+#else
+    return false;
 #endif
-
-    return false;
 }
 
 bool defaultUseGPUProcessForMediaEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if HAVE(SYSTEM_FEATURE_FLAGS)
     return isFeatureFlagEnabled("gpu_process_media");
+#else
+    return true;
+#endif // HAVE(SYSTEM_FEATURE_FLAGS)
+#else
+    return false;
 #endif
-
-    return false;
 }
 
 bool defaultUseGPUProcessForWebGLEnabled()
@@ -189,14 +201,21 @@
 
 bool defaultCaptureAudioInGPUProcessEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+
+#if HAVE(SYSTEM_FEATURE_FLAGS)
 #if PLATFORM(MAC)
     return isFeatureFlagEnabled("gpu_process_webrtc");
 #elif PLATFORM(IOS_FAMILY)
     return isFeatureFlagEnabled("gpu_process_media");
 #endif
+#else
+    return true;
+#endif // HAVE(SYSTEM_FEATURE_FLAGS)
+
+#else
+    return false;
 #endif
-    return false;
 }
 
 bool defaultCaptureAudioInUIProcessEnabled()
@@ -210,9 +229,13 @@
 
 bool defaultCaptureVideoInGPUProcessEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if HAVE(SYSTEM_FEATURE_FLAGS)
     return isFeatureFlagEnabled("gpu_process_webrtc");
 #else
+    return true;
+#endif // HAVE(SYSTEM_FEATURE_FLAGS)
+#else
     return false;
 #endif
 }
@@ -223,9 +246,13 @@
 
 bool defaultWebRTCCodecsInGPUProcess()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if HAVE(SYSTEM_FEATURE_FLAGS)
     return isFeatureFlagEnabled("gpu_process_webrtc");
 #else
+    return true;
+#endif // HAVE(SYSTEM_FEATURE_FLAGS)
+#else
     return false;
 #endif
 }
@@ -261,7 +288,11 @@
     return isFeatureFlagEnabled("incremental_pdf");
 #endif
 
+#if PLATFORM(MAC)
+    return true;
+#else
     return false;
+#endif
 }
 #endif
 
@@ -286,7 +317,11 @@
     return isFeatureFlagEnabled("webm_format_reader");
 #endif
 
+#if PLATFORM(MAC)
+    return true;
+#else
     return false;
+#endif
 }
 
 #endif // ENABLE(WEBM_FORMAT_READER)

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to