Title: [280437] trunk/Tools
- Revision
- 280437
- Author
- aakash_j...@apple.com
- Date
- 2021-07-29 11:44:40 -0700 (Thu, 29 Jul 2021)
Log Message
Send email notification when VerifyGitHubIntegrity step fails
https://bugs.webkit.org/show_bug.cgi?id=228592
Reviewed by Jonathan Bedard.
* CISupport/ews-build/emails.json:
* CISupport/ews-build/send_email.py:
(send_email_to_github_admin):
* CISupport/ews-build/steps.py:
(VerifyGitHubIntegrity):
(VerifyGitHubIntegrity.evaluateCommand):
(VerifyGitHubIntegrity.send_email_for_github_issue):
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/emails.json (280436 => 280437)
--- trunk/Tools/CISupport/ews-build/emails.json 2021-07-29 18:32:23 UTC (rev 280436)
+++ trunk/Tools/CISupport/ews-build/emails.json 2021-07-29 18:44:40 UTC (rev 280437)
@@ -3,6 +3,10 @@
"aakash_j...@apple.com",
"webkit-ews-bot-watch...@group.apple.com"
],
+ "GITHUB_ADMIN_EMAILS": [
+ "jbed...@apple.com",
+ "ad...@webkit.org"
+ ],
"APPLE_BOT_WATCHERS_EMAILS": [
"webkit-ews-bot-watch...@group.apple.com"
],
Modified: trunk/Tools/CISupport/ews-build/send_email.py (280436 => 280437)
--- trunk/Tools/CISupport/ews-build/send_email.py 2021-07-29 18:32:23 UTC (rev 280436)
+++ trunk/Tools/CISupport/ews-build/send_email.py 2021-07-29 18:44:40 UTC (rev 280437)
@@ -91,3 +91,7 @@
send_email(get_email_ids('IGALIA_JSC_TEAM_EMAILS'), subject, text, reference)
if any(pattern in builder_name.lower() for pattern in IGALIA_GTK_WPE_QUEUES_PATTERNS):
send_email(get_email_ids('IGALIA_GTK_WPE_EMAILS'), subject, text, reference)
+
+
+def send_email_to_github_admin(subject, text, reference=''):
+ send_email(get_email_ids('GITHUB_ADMIN_EMAILS'), subject, text, reference)
Modified: trunk/Tools/CISupport/ews-build/steps.py (280436 => 280437)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-07-29 18:32:23 UTC (rev 280436)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-07-29 18:44:40 UTC (rev 280437)
@@ -30,7 +30,7 @@
from twisted.internet import defer
from layout_test_failures import LayoutTestFailures
-from send_email import send_email_to_patch_author, send_email_to_bot_watchers
+from send_email import send_email_to_patch_author, send_email_to_bot_watchers, send_email_to_github_admin
import json
import os
@@ -3464,3 +3464,19 @@
if self.results != SUCCESS:
return {'step': 'GitHub integrity check failed'}
return {'step': 'Verified GitHub integrity'}
+
+ def evaluateCommand(self, cmd):
+ rc = shell.ShellCommand.evaluateCommand(self, cmd)
+ if rc != SUCCESS:
+ self.send_email_for_github_issue()
+ return rc
+
+ def send_email_for_github_issue(self):
+ try:
+ builder_name = self.getProperty('buildername', '')
+ build_url = '{}#/builders/{}/builds/{}'.format(self.master.config.buildbotURL, self.build._builderid, self.build.number)
+ email_subject = 'URGENT: GitHub integrity check failed'
+ email_text = 'URGENT issue on github repository. Integrity check failed.\n\nBuild: {}\n\nBuilder: {}'.format(build_url, builder_name)
+ send_email_to_github_admin(email_subject, email_text)
+ except Exception as e:
+ print('Error in sending email for github issue: {}'.format(e))
Modified: trunk/Tools/ChangeLog (280436 => 280437)
--- trunk/Tools/ChangeLog 2021-07-29 18:32:23 UTC (rev 280436)
+++ trunk/Tools/ChangeLog 2021-07-29 18:44:40 UTC (rev 280437)
@@ -1,3 +1,18 @@
+2021-07-29 Aakash Jain <aakash_j...@apple.com>
+
+ Send email notification when VerifyGitHubIntegrity step fails
+ https://bugs.webkit.org/show_bug.cgi?id=228592
+
+ Reviewed by Jonathan Bedard.
+
+ * CISupport/ews-build/emails.json:
+ * CISupport/ews-build/send_email.py:
+ (send_email_to_github_admin):
+ * CISupport/ews-build/steps.py:
+ (VerifyGitHubIntegrity):
+ (VerifyGitHubIntegrity.evaluateCommand):
+ (VerifyGitHubIntegrity.send_email_for_github_issue):
+
2021-07-29 Jonathan Bedard <jbed...@apple.com>
[git-webkit] Add identifiers to 'log' and 'blame'
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
