Title: [280471] trunk
- Revision
- 280471
- Author
- [email protected]
- Date
- 2021-07-30 02:09:44 -0700 (Fri, 30 Jul 2021)
Log Message
[AspectRatio] Fix replaced-element-034.html
https://bugs.webkit.org/show_bug.cgi?id=228223
Patch by Rob Buis <[email protected]> on 2021-07-30
Reviewed by Manuel Rego Casasnovas.
Source/WebCore:
Fix replaced-element-034.html by making hasReplacedLogicalHeight
return false for *-content when aspect-ratio is provided and relying
on computeReplacedLogicalHeight to take aspect-ratio into account.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::hasReplacedLogicalHeight const):
LayoutTests:
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (280470 => 280471)
--- trunk/LayoutTests/ChangeLog 2021-07-30 08:41:25 UTC (rev 280470)
+++ trunk/LayoutTests/ChangeLog 2021-07-30 09:09:44 UTC (rev 280471)
@@ -1,3 +1,12 @@
+2021-07-30 Rob Buis <[email protected]>
+
+ [AspectRatio] Fix replaced-element-034.html
+ https://bugs.webkit.org/show_bug.cgi?id=228223
+
+ Reviewed by Manuel Rego Casasnovas.
+
+ * TestExpectations:
+
2021-07-29 Tomoki Imai <[email protected]>
Missing playing events when the ready state becomes HAVE_FUTURE_DATA/HAVE_ENOUGH_DATA from HAVE_METADATA state
Modified: trunk/LayoutTests/TestExpectations (280470 => 280471)
--- trunk/LayoutTests/TestExpectations 2021-07-30 08:41:25 UTC (rev 280470)
+++ trunk/LayoutTests/TestExpectations 2021-07-30 09:09:44 UTC (rev 280471)
@@ -4713,7 +4713,6 @@
webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-022.html [ ImageOnlyFailure ]
webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-025.html [ ImageOnlyFailure ]
webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-026.html [ ImageOnlyFailure ]
-webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-034.html [ ImageOnlyFailure ]
webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-001.html [ ImageOnlyFailure ]
webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-002.html [ ImageOnlyFailure ]
webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-003.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (280470 => 280471)
--- trunk/Source/WebCore/ChangeLog 2021-07-30 08:41:25 UTC (rev 280470)
+++ trunk/Source/WebCore/ChangeLog 2021-07-30 09:09:44 UTC (rev 280471)
@@ -1,3 +1,17 @@
+2021-07-30 Rob Buis <[email protected]>
+
+ [AspectRatio] Fix replaced-element-034.html
+ https://bugs.webkit.org/show_bug.cgi?id=228223
+
+ Reviewed by Manuel Rego Casasnovas.
+
+ Fix replaced-element-034.html by making hasReplacedLogicalHeight
+ return false for *-content when aspect-ratio is provided and relying
+ on computeReplacedLogicalHeight to take aspect-ratio into account.
+
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::hasReplacedLogicalHeight const):
+
2021-07-29 Tomoki Imai <[email protected]>
Missing playing events when the ready state becomes HAVE_FUTURE_DATA/HAVE_ENOUGH_DATA from HAVE_METADATA state
Modified: trunk/Source/WebCore/rendering/RenderReplaced.cpp (280470 => 280471)
--- trunk/Source/WebCore/rendering/RenderReplaced.cpp 2021-07-30 08:41:25 UTC (rev 280470)
+++ trunk/Source/WebCore/rendering/RenderReplaced.cpp 2021-07-30 09:09:44 UTC (rev 280471)
@@ -363,7 +363,7 @@
return !hasAutoHeightOrContainingBlockWithAutoHeight();
if (style().logicalHeight().isIntrinsic())
- return true;
+ return !style().hasAspectRatio();
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
