Title: [280489] trunk/Source/_javascript_Core
- Revision
- 280489
- Author
- [email protected]
- Date
- 2021-07-30 11:56:07 -0700 (Fri, 30 Jul 2021)
Log Message
REGRESSION (r280460): 42 JSC test failures on Debug arm64 with ASSERTION FAILED: !m_needExceptionCheck
https://bugs.webkit.org/show_bug.cgi?id=228652
Unreviewed unchecked exception fix.
Release scope before calling RegExpGlobalData::getBackref().
* runtime/RegExpConstructor.cpp:
(JSC::JSC_DEFINE_CUSTOM_GETTER):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (280488 => 280489)
--- trunk/Source/_javascript_Core/ChangeLog 2021-07-30 18:49:47 UTC (rev 280488)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-07-30 18:56:07 UTC (rev 280489)
@@ -1,3 +1,15 @@
+2021-07-30 Alexey Shvayka <[email protected]>
+
+ REGRESSION (r280460): 42 JSC test failures on Debug arm64 with ASSERTION FAILED: !m_needExceptionCheck
+ https://bugs.webkit.org/show_bug.cgi?id=228652
+
+ Unreviewed unchecked exception fix.
+
+ Release scope before calling RegExpGlobalData::getBackref().
+
+ * runtime/RegExpConstructor.cpp:
+ (JSC::JSC_DEFINE_CUSTOM_GETTER):
+
2021-07-30 Yusuke Suzuki <[email protected]>
[JSC] Use UCPURegister argument to remove zero extension in JIT code
Modified: trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp (280488 => 280489)
--- trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp 2021-07-30 18:49:47 UTC (rev 280488)
+++ trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp 2021-07-30 18:56:07 UTC (rev 280489)
@@ -100,7 +100,7 @@
return throwVMTypeError(globalObject, scope, "RegExp.$N getters require RegExp constructor as |this|"_s);
unsigned N = propertyName.uid()->at(1) - '0';
ASSERT(N >= 1 && N <= 9);
- return JSValue::encode(globalObject->regExpGlobalData().getBackref(globalObject, N));
+ RELEASE_AND_RETURN(scope, JSValue::encode(globalObject->regExpGlobalData().getBackref(globalObject, N)));
}
JSC_DEFINE_CUSTOM_GETTER(regExpConstructorInput, (JSGlobalObject* globalObject, EncodedJSValue thisValue, PropertyName))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
