Title: [280501] trunk/Source/WebCore
- Revision
- 280501
- Author
- [email protected]
- Date
- 2021-07-30 16:04:07 -0700 (Fri, 30 Jul 2021)
Log Message
Add spacebar functionality for macOS smooth scrolling
https://bugs.webkit.org/show_bug.cgi?id=228155
Patch by Dana Estra <[email protected]> on 2021-07-30
Reviewed by Tim Horton.
Fixed bug that was causing spacebar events to return false from beginKeyboardScrollGesture.
Manually tested on webpage.
* platform/KeyboardScrollingAnimator.cpp:
(WebCore::KeyboardScrollingAnimator::beginKeyboardScrollGesture):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (280500 => 280501)
--- trunk/Source/WebCore/ChangeLog 2021-07-30 22:38:29 UTC (rev 280500)
+++ trunk/Source/WebCore/ChangeLog 2021-07-30 23:04:07 UTC (rev 280501)
@@ -1,3 +1,17 @@
+2021-07-30 Dana Estra <[email protected]>
+
+ Add spacebar functionality for macOS smooth scrolling
+ https://bugs.webkit.org/show_bug.cgi?id=228155
+
+ Reviewed by Tim Horton.
+
+ Fixed bug that was causing spacebar events to return false from beginKeyboardScrollGesture.
+
+ Manually tested on webpage.
+
+ * platform/KeyboardScrollingAnimator.cpp:
+ (WebCore::KeyboardScrollingAnimator::beginKeyboardScrollGesture):
+
2021-07-30 Chris Dumez <[email protected]>
Unreviewed follow-up to r280491 to address review feedback from Darin Adler.
Modified: trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp (280500 => 280501)
--- trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp 2021-07-30 22:38:29 UTC (rev 280500)
+++ trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp 2021-07-30 23:04:07 UTC (rev 280501)
@@ -230,7 +230,7 @@
m_currentKeyboardScroll = scroll;
- if (event.type() != eventNames().keydownEvent)
+ if (!(event.type() == eventNames().keydownEvent || event.type() == eventNames().keypressEvent))
return false;
if (m_scrollTriggeringKeyIsPressed)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
