Title: [280576] trunk
- Revision
- 280576
- Author
- [email protected]
- Date
- 2021-08-02 18:05:39 -0700 (Mon, 02 Aug 2021)
Log Message
[GPUP] RemoteAudioSession::setPreferredBufferSize() does not change its preferredBufferSize
https://bugs.webkit.org/show_bug.cgi?id=228720
Reviewed by Jer Noble.
Source/WebKit:
`RemoteAudioSession` should update its `preferredBufferSize` in
`setPreferredBufferSize()`. Otherwise, the `preferredBufferSize`
will become inconsistent with the value in the GPU process.
No new tests. Fix API test failures.
* WebProcess/GPU/media/RemoteAudioSession.cpp:
(WebKit::RemoteAudioSession::setPreferredBufferSize):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
(TEST_F):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (280575 => 280576)
--- trunk/Source/WebKit/ChangeLog 2021-08-03 00:55:12 UTC (rev 280575)
+++ trunk/Source/WebKit/ChangeLog 2021-08-03 01:05:39 UTC (rev 280576)
@@ -1,3 +1,19 @@
+2021-08-02 Peng Liu <[email protected]>
+
+ [GPUP] RemoteAudioSession::setPreferredBufferSize() does not change its preferredBufferSize
+ https://bugs.webkit.org/show_bug.cgi?id=228720
+
+ Reviewed by Jer Noble.
+
+ `RemoteAudioSession` should update its `preferredBufferSize` in
+ `setPreferredBufferSize()`. Otherwise, the `preferredBufferSize`
+ will become inconsistent with the value in the GPU process.
+
+ No new tests. Fix API test failures.
+
+ * WebProcess/GPU/media/RemoteAudioSession.cpp:
+ (WebKit::RemoteAudioSession::setPreferredBufferSize):
+
2021-08-02 Kate Cheney <[email protected]>
[App Privacy Report] Domains are deleted for ephemeral website data stores
Modified: trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp (280575 => 280576)
--- trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp 2021-08-03 00:55:12 UTC (rev 280575)
+++ trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp 2021-08-03 01:05:39 UTC (rev 280576)
@@ -109,6 +109,7 @@
void RemoteAudioSession::setPreferredBufferSize(size_t size)
{
+ configuration().preferredBufferSize = size;
ensureConnection().send(Messages::RemoteAudioSessionProxy::SetPreferredBufferSize(size), { });
}
Modified: trunk/Tools/ChangeLog (280575 => 280576)
--- trunk/Tools/ChangeLog 2021-08-03 00:55:12 UTC (rev 280575)
+++ trunk/Tools/ChangeLog 2021-08-03 01:05:39 UTC (rev 280576)
@@ -1,3 +1,13 @@
+2021-08-02 Peng Liu <[email protected]>
+
+ [GPUP] RemoteAudioSession::setPreferredBufferSize() does not change its preferredBufferSize
+ https://bugs.webkit.org/show_bug.cgi?id=228720
+
+ Reviewed by Jer Noble.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
+ (TEST_F):
+
2021-08-02 Alex Christensen <[email protected]>
Don't change invalid baseURLs from loadData or loadHTMLString to about:blank
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm (280575 => 280576)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm 2021-08-03 00:55:12 UTC (rev 280575)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm 2021-08-03 01:05:39 UTC (rev 280576)
@@ -79,32 +79,32 @@
EXPECT_EQ(512, preferredAudioBufferSize());
}
-TEST_F(PreferredAudioBufferSize, DISABLED_AudioElement)
+TEST_F(PreferredAudioBufferSize, AudioElement)
{
runPlayingTestWithPageNamed(@"audio-only", 4096);
}
-TEST_F(PreferredAudioBufferSize, DISABLED_WebAudio)
+TEST_F(PreferredAudioBufferSize, WebAudio)
{
runPlayingTestWithPageNamed(@"web-audio-only", 128);
}
-TEST_F(PreferredAudioBufferSize, DISABLED_VideoOnly)
+TEST_F(PreferredAudioBufferSize, VideoOnly)
{
runPlayingTestWithPageNamed(@"video-without-audio", 4096);
}
-TEST_F(PreferredAudioBufferSize, DISABLED_VideoWithAudio)
+TEST_F(PreferredAudioBufferSize, VideoWithAudio)
{
runPlayingTestWithPageNamed(@"video-with-audio", 4096);
}
-TEST_F(PreferredAudioBufferSize, DISABLED_AudioWithWebAudio)
+TEST_F(PreferredAudioBufferSize, AudioWithWebAudio)
{
runPlayingTestWithPageNamed(@"audio-with-web-audio", 128);
}
-TEST_F(PreferredAudioBufferSize, DISABLED_VideoWithAudioAndWebAudio)
+TEST_F(PreferredAudioBufferSize, VideoWithAudioAndWebAudio)
{
runPlayingTestWithPageNamed(@"video-with-audio-and-web-audio", 128);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
