Title: [280680] trunk/LayoutTests
Revision
280680
Author
wenson_hs...@apple.com
Date
2021-08-04 20:31:15 -0700 (Wed, 04 Aug 2021)

Log Message

Adjust editing/deleting/ios/backspace-last-character.html to check that pressing backspace deletes one character
https://bugs.webkit.org/show_bug.cgi?id=228806

Reviewed by Tim Horton.

Add test coverage for r280671 by augmenting an existing iOS editing test to verify that hitting backspace only
deletes a single character in a `textarea`.

* editing/deleting/ios/backspace-last-character-expected.txt:
* editing/deleting/ios/backspace-last-character.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (280679 => 280680)


--- trunk/LayoutTests/ChangeLog	2021-08-05 03:15:41 UTC (rev 280679)
+++ trunk/LayoutTests/ChangeLog	2021-08-05 03:31:15 UTC (rev 280680)
@@ -1,3 +1,16 @@
+2021-08-04  Wenson Hsieh  <wenson_hs...@apple.com>
+
+        Adjust editing/deleting/ios/backspace-last-character.html to check that pressing backspace deletes one character
+        https://bugs.webkit.org/show_bug.cgi?id=228806
+
+        Reviewed by Tim Horton.
+
+        Add test coverage for r280671 by augmenting an existing iOS editing test to verify that hitting backspace only
+        deletes a single character in a `textarea`.
+
+        * editing/deleting/ios/backspace-last-character-expected.txt:
+        * editing/deleting/ios/backspace-last-character.html:
+
 2021-08-04  Diego Pino Garcia  <dp...@igalia.com>
 
         [WPE] Unreviewed test gardening. Update baselines after r280672.

Modified: trunk/LayoutTests/editing/deleting/ios/backspace-last-character-expected.txt (280679 => 280680)


--- trunk/LayoutTests/editing/deleting/ios/backspace-last-character-expected.txt	2021-08-05 03:15:41 UTC (rev 280679)
+++ trunk/LayoutTests/editing/deleting/ios/backspace-last-character-expected.txt	2021-08-05 03:31:15 UTC (rev 280680)
@@ -1,11 +1,13 @@
 CONSOLE MESSAGE: Activating element and waiting for input session.
 CONSOLE MESSAGE: Waiting for element focus.
-CONSOLE MESSAGE: Typing 'w'.
+CONSOLE MESSAGE: Typing 'i'.
 CONSOLE MESSAGE: Waiting for first input event.
 CONSOLE MESSAGE: Hitting backspace.
 CONSOLE MESSAGE: Waiting for second input event.
+CONSOLE MESSAGE: Hitting backspace again.
+CONSOLE MESSAGE: Waiting for third input event.
 CONSOLE MESSAGE: Test complete.
-This tests using the software keyboard and pressing 'w' then backspace deletes the 'w' and does not cause an assertion failure in a debug build.
+This tests using the software keyboard and pressing 'i' then backspace twice to delete 'Hi'. This should not cause a debug assertion.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
@@ -12,8 +14,10 @@
 
 PASS inputDidFocus became true
 PASS inputEventCount became 1
-PASS document.getElementById("input").value is "w"
+PASS document.getElementById("input").value is "Hi"
 PASS inputEventCount became 2
+PASS document.getElementById("input").value is "H"
+PASS inputEventCount became 3
 PASS document.getElementById("input").value is ""
 PASS successfullyParsed is true
 

Modified: trunk/LayoutTests/editing/deleting/ios/backspace-last-character.html (280679 => 280680)


--- trunk/LayoutTests/editing/deleting/ios/backspace-last-character.html	2021-08-05 03:15:41 UTC (rev 280679)
+++ trunk/LayoutTests/editing/deleting/ios/backspace-last-character.html	2021-08-05 03:31:15 UTC (rev 280680)
@@ -6,7 +6,7 @@
 </head>
 <body>
 <div id="test-container">
-    <textarea id="input"></textarea>
+    <textarea id="input">H</textarea>
     <textarea id="output" readonly></textarea>
 </div>
 <script>
@@ -36,13 +36,13 @@
     console.log("Waiting for element focus.");
     await new Promise(resolve => shouldBecomeEqual("inputDidFocus", "true", resolve));
 
-    console.log("Typing 'w'.");
+    console.log("Typing 'i'.");
     if (window.testRunner)
-        await UIHelper.keyDown("w");
+        await UIHelper.keyDown("i");
 
     console.log("Waiting for first input event.");
     await new Promise(resolve => shouldBecomeEqual("inputEventCount", "1", resolve));
-    shouldBeEqualToString('document.getElementById("input").value', "w");
+    shouldBeEqualToString('document.getElementById("input").value', "Hi");
 
     console.log("Hitting backspace.");
     if (window.testRunner)
@@ -50,6 +50,14 @@
 
     console.log("Waiting for second input event.");
     await new Promise(resolve => shouldBecomeEqual("inputEventCount", "2", resolve));
+    shouldBeEqualToString('document.getElementById("input").value', "H");
+
+    console.log("Hitting backspace again.");
+    if (window.testRunner)
+        await UIHelper.keyDown("\b");
+
+    console.log("Waiting for third input event.");
+    await new Promise(resolve => shouldBecomeEqual("inputEventCount", "3", resolve));
     shouldBeEqualToString('document.getElementById("input").value', "");
 
     console.log("Test complete.");
@@ -57,7 +65,7 @@
     finishJSTest();
 }
 
-description("This tests using the software keyboard and pressing 'w' then <kbd>backspace</kbd> deletes the 'w' and does not cause an assertion failure in a debug build.");
+description("This tests using the software keyboard and pressing 'i' then <kbd>backspace</kbd> twice to delete 'Hi'. This should not cause a debug assertion.");
 input.addEventListener("keydown", appendANewline);
 
 runTest();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to