Title: [280713] trunk/Tools
- Revision
- 280713
- Author
- [email protected]
- Date
- 2021-08-05 18:01:32 -0700 (Thu, 05 Aug 2021)
Log Message
REGRESSION (r279855): TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages is failing
https://bugs.webkit.org/show_bug.cgi?id=228309
Unreviewed test gardening.
This test has been skipped on Apple Silicon because of timeouts, and
now it is a flaky failure on Intel machines. Disable it outright for
the time being.
* TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:
(TEST_F):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (280712 => 280713)
--- trunk/Tools/ChangeLog 2021-08-06 00:57:28 UTC (rev 280712)
+++ trunk/Tools/ChangeLog 2021-08-06 01:01:32 UTC (rev 280713)
@@ -11,6 +11,20 @@
* TestWebKitAPI/Tests/mac/load-web-archive-1.html:
+2021-08-05 Ryan Haddad <[email protected]>
+
+ REGRESSION (r279855): TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages is failing
+ https://bugs.webkit.org/show_bug.cgi?id=228309
+
+ Unreviewed test gardening.
+
+ This test has been skipped on Apple Silicon because of timeouts, and
+ now it is a flaky failure on Intel machines. Disable it outright for
+ the time be ing.
+
+ * TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:
+ (TEST_F):
+
2021-08-05 Zan Dobersek <[email protected]>
run-jsc-stress-tests: detect the riscv64 architecture
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm (280712 => 280713)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm 2021-08-06 00:57:28 UTC (rev 280712)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm 2021-08-06 01:01:32 UTC (rev 280713)
@@ -58,8 +58,7 @@
// On older macOSes, CFPREFS_DIRECT_MODE is disabled and the WebProcess does not see the updated AppleLanguages
// after the AppleLanguagePreferencesChangedNotification notification.
-// FIXME: This test is currently disabled on Apple Silicon because it times out there (https://bugs.webkit.org/show_bug.cgi?id=222619).
-#if PLATFORM(MAC) && ENABLE(CFPREFS_DIRECT_MODE) && CPU(X86_64)
+#if PLATFORM(MAC) && ENABLE(CFPREFS_DIRECT_MODE)
class AppleLanguagesTest : public testing::Test {
public:
AppleLanguagesTest()
@@ -109,7 +108,8 @@
return observer;
}
-TEST_F(AppleLanguagesTest, UpdateAppleLanguages)
+// FIXME: This test times out on Apple Silicon (webkit.org/b/222619) and is a flaky failure on Intel (webkit.org/b/228309)
+TEST_F(AppleLanguagesTest, DISABLED_UpdateAppleLanguages)
{
preferenceObserverSharedInstanceCalled = false;
Method sharedInstanceMethod = class_getClassMethod(objc_getClass("WKPreferenceObserver"), @selector(sharedInstance));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
