Title: [280734] trunk/Tools
Revision
280734
Author
[email protected]
Date
2021-08-06 13:24:31 -0700 (Fri, 06 Aug 2021)

Log Message

[Win][WebKitTestRunner] WTR::PlatformWebView leaks m_view (WKViewRef)
https://bugs.webkit.org/show_bug.cgi?id=228857

Reviewed by Don Olmstead.

Windows WebKitTestRunner leaked a lot of object because it leaked
WebKit::WebView that retains WebKit::WebPageProxy.

* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::~PlatformWebView): Release m_view.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (280733 => 280734)


--- trunk/Tools/ChangeLog	2021-08-06 19:56:31 UTC (rev 280733)
+++ trunk/Tools/ChangeLog	2021-08-06 20:24:31 UTC (rev 280734)
@@ -1,3 +1,16 @@
+2021-08-06  Fujii Hironori  <[email protected]>
+
+        [Win][WebKitTestRunner] WTR::PlatformWebView leaks m_view (WKViewRef)
+        https://bugs.webkit.org/show_bug.cgi?id=228857
+
+        Reviewed by Don Olmstead.
+
+        Windows WebKitTestRunner leaked a lot of object because it leaked
+        WebKit::WebView that retains WebKit::WebPageProxy.
+
+        * WebKitTestRunner/win/PlatformWebViewWin.cpp:
+        (WTR::PlatformWebView::~PlatformWebView): Release m_view.
+
 2021-08-06  Youenn Fablet  <[email protected]>
 
         [GPUP] Test WebKit2.CrashGPUProcessAfterApplyingConstraints fails when Media in GPU Process is enabled

Modified: trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp (280733 => 280734)


--- trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp	2021-08-06 19:56:31 UTC (rev 280733)
+++ trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp	2021-08-06 20:24:31 UTC (rev 280734)
@@ -97,6 +97,7 @@
 {
     if (::IsWindow(m_window))
         ::DestroyWindow(m_window);
+    WKRelease(m_view);
 }
 
 void PlatformWebView::resizeTo(unsigned width, unsigned height, WebViewSizingMode)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to