Title: [280751] trunk/Source/WebKit
- Revision
- 280751
- Author
- [email protected]
- Date
- 2021-08-06 18:39:53 -0700 (Fri, 06 Aug 2021)
Log Message
REGRESSION (r185111): Links to App Store doesn't work when opening a PDF in Safari on iOS and iPadOS
https://bugs.webkit.org/show_bug.cgi?id=228881
rdar://81294035
Reviewed by Andy Estes.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):
Clicking a link in PDF should absolutely be allowed to launch an external app.
Humorously, r185111 applied the correct value to PDFPlugin (macOS), but the
wrong value to WKPDFView (iOS). Bring them into alignment.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (280750 => 280751)
--- trunk/Source/WebKit/ChangeLog 2021-08-07 01:33:03 UTC (rev 280750)
+++ trunk/Source/WebKit/ChangeLog 2021-08-07 01:39:53 UTC (rev 280751)
@@ -1,3 +1,17 @@
+2021-08-06 Tim Horton <[email protected]>
+
+ REGRESSION (r185111): Links to App Store doesn't work when opening a PDF in Safari on iOS and iPadOS
+ https://bugs.webkit.org/show_bug.cgi?id=228881
+ rdar://81294035
+
+ Reviewed by Andy Estes.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):
+ Clicking a link in PDF should absolutely be allowed to launch an external app.
+ Humorously, r185111 applied the correct value to PDFPlugin (macOS), but the
+ wrong value to WKPDFView (iOS). Bring them into alignment.
+
2021-08-06 Fujii Hironori <[email protected]>
ASSERTION FAILED: !m_networkLoad in NetworkResourceLoader::~NetworkResourceLoader()
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (280750 => 280751)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2021-08-07 01:33:03 UTC (rev 280750)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2021-08-07 01:39:53 UTC (rev 280751)
@@ -1802,7 +1802,7 @@
auto mouseEvent = MouseEvent::create(eventNames().clickEvent, Event::CanBubble::Yes, Event::IsCancelable::Yes, Event::IsComposed::Yes,
MonotonicTime::now(), nullptr, singleClick, screenPoint, documentPoint, { }, { }, 0, 0, nullptr, 0, WebCore::NoTap);
- mainFrame->loader().changeLocation(mainFrameDocument->completeURL(url), emptyString(), mouseEvent.ptr(), ReferrerPolicy::NoReferrer, ShouldOpenExternalURLsPolicy::ShouldNotAllow);
+ mainFrame->loader().changeLocation(mainFrameDocument->completeURL(url), emptyString(), mouseEvent.ptr(), ReferrerPolicy::NoReferrer, ShouldOpenExternalURLsPolicy::ShouldAllow);
}
void WebPage::stopLoadingFrame(FrameIdentifier frameID)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
