Title: [280764] trunk/Source/WebCore
- Revision
- 280764
- Author
- [email protected]
- Date
- 2021-08-07 21:18:00 -0700 (Sat, 07 Aug 2021)
Log Message
UBSan: KeyboardScrollingAnimator.cpp:303:10: runtime error: load of value nnn, which is not a valid value for type 'bool'
<https://webkit.org/b/228901>
Reviewed by Tim Horton.
Covered by running 78 layout tests with UBSan enabled.
* platform/KeyboardScrollingAnimator.h:
- Initialize m_scrollTriggeringKeyIsPressed to false.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (280763 => 280764)
--- trunk/Source/WebCore/ChangeLog 2021-08-08 01:20:45 UTC (rev 280763)
+++ trunk/Source/WebCore/ChangeLog 2021-08-08 04:18:00 UTC (rev 280764)
@@ -1,3 +1,15 @@
+2021-08-07 David Kilzer <[email protected]>
+
+ UBSan: KeyboardScrollingAnimator.cpp:303:10: runtime error: load of value nnn, which is not a valid value for type 'bool'
+ <https://webkit.org/b/228901>
+
+ Reviewed by Tim Horton.
+
+ Covered by running 78 layout tests with UBSan enabled.
+
+ * platform/KeyboardScrollingAnimator.h:
+ - Initialize m_scrollTriggeringKeyIsPressed to false.
+
2021-08-07 Wenson Hsieh <[email protected]>
[macOS] Web process crashes when detaching Document with uncommitted marked text
Modified: trunk/Source/WebCore/platform/KeyboardScrollingAnimator.h (280763 => 280764)
--- trunk/Source/WebCore/platform/KeyboardScrollingAnimator.h 2021-08-08 01:20:45 UTC (rev 280763)
+++ trunk/Source/WebCore/platform/KeyboardScrollingAnimator.h 2021-08-08 04:18:00 UTC (rev 280764)
@@ -51,7 +51,7 @@
ScrollAnimator& m_scrollAnimator;
ScrollController& m_scrollController;
std::optional<WebCore::KeyboardScroll> m_currentKeyboardScroll;
- bool m_scrollTriggeringKeyIsPressed;
+ bool m_scrollTriggeringKeyIsPressed { false };
FloatSize m_velocity;
MonotonicTime m_timeAtLastFrame;
FloatPoint m_idealPositionForMinimumTravel;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
