Title: [280884] trunk/Source/WebKitLegacy/mac
Revision
280884
Author
[email protected]
Date
2021-08-10 23:10:27 -0700 (Tue, 10 Aug 2021)

Log Message

REGRESSION (r280726): [ Big Sur wk1 ] 25 imported/w3c/web-platform-tests/fetch/ failing
https://bugs.webkit.org/show_bug.cgi?id=228926

Reviewed by Jer Noble.

Revert a part of r280726 while investigating the test failures.

* WebView/WebPreferencesDefaultValues.mm:
(WebKit::isFeatureFlagEnabled):

Modified Paths

Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (280883 => 280884)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2021-08-11 05:28:15 UTC (rev 280883)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2021-08-11 06:10:27 UTC (rev 280884)
@@ -1,3 +1,15 @@
+2021-08-10  Peng Liu  <[email protected]>
+
+        REGRESSION (r280726): [ Big Sur wk1 ] 25 imported/w3c/web-platform-tests/fetch/ failing
+        https://bugs.webkit.org/show_bug.cgi?id=228926
+
+        Reviewed by Jer Noble.
+
+        Revert a part of r280726 while investigating the test failures.
+
+        * WebView/WebPreferencesDefaultValues.mm:
+        (WebKit::isFeatureFlagEnabled):
+
 2021-08-10  Chris Dumez  <[email protected]>
 
         Add Cross-Origin-Opener-Policy support for Blob URLs

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm (280883 => 280884)


--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm	2021-08-11 05:28:15 UTC (rev 280883)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm	2021-08-11 06:10:27 UTC (rev 280884)
@@ -49,17 +49,9 @@
 {
 #if HAVE(SYSTEM_FEATURE_FLAGS)
 
-#if PLATFORM(MAC)
-    static bool isSystemWebKit = [] {
-        NSBundle *bundle = [NSBundle bundleForClass:NSClassFromString(@"WebView")];
-        return [bundle.bundlePath hasPrefix:@"/System/"];
-    }();
-
-    if (isSystemWebKit)
-        return _os_feature_enabled_impl("WebKit", (const char*)featureName.characters8());
-
-    return defaultValue;
-#else
+    // FIXME: On MacOS, we need to deal with the cases when system feature flags are not available.
+    // But we need to fix <http://webkit.org/b/228926> first.
+#if PLATFORM(COCOA)
     UNUSED_PARAM(defaultValue);
     return _os_feature_enabled_impl("WebKit", (const char*)featureName.characters8());
 #endif // PLATFORM(MAC)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to