Title: [280902] releases/WebKitGTK/webkit-2.32/Source/WebCore
- Revision
- 280902
- Author
- [email protected]
- Date
- 2021-08-11 03:50:31 -0700 (Wed, 11 Aug 2021)
Log Message
Merge r274824 - [Web Animations] nullptr crash in updatePlaybackRate() with no timeline
https://bugs.webkit.org/show_bug.cgi?id=223095
Patch by Ian Gilbert <[email protected]> on 2021-03-22
Reviewed by Ryosuke Niwa.
Changed to WebAnimation::remove() to use setTimeline() instead of setTimelineInternal()
to ensure the animation is in the correct play state.
No new tests as this relies on navigating while updating the playback rate and I was unable to make
a reliable test case.
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::remove): Changed setTimelineInternal() to setTimeline() in order to
ensure the animation has the correct play state.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog (280901 => 280902)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog 2021-08-11 10:43:19 UTC (rev 280901)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog 2021-08-11 10:50:31 UTC (rev 280902)
@@ -1,3 +1,20 @@
+2021-03-22 Ian Gilbert <[email protected]>
+
+ [Web Animations] nullptr crash in updatePlaybackRate() with no timeline
+ https://bugs.webkit.org/show_bug.cgi?id=223095
+
+ Reviewed by Ryosuke Niwa.
+
+ Changed to WebAnimation::remove() to use setTimeline() instead of setTimelineInternal()
+ to ensure the animation is in the correct play state.
+
+ No new tests as this relies on navigating while updating the playback rate and I was unable to make
+ a reliable test case.
+
+ * animation/WebAnimation.cpp:
+ (WebCore::WebAnimation::remove): Changed setTimelineInternal() to setTimeline() in order to
+ ensure the animation has the correct play state.
+
2021-03-22 Patrick Angle <[email protected]>
REGRESSION(r272433): Inspector should not instrument inside `WebCore::Node::setRenderer`
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/animation/WebAnimation.cpp (280901 => 280902)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/animation/WebAnimation.cpp 2021-08-11 10:43:19 UTC (rev 280901)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/animation/WebAnimation.cpp 2021-08-11 10:50:31 UTC (rev 280902)
@@ -120,7 +120,7 @@
// This object could be deleted after either clearing the effect or timeline relationship.
auto protectedThis = makeRef(*this);
setEffectInternal(nullptr);
- setTimelineInternal(nullptr);
+ setTimeline(nullptr);
}
void WebAnimation::suspendEffectInvalidation()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
