Title: [280964] trunk/Source/WebKit
- Revision
- 280964
- Author
- [email protected]
- Date
- 2021-08-12 06:51:16 -0700 (Thu, 12 Aug 2021)
Log Message
[ATK] Critical warnings on children-changed::add signal emission
https://bugs.webkit.org/show_bug.cgi?id=229030
Reviewed by Michael Catanzaro.
Implement AtkObjectClass::ref_state_set.
* WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp:
(webkitWebPageAccessibilityObjectRefStateSet): Return our child state set.
(webkit_web_page_accessibility_object_class_init): Add an implementation for AtkObjectClass::ref_state_set.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (280963 => 280964)
--- trunk/Source/WebKit/ChangeLog 2021-08-12 13:35:06 UTC (rev 280963)
+++ trunk/Source/WebKit/ChangeLog 2021-08-12 13:51:16 UTC (rev 280964)
@@ -1,3 +1,16 @@
+2021-08-12 Carlos Garcia Campos <[email protected]>
+
+ [ATK] Critical warnings on children-changed::add signal emission
+ https://bugs.webkit.org/show_bug.cgi?id=229030
+
+ Reviewed by Michael Catanzaro.
+
+ Implement AtkObjectClass::ref_state_set.
+
+ * WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp:
+ (webkitWebPageAccessibilityObjectRefStateSet): Return our child state set.
+ (webkit_web_page_accessibility_object_class_init): Add an implementation for AtkObjectClass::ref_state_set.
+
2021-08-11 Peng Liu <[email protected]>
Function _os_feature_enabled_impl() expects compile-time static strings as arguments
Modified: trunk/Source/WebKit/WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp (280963 => 280964)
--- trunk/Source/WebKit/WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp 2021-08-12 13:35:06 UTC (rev 280963)
+++ trunk/Source/WebKit/WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp 2021-08-12 13:51:16 UTC (rev 280964)
@@ -139,6 +139,14 @@
return nullptr;
}
+static AtkStateSet* webkitWebPageAccessibilityObjectRefStateSet(AtkObject* atkObject)
+{
+ if (auto* rootObjectWrapper = accessibilityRootObjectWrapper(atkObject))
+ return atk_object_ref_state_set(rootObjectWrapper);
+
+ return atk_state_set_new();
+}
+
static void webkit_web_page_accessibility_object_class_init(WebKitWebPageAccessibilityObjectClass* klass)
{
AtkObjectClass* atkObjectClass = ATK_OBJECT_CLASS(klass);
@@ -149,6 +157,7 @@
atkObjectClass->get_index_in_parent = webkitWebPageAccessibilityObjectGetIndexInParent;
atkObjectClass->get_n_children = webkitWebPageAccessibilityObjectGetNChildren;
atkObjectClass->ref_child = webkitWebPageAccessibilityObjectRefChild;
+ atkObjectClass->ref_state_set = webkitWebPageAccessibilityObjectRefStateSet;
}
AtkObject* webkitWebPageAccessibilityObjectNew(WebPage* page)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
