Title: [280992] trunk/Tools
- Revision
- 280992
- Author
- [email protected]
- Date
- 2021-08-12 16:26:58 -0700 (Thu, 12 Aug 2021)
Log Message
REGRESSION (iPadOS 14): [ iPadOS wk2 ] TestWebKitAPI.ServiceWorkers.SuspendNetworkProcess is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217714
<rdar://problem/70296664>
Reviewed by Geoffrey Garen.
Give the database some time to get written out to disk before we try and suspend the network process, to try
and address the flakiness.
* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (280991 => 280992)
--- trunk/Tools/ChangeLog 2021-08-12 23:17:22 UTC (rev 280991)
+++ trunk/Tools/ChangeLog 2021-08-12 23:26:58 UTC (rev 280992)
@@ -1,3 +1,16 @@
+2021-08-12 Chris Dumez <[email protected]>
+
+ REGRESSION (iPadOS 14): [ iPadOS wk2 ] TestWebKitAPI.ServiceWorkers.SuspendNetworkProcess is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=217714
+ <rdar://problem/70296664>
+
+ Reviewed by Geoffrey Garen.
+
+ Give the database some time to get written out to disk before we try and suspend the network process, to try
+ and address the flakiness.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+
2021-08-12 Wenson Hsieh <[email protected]>
[ iOS Debug] 3 editing/pasteboard/smart-paste-paragraph tests are flaky failing
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm (280991 => 280992)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm 2021-08-12 23:17:22 UTC (rev 280991)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm 2021-08-12 23:26:58 UTC (rev 280992)
@@ -1945,6 +1945,10 @@
NSURL* directory = [NSURL fileURLWithPath:path isDirectory:YES];
NSURL *swDBPath = [directory URLByAppendingPathComponent:@"ServiceWorkerRegistrations-7.sqlite3"];
+ unsigned timeout = 0;
+ while (![[NSFileManager defaultManager] fileExistsAtPath:swDBPath.path] && ++timeout < 100)
+ TestWebKitAPI::Util::sleep(0.1);
+
EXPECT_TRUE([[NSFileManager defaultManager] fileExistsAtPath:swDBPath.path]);
[webView.get().configuration.websiteDataStore _sendNetworkProcessWillSuspendImminently];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
