Title: [280999] trunk/Source/WebKitLegacy/mac
- Revision
- 280999
- Author
- [email protected]
- Date
- 2021-08-12 17:08:04 -0700 (Thu, 12 Aug 2021)
Log Message
Regression(r273194) Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased
https://bugs.webkit.org/show_bug.cgi?id=229056
Reviewed by Geoffrey Garen.
Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased. I got this wrong
in r273194.
* Misc/WebNSObjectExtras.mm:
(-[WebMainThreadInvoker forwardInvocation:]):
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (280998 => 280999)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2021-08-13 00:04:20 UTC (rev 280998)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2021-08-13 00:08:04 UTC (rev 280999)
@@ -1,3 +1,16 @@
+2021-08-12 Chris Dumez <[email protected]>
+
+ Regression(r273194) Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased
+ https://bugs.webkit.org/show_bug.cgi?id=229056
+
+ Reviewed by Geoffrey Garen.
+
+ Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased. I got this wrong
+ in r273194.
+
+ * Misc/WebNSObjectExtras.mm:
+ (-[WebMainThreadInvoker forwardInvocation:]):
+
2021-08-12 Youenn Fablet <[email protected]>
REGRESSION (r280726): [ Big Sur wk1 ] 25 imported/w3c/web-platform-tests/fetch/ failing
Modified: trunk/Source/WebKitLegacy/mac/Misc/WebNSObjectExtras.mm (280998 => 280999)
--- trunk/Source/WebKitLegacy/mac/Misc/WebNSObjectExtras.mm 2021-08-13 00:04:20 UTC (rev 280998)
+++ trunk/Source/WebKitLegacy/mac/Misc/WebNSObjectExtras.mm 2021-08-13 00:08:04 UTC (rev 280999)
@@ -63,7 +63,7 @@
[invocation performSelectorOnMainThread:@selector(_webkit_invokeAndHandleException:) withObject:self waitUntilDone:YES];
if (exception) {
auto exceptionToThrow = std::exchange(exception, nil);
- @throw exceptionToThrow.get();
+ @throw exceptionToThrow.autorelease();
} else if (returnTypeIsObject(invocation)) {
// _webkit_invokeAndHandleException retained the return value on the main thread.
// Now autorelease it on the calling thread.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
