Diff
Modified: trunk/LayoutTests/ChangeLog (281009 => 281010)
--- trunk/LayoutTests/ChangeLog 2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/LayoutTests/ChangeLog 2021-08-13 08:40:04 UTC (rev 281010)
@@ -1,3 +1,21 @@
+2021-08-13 Martin Robinson <[email protected]>
+
+ Get lint-test-expectations passing
+ https://bugs.webkit.org/show_bug.cgi?id=228999
+
+ Reviewed by Ryan Haddad.
+
+ * TestExpectations: Remove expectation for non-existent test.
+ * platform/ios-simulator/TestExpectations: Ditto.
+ * platform/ios-wk2/TestExpectations: Ditto.
+ * platform/ios/TestExpectations: Dito.
+ * platform/mac-wk1/TestExpectations: Ditto. Also, the expectations for the non-test
+ 'boot.xml' and 'root.xml' have been moved to workarounds in webkitpy.
+ * platform/mac/TestExpectations: Remove references to non-existent tests. Also combined
+ one expectation that was not linting due to a problem like the one described in bug
+ 120081.
+ * platform/win/TestExpectations: Ditto.
+
2021-08-12 Alex Christensen <[email protected]>
Unprefix -webkit-backface-visibility
Modified: trunk/LayoutTests/TestExpectations (281009 => 281010)
--- trunk/LayoutTests/TestExpectations 2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/LayoutTests/TestExpectations 2021-08-13 08:40:04 UTC (rev 281010)
@@ -1137,7 +1137,6 @@
imported/w3c/web-platform-tests/resource-timing/cors-preflight.any.html [ Failure Pass ]
imported/w3c/web-platform-tests/resource-timing/crossorigin-sandwich-TAO.sub.html [ Pass Failure ]
imported/w3c/web-platform-tests/resource-timing/crossorigin-sandwich-partial-TAO.sub.html [ Pass Failure ]
-imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html [ Pass Failure ]
imported/w3c/web-platform-tests/navigation-timing/secure_connection_start_non_zero.https.html [ Pass Failure ]
imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html [ Pass Failure ]
imported/w3c/web-platform-tests/resource-timing/TAO-match.html [ Pass Failure ]
Modified: trunk/LayoutTests/platform/ios/TestExpectations (281009 => 281010)
--- trunk/LayoutTests/platform/ios/TestExpectations 2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2021-08-13 08:40:04 UTC (rev 281010)
@@ -2646,8 +2646,6 @@
webkit.org/b/155092 js/arraybuffer-wrappers.html [ Pass Timeout ]
-webkit.org/b/172052 [ Release ] imported/w3c/web-platform-tests/html/webappapis/timers/type-long-setinterval.html [ Pass Failure ]
-
webkit.org/b/183441 mathml/presentation/multiscripts-equivalence.html [ ImageOnlyFailure ]
# <rdar://problem/32632415> REGRESSION (ImageIO-1666): LayoutTests fast/images are failing together.
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (281009 => 281010)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2021-08-13 08:40:04 UTC (rev 281010)
@@ -114,11 +114,8 @@
webkit.org/b/222685 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view.html [ Pass Failure ]
webkit.org/b/222685 webgl/1.0.3/conformance/textures/texture-mips.html [ Pass Failure ]
-# WebGPU is not enabled on iOS Simulator.
-webgpu [ Skip ]
-
# webkit.org/b/223724 These two tests are flakey timeouts on iOS Debug:
http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html [ Pass Timeout ]
http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html [ Pass Timeout ]
-webkit.org/b/223949 crypto/crypto-random-values-oom.html [ Pass Timeout ]
\ No newline at end of file
+webkit.org/b/223949 crypto/crypto-random-values-oom.html [ Pass Timeout ]
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (281009 => 281010)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-08-13 08:40:04 UTC (rev 281010)
@@ -1216,8 +1216,6 @@
webkit.org/b/171331 http/tests/preload/single_download_preload.html [ Pass Failure ]
-webkit.org/b/170699 [ Release ] imported/w3c/web-platform-tests/html/webappapis/timers/negative-settimeout.html [ Pass Failure ]
-
webkit.org/b/171638 [ Release ] http/tests/xmlhttprequest/methods.html [ Pass Timeout ]
webkit.org/b/171830 [ Debug ] http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]
@@ -1290,8 +1288,6 @@
webkit.org/b/176030 http/tests/websocket/tests/hybi/send-object-tostring-check.html [ Pass Failure ]
-webkit.org/b/199013 [ Debug ] imported/w3c/web-platform-tests/websockets/Create-Secure-verify-url-set-non-default-port.any.html [ Pass Failure ]
-
webkit.org/b/196495 fast/viewport/ios/viewport-shrink-to-fit-on-new-navigation.html [ Failure ]
webkit.org/b/199071 [ Release ] imported/blink/fast/css/user-select-none.html [ Pass ImageOnlyFailure ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (281009 => 281010)
--- trunk/LayoutTests/platform/mac/TestExpectations 2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2021-08-13 08:40:04 UTC (rev 281010)
@@ -2112,7 +2112,6 @@
# webkit.org/b/223043 the following tests have issues only on Apple Silicon
[ arm64 ] webrtc/concurrentVideoPlayback2.html [ Pass Timeout ]
[ arm64 ] webrtc/concurrentVideoPlayback.html [ Pass Timeout ]
-[ arm64 ] webrtc/direction-change.html [ Pass Timeout ]
[ arm64 ] webrtc/multi-video.html [ Pass Timeout ]
[ arm64 ] webrtc/h265.html [ Pass Timeout ]
[ arm64 ] webrtc/video-setDirection.html [ Pass Timeout ]
@@ -2216,7 +2215,9 @@
webkit.org/b/225425 [ Debug ] webgl/1.0.3/conformance/glsl/misc/_expression_-list-in-declarator-initializer.html [ Pass Timeout ]
-webkit.org/b/225523 webrtc/direction-change.html [ Pass Failure ]
+# This test is a flaky timeout on Apple Silicon and a flaky failure on other platforms.
+# See https://webkit.org/b/120081 for why this is one expectation.
+webkit.org/b/225523 webrtc/direction-change.html [ Pass Timeout Failure ]
webkit.org/b/22525 webrtc/video-replace-muted-track.html [ Pass Failure ]
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (281009 => 281010)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-08-13 08:40:04 UTC (rev 281010)
@@ -129,7 +129,6 @@
webkit.org/b/156069 http/tests/download/anchor-download-attribute-content-disposition-no-extension-text-plain.html [ Skip ]
webkit.org/b/156069 http/tests/security/anchor-download-octet-stream-no-extension.html [ Skip ]
webkit.org/b/156069 http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html [ Skip ]
-http/tests/security/frame-src-and-blob-download.https.html [ Skip ]
# Not supported on WK1
media/no-fullscreen-when-hidden.html [ Skip ]
@@ -1182,9 +1181,6 @@
webkit.org/b/221009 fast/harness/render-tree-as-text-options.html [ Pass Failure ]
-webkit.org/b/208477 [ Catalina ] accessibility/mac/test.mp3/boot.xml [ Skip ]
-webkit.org/b/208479 [ Catalina ] accessibility/mac/test.mp3/root.xml [ Skip ]
-
webkit.org/b/221095 [ BigSur+ ] media/mediacapabilities/vp9.html [ Skip ]
webkit.org/b/221146 [ BigSur ] imported/w3c/web-platform-tests/media-source/mediasource-invalid-codec.html [ Failure ]
Modified: trunk/LayoutTests/platform/win/TestExpectations (281009 => 281010)
--- trunk/LayoutTests/platform/win/TestExpectations 2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/LayoutTests/platform/win/TestExpectations 2021-08-13 08:40:04 UTC (rev 281010)
@@ -108,7 +108,6 @@
webkit.org/b/173281 editing/selection/selection-across-shadow-boundaries-readonly-2.html [ Skip ]
webkit.org/b/173281 editing/selection/selection-across-shadow-boundaries-readonly-3.html [ Skip ]
webkit.org/b/173281 editing/selection/selection-across-shadow-boundaries-user-select-all-1.html [ Skip ]
-webkit.org/b/193748 http/tests/adClickAttribution [ Skip ]
http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html [ Skip ]
# TODO HW filters not yet supported on Windows
@@ -225,7 +224,6 @@
webkit.org/b/29287 http/tests/local/fileapi/ [ Skip ]
webkit.org/b/29287 http/tests/local/blob/send-hybrid-blob.html [ Skip ]
webkit.org/b/29287 http/tests/local/formdata/ [ Skip ]
-http/tests/security/frame-src-and-blob-download.https.html [ Skip ]
# Software keyboard is not supported.
fast/events/autoscroll-with-software-keyboard.html [ Skip ]
@@ -420,11 +418,7 @@
webkit.org/b/42435 http/tests/misc/webtiming-cross-origin-and-back1.html [ Skip ]
webkit.org/b/42435 http/tests/misc/webtiming-cross-origin-redirect.py [ Skip ]
webkit.org/b/42435 http/tests/misc/webtiming-no-origin.html [ Skip ]
-webkit.org/b/42435 http/tests/misc/webtiming-one-redirect.php [ Skip ]
webkit.org/b/42435 http/tests/misc/webtiming-resolution.html [ Skip ]
-webkit.org/b/42435 http/tests/misc/webtiming-slow-load.php [ Skip ]
-webkit.org/b/42435 http/tests/misc/webtiming-ssl.php [ Skip ]
-webkit.org/b/42435 http/tests/misc/webtiming-two-redirects.php [ Skip ]
# TODO Application Cache Quotas
webkit.org/b/43458 http/tests/appcache/origin-quota.html [ Skip ]
@@ -2130,7 +2124,6 @@
webkit.org/b/140703 [ Debug ] http/tests/loading/basic-credentials-sent-automatically.html [ Skip ] # Debug Assertion
webkit.org/b/140703 [ Release ] http/tests/loading/redirect-methods.html [ Failure ]
webkit.org/b/140703 [ Debug ] http/tests/loading/redirect-methods.html [ Skip ] # Debug assertion
-webkit.org/b/140703 http/tests/misc/401-alternative-content.php [ Failure ]
webkit.org/b/140703 http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html [ Failure ]
webkit.org/b/140703 http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html [ Failure ]
webkit.org/b/140703 http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html [ Failure ]
@@ -2291,7 +2284,6 @@
http/tests/misc/acid3.html [ Failure ]
http/tests/misc/async-script-removed.html [ Failure ]
http/tests/misc/bad-charset-alias.html
-http/tests/misc/refresh-headers.php [ Failure ] # Easy
http/tests/multipart/load-last-non-html-frame.py [ Failure ] # Extra whitespace
http/tests/navigation/no-referrer-reset.html [ Failure ] # Easy
http/tests/navigation/no-referrer-same-window.html [ Failure ] # Easy
Modified: trunk/Tools/ChangeLog (281009 => 281010)
--- trunk/Tools/ChangeLog 2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/Tools/ChangeLog 2021-08-13 08:40:04 UTC (rev 281010)
@@ -1,3 +1,17 @@
+2021-08-13 Martin Robinson <[email protected]>
+
+ Get lint-test-expectations passing
+ https://bugs.webkit.org/show_bug.cgi?id=228999
+
+ Reviewed by Ryan Haddad.
+
+ * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
+ (LayoutTestFinder._is_test_file): Added a list of patterns for tests to skip
+ and ensured that 'boot.xml' and 'root.xml' (spurious files created during
+ the run of the WebKit1 bot) are on the list.
+ * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
+ (LayoutTestFinderTests.test_is_test_file): Added a test for the changes.
+
2021-08-12 Lauro Moura <[email protected]>
[WPE] Gardening web-process-crashed API test failure
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py (281009 => 281010)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py 2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py 2021-08-13 08:40:04 UTC (rev 281010)
@@ -42,7 +42,17 @@
# When collecting test cases, we include any file with these extensions.
_supported_test_extensions = set(['.html', '.shtml', '.xml', '.xhtml', '.pl', '.py', '.htm', '.php', '.svg', '.mht', '.xht'])
+_skipped_filename_patterns = set([
+ # Special case for WebSocket tooling.
+ r'.*_wsh.py',
+ # The WebKit1 bot sometimes creates these files during the course of testing.
+ # https://webkit.org/b/208477
+ r'boot\.xml',
+ r'root\.xml'
+])
+
+
# If any changes are made here be sure to update the isUsedInReftest method in old-run-webkit-tests as well.
def _is_reference_html_file(filesystem, dirname, filename):
if filename.startswith('ref-') or filename.startswith('notref-'):
@@ -135,9 +145,10 @@
return False
if self._is_w3c_resource_file(filesystem, dirname, filename):
return False
- # Special case for websocket tooling
- if filename.endswith('_wsh.py'):
- return False
+
+ for pattern in _skipped_filename_patterns:
+ if re.match(pattern, filename):
+ return False
return True
def _is_w3c_resource_file(self, filesystem, dirname, filename):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py (281009 => 281010)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py 2021-08-13 06:46:31 UTC (rev 281009)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py 2021-08-13 08:40:04 UTC (rev 281010)
@@ -105,6 +105,12 @@
self.assertFalse(finder._is_test_file(finder._filesystem, '', 'foo-ref.xhtml'))
self.assertFalse(finder._is_test_file(finder._filesystem, '', 'ref-foo.html'))
self.assertFalse(finder._is_test_file(finder._filesystem, '', 'notref-foo.xhr'))
+ self.assertFalse(finder._is_test_file(finder._filesystem, '', 'foo_wsh.py'))
+ self.assertFalse(finder._is_test_file(finder._filesystem, '', '_wsh.py'))
+ self.assertFalse(finder._is_test_file(finder._filesystem, '', 'boot.xml'))
+ self.assertFalse(finder._is_test_file(finder._filesystem, '', 'root.xml'))
+ self.assertTrue(finder._is_test_file(finder._filesystem, '', 'foo-boot.xml'))
+ self.assertTrue(finder._is_test_file(finder._filesystem, '', 'foo-root.xml'))
def test_is_w3c_resource_file(self):
finder = self.make_finder()
