Title: [281129] trunk/Tools
- Revision
- 281129
- Author
- [email protected]
- Date
- 2021-08-16 23:43:39 -0700 (Mon, 16 Aug 2021)
Log Message
REGRESSION(r281079) [GLIB] API test WebKitWebsiteData/deviceidhashsalt is not waiting for title change
https://bugs.webkit.org/show_bug.cgi?id=229174
Reviewed by Carlos Garcia Campos.
r281079 changed the helper method waitUntilTitleChangedTo to
immediately return if the current title is already the expected one.
While this is working fine in other tests, the deviceidhashsalt tries
to load the same page twice. As the title does not change, the call
returns right away, before the expected side effects of the load
happen.
This commit adds a dummy "about:blank" call between both original
calls to make sure we track the title change correctly.
* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataDeviceIdHashSalt):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (281128 => 281129)
--- trunk/Tools/ChangeLog 2021-08-17 05:34:02 UTC (rev 281128)
+++ trunk/Tools/ChangeLog 2021-08-17 06:43:39 UTC (rev 281129)
@@ -1,3 +1,24 @@
+2021-08-16 Lauro Moura <[email protected]>
+
+ REGRESSION(r281079) [GLIB] API test WebKitWebsiteData/deviceidhashsalt is not waiting for title change
+ https://bugs.webkit.org/show_bug.cgi?id=229174
+
+ Reviewed by Carlos Garcia Campos.
+
+ r281079 changed the helper method waitUntilTitleChangedTo to
+ immediately return if the current title is already the expected one.
+
+ While this is working fine in other tests, the deviceidhashsalt tries
+ to load the same page twice. As the title does not change, the call
+ returns right away, before the expected side effects of the load
+ happen.
+
+ This commit adds a dummy "about:blank" call between both original
+ calls to make sure we track the title change correctly.
+
+ * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
+ (testWebsiteDataDeviceIdHashSalt):
+
2021-08-16 Andres Gonzalez <[email protected]>
Expose [WebAccessibilityObjectWrapper lineRectsAndText] on MacOS.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp (281128 => 281129)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp 2021-08-17 05:34:02 UTC (rev 281128)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp 2021-08-17 06:43:39 UTC (rev 281129)
@@ -661,6 +661,9 @@
dataList = test->fetch(WEBKIT_WEBSITE_DATA_DEVICE_ID_HASH_SALT);
g_assert_null(dataList);
+ test->loadURI("about:blank");
+ test->waitUntilTitleChanged();
+
// Test removing the cookies.
test->loadURI(kServer->getURIForPath("/enumeratedevices").data());
test->waitUntilTitleChangedTo("Finished");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
