Title: [281139] trunk/Source/WebInspectorUI
- Revision
- 281139
- Author
- [email protected]
- Date
- 2021-08-17 09:01:58 -0700 (Tue, 17 Aug 2021)
Log Message
Web Inspector: Do not show contextual documentation popup in the Changes panel
https://bugs.webkit.org/show_bug.cgi?id=229001
<rdar://problem/81792379>
Reviewed by Devin Rousso.
Add config option to WI.SpreadsheetStyleProperty to prevent showing a contextual documentation button.
* UserInterface/Views/ChangesDetailsSidebarPanel.js:
(WI.ChangesDetailsSidebarPanel.prototype._createRuleElement.onEach):
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._addContextualDocumentationButton):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (281138 => 281139)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-08-17 15:42:39 UTC (rev 281138)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-08-17 16:01:58 UTC (rev 281139)
@@ -1,3 +1,18 @@
+2021-08-17 Razvan Caliman <[email protected]>
+
+ Web Inspector: Do not show contextual documentation popup in the Changes panel
+ https://bugs.webkit.org/show_bug.cgi?id=229001
+ <rdar://problem/81792379>
+
+ Reviewed by Devin Rousso.
+
+ Add config option to WI.SpreadsheetStyleProperty to prevent showing a contextual documentation button.
+
+ * UserInterface/Views/ChangesDetailsSidebarPanel.js:
+ (WI.ChangesDetailsSidebarPanel.prototype._createRuleElement.onEach):
+ * UserInterface/Views/SpreadsheetStyleProperty.js:
+ (WI.SpreadsheetStyleProperty.prototype._addContextualDocumentationButton):
+
2021-08-12 Patrick Angle <[email protected]>
Web Inspector: Adding execution contexts after page load doesn't show a hidden execution selector
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js (281138 => 281139)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js 2021-08-17 15:42:39 UTC (rev 281138)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js 2021-08-17 16:01:58 UTC (rev 281139)
@@ -143,7 +143,7 @@
propertyLineElement.classList.add("css-property-line", className);
const delegate = null;
- let stylePropertyView = new WI.SpreadsheetStyleProperty(delegate, cssProperty, {readOnly: true});
+ let stylePropertyView = new WI.SpreadsheetStyleProperty(delegate, cssProperty, {readOnly: true, hideDocumentation: true});
propertyLineElement.append(WI.indentString(), stylePropertyView.element, "\n");
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js (281138 => 281139)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2021-08-17 15:42:39 UTC (rev 281138)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2021-08-17 16:01:58 UTC (rev 281139)
@@ -34,6 +34,7 @@
this._delegate = delegate || null;
this._property = property;
this._readOnly = options.readOnly || false;
+ this._hideDocumentation = !!options.hideDocumentation;
this._element = document.createElement("div");
if (options.selectable)
@@ -527,6 +528,9 @@
_addContextualDocumentationButton()
{
+ if (this._hideDocumentation)
+ return;
+
if (this._contextualDocumentationButton) {
this._contextualDocumentationButton.remove();
this._contextualDocumentationButton = null;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
