Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (281214 => 281215)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-08-18 23:14:15 UTC (rev 281215)
@@ -1,5 +1,17 @@
2021-08-18 Chris Dumez <[email protected]>
+ Unreviewed, reverting r281206.
+
+ Reverting because of branching, will re-land soon
+
+ Reverted changeset:
+
+ "Implement Crypto.randomUUID()"
+ https://bugs.webkit.org/show_bug.cgi?id=229240
+ https://commits.webkit.org/r281206
+
+2021-08-18 Chris Dumez <[email protected]>
+
Implement Crypto.randomUUID()
https://bugs.webkit.org/show_bug.cgi?id=229240
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt (281214 => 281215)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt 2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt 2021-08-18 23:14:15 UTC (rev 281215)
@@ -1,5 +1,5 @@
-PASS namespace format
-PASS version set
-PASS variant set
+FAIL namespace format self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
+FAIL version set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
+FAIL variant set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt (281214 => 281215)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt 2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt 2021-08-18 23:14:15 UTC (rev 281215)
@@ -1,5 +1,5 @@
-PASS namespace format
-PASS version set
-PASS variant set
+FAIL namespace format self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
+FAIL version set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
+FAIL variant set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
Modified: trunk/Source/WebCore/ChangeLog (281214 => 281215)
--- trunk/Source/WebCore/ChangeLog 2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/Source/WebCore/ChangeLog 2021-08-18 23:14:15 UTC (rev 281215)
@@ -1,5 +1,17 @@
2021-08-18 Chris Dumez <[email protected]>
+ Unreviewed, reverting r281206.
+
+ Reverting because of branching, will re-land soon
+
+ Reverted changeset:
+
+ "Implement Crypto.randomUUID()"
+ https://bugs.webkit.org/show_bug.cgi?id=229240
+ https://commits.webkit.org/r281206
+
+2021-08-18 Chris Dumez <[email protected]>
+
Implement Crypto.randomUUID()
https://bugs.webkit.org/show_bug.cgi?id=229240
Modified: trunk/Source/WebCore/page/Crypto.cpp (281214 => 281215)
--- trunk/Source/WebCore/page/Crypto.cpp 2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/Source/WebCore/page/Crypto.cpp 2021-08-18 23:14:15 UTC (rev 281215)
@@ -35,7 +35,6 @@
#include "SubtleCrypto.h"
#include <_javascript_Core/ArrayBufferView.h>
#include <wtf/CryptographicallyRandomNumber.h>
-#include <wtf/UUID.h>
#if OS(DARWIN)
#include <CommonCrypto/CommonCryptor.h>
@@ -69,11 +68,6 @@
return { };
}
-String Crypto::randomUUID() const
-{
- return createCanonicalUUIDString();
-}
-
#if ENABLE(WEB_CRYPTO)
SubtleCrypto& Crypto::subtle()
Modified: trunk/Source/WebCore/page/Crypto.h (281214 => 281215)
--- trunk/Source/WebCore/page/Crypto.h 2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/Source/WebCore/page/Crypto.h 2021-08-18 23:14:15 UTC (rev 281215)
@@ -46,7 +46,6 @@
virtual ~Crypto();
ExceptionOr<void> getRandomValues(JSC::ArrayBufferView&);
- String randomUUID() const;
#if ENABLE(WEB_CRYPTO)
SubtleCrypto& subtle();
Modified: trunk/Source/WebCore/page/Crypto.idl (281214 => 281215)
--- trunk/Source/WebCore/page/Crypto.idl 2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/Source/WebCore/page/Crypto.idl 2021-08-18 23:14:15 UTC (rev 281215)
@@ -33,5 +33,4 @@
] interface Crypto {
[Conditional=WEB_CRYPTO, SecureContext] readonly attribute SubtleCrypto subtle;
ArrayBufferView getRandomValues([ReturnValue] ArrayBufferView array);
- [SecureContext] DOMString randomUUID();
};
