Diff
Modified: trunk/Source/WebCore/ChangeLog (281226 => 281227)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 08:40:05 UTC (rev 281227)
@@ -1,5 +1,50 @@
2021-08-19 Youenn Fablet <[email protected]>
+ Rename MediaPlayer::setVisible to MediaPlayer::setPageIsVisible
+ https://bugs.webkit.org/show_bug.cgi?id=228837
+ <rdar://problem/81857023>
+
+ Reviewed by Eric Carlson.
+
+ No change of behavior, just renaming a method to make its name more accurate.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::visibilityStateChanged):
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::loadWithNextMediaEngine):
+ (WebCore::MediaPlayer::setPageIsVisible):
+ (WebCore::MediaPlayer::setVisible): Deleted.
+ * platform/graphics/MediaPlayer.h:
+ * platform/graphics/MediaPlayerPrivate.h:
+ (WebCore::MediaPlayerPrivateInterface::setVisibleForCanvas):
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+ (WebCore::MediaPlayerPrivateAVFoundation::setPageIsVisible):
+ (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Deleted.
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setPageIsVisible):
+ (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVisible): Deleted.
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setPageIsVisible):
+ (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVisible): Deleted.
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
+ * platform/graphics/holepunch/MediaPlayerPrivateHolePunch.h:
+ * platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
+ (WebCore::MediaPlayerPrivateMediaFoundation::setPageIsVisible):
+ (WebCore::MediaPlayerPrivateMediaFoundation::setVisible): Deleted.
+ * platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
+ * platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
+ (WebCore::MockMediaPlayerMediaSource::setPageIsVisible):
+ (WebCore::MockMediaPlayerMediaSource::setVisible): Deleted.
+ * platform/mock/mediasource/MockMediaPlayerMediaSource.h:
+ * rendering/RenderVideo.cpp:
+ (WebCore::RenderVideo::willBeDestroyed):
+ (WebCore::RenderVideo::updatePlayer):
+
+2021-08-19 Youenn Fablet <[email protected]>
+
RTCRtpTransceiver does not need an ice transport
https://bugs.webkit.org/show_bug.cgi?id=229186
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (281226 => 281227)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2021-08-19 08:40:05 UTC (rev 281227)
@@ -5835,7 +5835,7 @@
updateSleepDisabling();
mediaSession().visibilityChanged();
if (m_player)
- m_player->setVisible(!m_elementIsHidden);
+ m_player->setPageIsVisible(!m_elementIsHidden);
}
bool HTMLMediaElement::requiresTextTrackRepresentation() const
@@ -6743,7 +6743,7 @@
m_player->setBufferingPolicy(m_bufferingPolicy);
m_player->setPreferredDynamicRangeMode(m_overrideDynamicRangeMode.value_or(preferredDynamicRangeMode(document().view())));
m_player->setMuted(effectiveMuted());
- m_player->setVisible(!m_elementIsHidden);
+ m_player->setPageIsVisible(!m_elementIsHidden);
m_player->setVisibleInViewport(isVisibleInViewport());
schedulePlaybackControlsManagerUpdate();
Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2021-08-19 08:40:05 UTC (rev 281227)
@@ -117,7 +117,7 @@
bool hasVideo() const final { return false; }
bool hasAudio() const final { return false; }
- void setVisible(bool) final { }
+ void setPageIsVisible(bool) final { }
double durationDouble() const final { return 0; }
@@ -573,8 +573,8 @@
m_private = engine->createMediaEnginePlayer(this);
if (m_private) {
client().mediaPlayerEngineUpdated();
- if (m_visible)
- m_private->setVisible(m_visible);
+ if (m_pageIsVisible)
+ m_private->setPageIsVisible(m_pageIsVisible);
if (m_visibleInViewport)
m_private->setVisibleInViewport(m_visibleInViewport);
m_private->prepareForPlayback(m_privateBrowsing, m_preload, m_preservesPitch, m_shouldPrepareToRender);
@@ -1002,10 +1002,10 @@
m_private->setSize(size);
}
-void MediaPlayer::setVisible(bool visible)
+void MediaPlayer::setPageIsVisible(bool visible)
{
- m_visible = visible;
- m_private->setVisible(visible);
+ m_pageIsVisible = visible;
+ m_private->setPageIsVisible(visible);
}
void MediaPlayer::setVisibleForCanvas(bool visible)
Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.h (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/MediaPlayer.h 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.h 2021-08-19 08:40:05 UTC (rev 281227)
@@ -357,7 +357,7 @@
#endif
void cancelLoad();
- void setVisible(bool);
+ void setPageIsVisible(bool);
void setVisibleForCanvas(bool);
void setVisibleInViewport(bool);
@@ -701,7 +701,7 @@
IntSize m_size;
Preload m_preload { Preload::Auto };
double m_volume { 1 };
- bool m_visible { false };
+ bool m_pageIsVisible { false };
bool m_visibleInViewport { false };
bool m_muted { false };
bool m_preservesPitch { true };
Modified: trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h 2021-08-19 08:40:05 UTC (rev 281227)
@@ -96,8 +96,8 @@
virtual bool hasVideo() const = 0;
virtual bool hasAudio() const = 0;
- virtual void setVisible(bool) = 0;
- virtual void setVisibleForCanvas(bool visible) { setVisible(visible); }
+ virtual void setPageIsVisible(bool) = 0;
+ virtual void setVisibleForCanvas(bool visible) { setPageIsVisible(visible); }
virtual void setVisibleInViewport(bool) { }
virtual float duration() const { return 0; }
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2021-08-19 08:40:05 UTC (rev 281227)
@@ -580,7 +580,7 @@
setReadyState(newReadyState);
}
-void MediaPlayerPrivateAVFoundation::setVisible(bool visible)
+void MediaPlayerPrivateAVFoundation::setPageIsVisible(bool visible)
{
if (m_visible == visible)
return;
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h 2021-08-19 08:40:05 UTC (rev 281227)
@@ -175,7 +175,7 @@
FloatSize naturalSize() const override;
bool hasVideo() const override { return m_cachedHasVideo; }
bool hasAudio() const override { return m_cachedHasAudio; }
- void setVisible(bool) override;
+ void setPageIsVisible(bool) final;
MediaTime durationMediaTime() const override;
MediaTime currentMediaTime() const override = 0;
void seek(const MediaTime&) override;
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h 2021-08-19 08:40:05 UTC (rev 281227)
@@ -195,7 +195,7 @@
bool hasVideo() const override;
bool hasAudio() const override;
- void setVisible(bool) override;
+ void setPageIsVisible(bool) final;
MediaTime durationMediaTime() const override;
MediaTime startTime() const override;
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2021-08-19 08:40:05 UTC (rev 281227)
@@ -425,7 +425,7 @@
return m_mediaSourcePrivate->hasAudio();
}
-void MediaPlayerPrivateMediaSourceAVFObjC::setVisible(bool visible)
+void MediaPlayerPrivateMediaSourceAVFObjC::setPageIsVisible(bool visible)
{
if (m_visible == visible)
return;
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h 2021-08-19 08:40:05 UTC (rev 281227)
@@ -120,7 +120,7 @@
bool hasVideo() const override;
bool hasAudio() const override;
- void setVisible(bool) final;
+ void setPageIsVisible(bool) final;
void setVisibleForCanvas(bool) final;
void setVisibleInViewport(bool) final;
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2021-08-19 08:40:05 UTC (rev 281227)
@@ -616,7 +616,7 @@
return !m_audioTrackMap.isEmpty();
}
-void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool isVisible)
+void MediaPlayerPrivateMediaStreamAVFObjC::setPageIsVisible(bool isVisible)
{
if (m_isPageVisible == isVisible)
return;
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h 2021-08-19 08:40:05 UTC (rev 281227)
@@ -156,7 +156,7 @@
void setMuted(bool) final;
MediaPlayer::NetworkState networkState() const final;
MediaPlayer::ReadyState readyState() const final;
- void setVisible(bool visible) final { m_visible = visible; }
+ void setPageIsVisible(bool visible) final { m_visible = visible; }
void setSize(const IntSize&) final;
// Prefer MediaTime based methods over float based.
float duration() const final { return durationMediaTime().toFloat(); }
Modified: trunk/Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.h (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.h 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.h 2021-08-19 08:40:05 UTC (rev 281227)
@@ -70,7 +70,7 @@
bool hasVideo() const final { return false; };
bool hasAudio() const final { return false; };
- void setVisible(bool) final { };
+ void setPageIsVisible(bool) final { };
bool seeking() const final { return false; }
Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp 2021-08-19 08:40:05 UTC (rev 281227)
@@ -204,7 +204,7 @@
return m_hasAudio;
}
-void MediaPlayerPrivateMediaFoundation::setVisible(bool visible)
+void MediaPlayerPrivateMediaFoundation::setPageIsVisible(bool visible)
{
m_visible = visible;
}
Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h (281226 => 281227)
--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h 2021-08-19 08:40:05 UTC (rev 281227)
@@ -70,7 +70,7 @@
bool hasVideo() const final;
bool hasAudio() const final;
- void setVisible(bool) final;
+ void setPageIsVisible(bool) final;
bool seeking() const final;
void seek(float) final;
Modified: trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp (281226 => 281227)
--- trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp 2021-08-19 08:40:05 UTC (rev 281227)
@@ -150,7 +150,7 @@
return m_mediaSourcePrivate ? m_mediaSourcePrivate->hasAudio() : false;
}
-void MockMediaPlayerMediaSource::setVisible(bool)
+void MockMediaPlayerMediaSource::setPageIsVisible(bool)
{
}
Modified: trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h (281226 => 281227)
--- trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h 2021-08-19 08:40:05 UTC (rev 281227)
@@ -77,7 +77,7 @@
FloatSize naturalSize() const override;
bool hasVideo() const override;
bool hasAudio() const override;
- void setVisible(bool) override;
+ void setPageIsVisible(bool) final;
bool seeking() const override;
bool paused() const override;
MediaPlayer::NetworkState networkState() const override;
Modified: trunk/Source/WebCore/rendering/RenderVideo.cpp (281226 => 281227)
--- trunk/Source/WebCore/rendering/RenderVideo.cpp 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebCore/rendering/RenderVideo.cpp 2021-08-19 08:40:05 UTC (rev 281227)
@@ -69,10 +69,10 @@
#if ENABLE(VIDEO_PRESENTATION_MODE)
auto player = videoElement().player();
if (player && videoElement().webkitPresentationMode() != HTMLVideoElement::VideoPresentationMode::PictureInPicture)
- player->setVisible(false);
+ player->setPageIsVisible(false);
#else
if (auto player = videoElement().player())
- player->setVisible(false);
+ player->setPageIsVisible(false);
#endif
RenderMedia::willBeDestroyed();
@@ -273,7 +273,7 @@
return;
if (!videoElement().inActiveDocument()) {
- mediaPlayer->setVisible(false);
+ mediaPlayer->setPageIsVisible(false);
return;
}
@@ -281,7 +281,7 @@
IntRect videoBounds = videoBox();
mediaPlayer->setSize(IntSize(videoBounds.width(), videoBounds.height()));
- mediaPlayer->setVisible(!videoElement().elementIsHidden());
+ mediaPlayer->setPageIsVisible(!videoElement().elementIsHidden());
mediaPlayer->setVisibleInViewport(videoElement().isVisibleInViewport());
mediaPlayer->setShouldMaintainAspectRatio(style().objectFit() != ObjectFit::Fill);
}
Modified: trunk/Source/WebKit/ChangeLog (281226 => 281227)
--- trunk/Source/WebKit/ChangeLog 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebKit/ChangeLog 2021-08-19 08:40:05 UTC (rev 281227)
@@ -1,3 +1,21 @@
+2021-08-19 Youenn Fablet <[email protected]>
+
+ Rename MediaPlayer::setVisible to MediaPlayer::setPageIsVisible
+ https://bugs.webkit.org/show_bug.cgi?id=228837
+ <rdar://problem/81857023>
+
+ Reviewed by Eric Carlson.
+
+ * GPUProcess/media/RemoteMediaPlayerProxy.cpp:
+ (WebKit::RemoteMediaPlayerProxy::setPageIsVisible):
+ (WebKit::RemoteMediaPlayerProxy::setVisible): Deleted.
+ * GPUProcess/media/RemoteMediaPlayerProxy.h:
+ * GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
+ * WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
+ (WebKit::MediaPlayerPrivateRemote::setPageIsVisible):
+ (WebKit::MediaPlayerPrivateRemote::setVisible): Deleted.
+ * WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
+
2021-08-18 David Kilzer <[email protected]>
Bug 229265: run-webkit-tests --leaks should check for leaks in the GPU process
Modified: trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp (281226 => 281227)
--- trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp 2021-08-19 08:40:05 UTC (rev 281227)
@@ -236,9 +236,9 @@
m_player->prepareForRendering();
}
-void RemoteMediaPlayerProxy::setVisible(bool visible)
+void RemoteMediaPlayerProxy::setPageIsVisible(bool visible)
{
- m_player->setVisible(visible);
+ m_player->setPageIsVisible(visible);
}
void RemoteMediaPlayerProxy::setShouldMaintainAspectRatio(bool maintainRatio)
Modified: trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h (281226 => 281227)
--- trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h 2021-08-19 08:40:05 UTC (rev 281227)
@@ -143,7 +143,7 @@
void setPreservesPitch(bool);
void setPitchCorrectionAlgorithm(WebCore::MediaPlayer::PitchCorrectionAlgorithm);
- void setVisible(bool);
+ void setPageIsVisible(bool);
void setShouldMaintainAspectRatio(bool);
#if ENABLE(VIDEO_PRESENTATION_MODE)
void setVideoFullscreenGravity(WebCore::MediaPlayerEnums::VideoGravity);
Modified: trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in (281226 => 281227)
--- trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in 2021-08-19 08:40:05 UTC (rev 281227)
@@ -49,7 +49,7 @@
SetPitchCorrectionAlgorithm(WebCore::MediaPlayer::PitchCorrectionAlgorithm algorithm)
PrepareForRendering()
- SetVisible(bool visible)
+ SetPageIsVisible(bool visible)
SetShouldMaintainAspectRatio(bool maintainAspectRatio)
AcceleratedRenderingStateChanged(bool canBeAccelerated)
SetShouldDisableSleep(bool disable)
Modified: trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp (281226 => 281227)
--- trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp 2021-08-19 08:40:05 UTC (rev 281227)
@@ -532,9 +532,9 @@
connection().send(Messages::RemoteMediaPlayerProxy::PrepareForRendering(), m_id);
}
-void MediaPlayerPrivateRemote::setVisible(bool visible)
+void MediaPlayerPrivateRemote::setPageIsVisible(bool visible)
{
- connection().send(Messages::RemoteMediaPlayerProxy::SetVisible(visible), m_id);
+ connection().send(Messages::RemoteMediaPlayerProxy::SetPageIsVisible(visible), m_id);
}
void MediaPlayerPrivateRemote::setShouldMaintainAspectRatio(bool maintainRatio)
Modified: trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h (281226 => 281227)
--- trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h 2021-08-19 08:40:05 UTC (rev 281227)
@@ -243,7 +243,7 @@
bool hasVideo() const final;
bool hasAudio() const final;
- void setVisible(bool) final;
+ void setPageIsVisible(bool) final;
MediaTime durationMediaTime() const final;
MediaTime currentMediaTime() const final;
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (281226 => 281227)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2021-08-19 08:40:05 UTC (rev 281227)
@@ -1,3 +1,14 @@
+2021-08-19 Youenn Fablet <[email protected]>
+
+ Rename MediaPlayer::setVisible to MediaPlayer::setPageIsVisible
+ https://bugs.webkit.org/show_bug.cgi?id=228837
+ <rdar://problem/81857023>
+
+ Reviewed by Eric Carlson.
+
+ * FullscreenVideoController.cpp:
+ (FullscreenVideoController::exitFullscreen):
+
2021-08-13 Chris Dumez <[email protected]>
Add Cross-Origin-Embedder-Policy support for Blob URLs
Modified: trunk/Source/WebKitLegacy/win/FullscreenVideoController.cpp (281226 => 281227)
--- trunk/Source/WebKitLegacy/win/FullscreenVideoController.cpp 2021-08-19 08:22:22 UTC (rev 281226)
+++ trunk/Source/WebKitLegacy/win/FullscreenVideoController.cpp 2021-08-19 08:40:05 UTC (rev 281227)
@@ -326,8 +326,8 @@
// As a side effect of setting the player to invisible/visible,
// the player's layer will be recreated, and will be picked up
// the next time the layer tree is synched.
- m_videoElement->player()->setVisible(0);
- m_videoElement->player()->setVisible(1);
+ m_videoElement->player()->setPageIsVisible(0);
+ m_videoElement->player()->setPageIsVisible(1);
}
bool FullscreenVideoController::canPlay() const
