Title: [281285] trunk/Source/WebCore
Revision
281285
Author
[email protected]
Date
2021-08-19 17:37:14 -0700 (Thu, 19 Aug 2021)

Log Message

[LFC][IFC] Remove redundant inlineBoxEndSet in InlineFormattingContext::computeGeometryForLineContent
https://bugs.webkit.org/show_bug.cgi?id=228054

Reviewed by Antti Koivisto.

It's not used anymore.

* layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (281284 => 281285)


--- trunk/Source/WebCore/ChangeLog	2021-08-20 00:12:09 UTC (rev 281284)
+++ trunk/Source/WebCore/ChangeLog	2021-08-20 00:37:14 UTC (rev 281285)
@@ -1,3 +1,15 @@
+2021-08-19  Alan Bujtas  <[email protected]>
+
+        [LFC][IFC] Remove redundant inlineBoxEndSet in InlineFormattingContext::computeGeometryForLineContent
+        https://bugs.webkit.org/show_bug.cgi?id=228054
+
+        Reviewed by Antti Koivisto.
+
+        It's not used anymore.
+
+        * layout/formattingContexts/inline/InlineFormattingContext.cpp:
+        (WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
+
 2021-08-19  Chris Dumez  <[email protected]>
 
         Implement Crypto.randomUUID()

Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp (281284 => 281285)


--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp	2021-08-20 00:12:09 UTC (rev 281284)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp	2021-08-20 00:37:14 UTC (rev 281285)
@@ -502,7 +502,6 @@
     auto rootInlineBoxLogicalRect = lineBox.logicalRectForRootInlineBox();
     auto enclosingTopAndBottom = InlineLineGeometry::EnclosingTopAndBottom { rootInlineBoxLogicalRect.top(), rootInlineBoxLogicalRect.bottom() };
     HashSet<const Box*> inlineBoxStartSet;
-    HashSet<const Box*> inlineBoxEndSet;
 
     auto constructLineRunsAndUpdateBoxGeometry = [&] {
         // Create the inline runs on the current line. This is mostly text and atomic inline runs.
@@ -556,7 +555,6 @@
                 continue;
             }
             if (lineRun.isInlineBoxEnd()) {
-                inlineBoxEndSet.add(&layoutBox);
                 if (!inlineBoxStartSet.contains(&layoutBox)) {
                     // An inline box can span multiple lines. Use the [inline box end] signal to include it in the enclosing geometry
                     // only when it starts at a previous line.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to