Title: [281289] trunk/Source/WebKit
- Revision
- 281289
- Author
- [email protected]
- Date
- 2021-08-19 19:35:35 -0700 (Thu, 19 Aug 2021)
Log Message
Fix the apple internal build after r281277
https://bugs.webkit.org/show_bug.cgi?id=229100
<rdar://problem/82145920>
Reviewed by Myles C. Maxfield.
Update code guarded by `USE(APPLE_INTERNAL_SDK)`, such that it works with a `Vector<SandboxExtension::Handle>`.
Preserve the existing behavior of appending `handles` and `ids` in reverse order, but leave a FIXME questioning
the need for this.
* UIProcess/UserMediaProcessManager.cpp:
(WebKit::UserMediaProcessManager::willCreateMediaStream):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (281288 => 281289)
--- trunk/Source/WebKit/ChangeLog 2021-08-20 01:41:03 UTC (rev 281288)
+++ trunk/Source/WebKit/ChangeLog 2021-08-20 02:35:35 UTC (rev 281289)
@@ -1,5 +1,20 @@
2021-08-19 Wenson Hsieh <[email protected]>
+ Fix the apple internal build after r281277
+ https://bugs.webkit.org/show_bug.cgi?id=229100
+ <rdar://problem/82145920>
+
+ Reviewed by Myles C. Maxfield.
+
+ Update code guarded by `USE(APPLE_INTERNAL_SDK)`, such that it works with a `Vector<SandboxExtension::Handle>`.
+ Preserve the existing behavior of appending `handles` and `ids` in reverse order, but leave a FIXME questioning
+ the need for this.
+
+ * UIProcess/UserMediaProcessManager.cpp:
+ (WebKit::UserMediaProcessManager::willCreateMediaStream):
+
+2021-08-19 Wenson Hsieh <[email protected]>
+
[iOS] Remove support for the meaningful tap heuristic
https://bugs.webkit.org/show_bug.cgi?id=229298
rdar://82130066
Modified: trunk/Source/WebKit/UIProcess/UserMediaProcessManager.cpp (281288 => 281289)
--- trunk/Source/WebKit/UIProcess/UserMediaProcessManager.cpp 2021-08-20 01:41:03 UTC (rev 281288)
+++ trunk/Source/WebKit/UIProcess/UserMediaProcessManager.cpp 2021-08-20 02:35:35 UTC (rev 281289)
@@ -97,7 +97,7 @@
Vector<String> ids;
if (!proxy.page().preferences().mockCaptureDevicesEnabled()) {
- handles.allocate(extensionCount);
+ handles.resize(extensionCount);
ids.reserveInitialCapacity(extensionCount);
if (needsAudioSandboxExtension) {
@@ -131,6 +131,8 @@
WTFLogAlways("Could not create a required sandbox extension, capture will fail!");
return false;
}
+
+ // FIXME: Is it correct to ensure that the corresponding entries in `handles` and `ids` are in reverse order?
}
for (const auto& id : ids)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
