Title: [281318] trunk/Source/WTF
- Revision
- 281318
- Author
- [email protected]
- Date
- 2021-08-20 08:56:05 -0700 (Fri, 20 Aug 2021)
Log Message
Make ptrTagName and tagForPtr WTF_EXPORT_PRIVATE.
https://bugs.webkit.org/show_bug.cgi?id=229328
Reviewed by Yusuke Suzuki.
If ptrTagName and tagForPtr are defined, make them WTF_EXPORT_PRIVATE instead of
static functions. This allows us to call them from the debugger during
interactive debugging sessions.
* wtf/PtrTag.cpp:
(WTF::tagForPtr):
(WTF::ptrTagName):
* wtf/PtrTag.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (281317 => 281318)
--- trunk/Source/WTF/ChangeLog 2021-08-20 15:53:13 UTC (rev 281317)
+++ trunk/Source/WTF/ChangeLog 2021-08-20 15:56:05 UTC (rev 281318)
@@ -1,5 +1,21 @@
2021-08-20 Mark Lam <[email protected]>
+ Make ptrTagName and tagForPtr WTF_EXPORT_PRIVATE.
+ https://bugs.webkit.org/show_bug.cgi?id=229328
+
+ Reviewed by Yusuke Suzuki.
+
+ If ptrTagName and tagForPtr are defined, make them WTF_EXPORT_PRIVATE instead of
+ static functions. This allows us to call them from the debugger during
+ interactive debugging sessions.
+
+ * wtf/PtrTag.cpp:
+ (WTF::tagForPtr):
+ (WTF::ptrTagName):
+ * wtf/PtrTag.h:
+
+2021-08-20 Mark Lam <[email protected]>
+
Remove assertIsTagged and assertIsNullOrTagged.
https://bugs.webkit.org/show_bug.cgi?id=229329
rdar://82162851
Modified: trunk/Source/WTF/wtf/PtrTag.cpp (281317 => 281318)
--- trunk/Source/WTF/wtf/PtrTag.cpp 2021-08-20 15:53:13 UTC (rev 281317)
+++ trunk/Source/WTF/wtf/PtrTag.cpp 2021-08-20 15:56:05 UTC (rev 281318)
@@ -32,7 +32,7 @@
#if CPU(ARM64E) && ENABLE(PTRTAG_DEBUGGING)
-static const char* tagForPtr(const void* ptr)
+const char* tagForPtr(const void* ptr)
{
PtrTagLookup* lookup = g_wtfConfig.ptrTagLookupHead;
while (lookup) {
@@ -54,7 +54,7 @@
return "<unknown PtrTag>";
}
-static const char* ptrTagName(PtrTag tag)
+const char* ptrTagName(PtrTag tag)
{
PtrTagLookup* lookup = g_wtfConfig.ptrTagLookupHead;
while (lookup) {
Modified: trunk/Source/WTF/wtf/PtrTag.h (281317 => 281318)
--- trunk/Source/WTF/wtf/PtrTag.h 2021-08-20 15:53:13 UTC (rev 281317)
+++ trunk/Source/WTF/wtf/PtrTag.h 2021-08-20 15:56:05 UTC (rev 281318)
@@ -157,6 +157,10 @@
WTF_EXPORT_PRIVATE void reportBadTag(const void*, PtrTag expectedTag);
#if ENABLE(PTRTAG_DEBUGGING)
+
+WTF_EXPORT_PRIVATE const char* ptrTagName(PtrTag);
+WTF_EXPORT_PRIVATE const char* tagForPtr(const void*);
+
constexpr bool enablePtrTagDebugAssert = true;
#define REPORT_BAD_TAG(success, ptr, expectedTag) do { \
if (UNLIKELY(!success)) \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
