Title: [281330] trunk/Source/WebCore
Revision
281330
Author
[email protected]
Date
2021-08-20 12:38:50 -0700 (Fri, 20 Aug 2021)

Log Message

[macOS] Crash when painting <meter> with large scale
https://bugs.webkit.org/show_bug.cgi?id=229273
rdar://81219669

Reviewed by Wenson Hsieh.

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMeter):

Draw the cell into an image buffer to avoid an assertion beneath WebKit.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (281329 => 281330)


--- trunk/Source/WebCore/ChangeLog	2021-08-20 19:28:02 UTC (rev 281329)
+++ trunk/Source/WebCore/ChangeLog	2021-08-20 19:38:50 UTC (rev 281330)
@@ -1,3 +1,16 @@
+2021-08-20  Aditya Keerthi  <[email protected]>
+
+        [macOS] Crash when painting <meter> with large scale
+        https://bugs.webkit.org/show_bug.cgi?id=229273
+        rdar://81219669
+
+        Reviewed by Wenson Hsieh.
+
+        * rendering/RenderThemeMac.mm:
+        (WebCore::RenderThemeMac::paintMeter):
+
+        Draw the cell into an image buffer to avoid an assertion beneath WebKit.
+
 2021-08-20  Patrick Angle  <[email protected]>
 
         Release assert in ScriptController::canExecuteScripts via WebCore::WebSocket::didReceiveMessage

Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (281329 => 281330)


--- trunk/Source/WebCore/rendering/RenderThemeMac.mm	2021-08-20 19:28:02 UTC (rev 281329)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm	2021-08-20 19:38:50 UTC (rev 281330)
@@ -1174,7 +1174,7 @@
     NSLevelIndicatorCell* cell = levelIndicatorFor(downcast<RenderMeter>(renderObject));
     GraphicsContextStateSaver stateSaver(paintInfo.context());
 
-    [cell drawWithFrame:rect inView:documentViewFor(renderObject)];
+    paintCellAndSetFocusedElementNeedsRepaintIfNecessary(cell, renderObject, paintInfo, rect);
     [cell setControlView:nil];
     return false;
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to