Log Message
fast/events/ios/key-events-comprehensive/key-events-meta-shift.html is failing in iOS 15 https://bugs.webkit.org/show_bug.cgi?id=229417 rdar://80385777
Reviewed by Tim Horton. This test is failing in iOS 15 because "command + shift + /" now triggers a system-wide key command that shows a help menu; this key command is handled very early on in UIKit, before keyboard code gets a chance to handle the event as a WebEvent and dispatch it to the page. rdar://82257764 tracks making this key command preventable by marking it as a key command that should be handled after dispatching key events. For the time being, add this to the list of system key commands that we should avoid in `key-tester.js`, and rebaseline the test. * fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt: * fast/events/ios/resources/key-tester.js: * platform/ios-14/TestExpectations: * platform/ios/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (281476 => 281477)
--- trunk/LayoutTests/ChangeLog 2021-08-23 22:40:11 UTC (rev 281476)
+++ trunk/LayoutTests/ChangeLog 2021-08-23 22:52:37 UTC (rev 281477)
@@ -1,3 +1,24 @@
+2021-08-23 Wenson Hsieh <wenson_hs...@apple.com>
+
+ fast/events/ios/key-events-comprehensive/key-events-meta-shift.html is failing in iOS 15
+ https://bugs.webkit.org/show_bug.cgi?id=229417
+ rdar://80385777
+
+ Reviewed by Tim Horton.
+
+ This test is failing in iOS 15 because "command + shift + /" now triggers a system-wide key command that shows
+ a help menu; this key command is handled very early on in UIKit, before keyboard code gets a chance to handle
+ the event as a WebEvent and dispatch it to the page.
+
+ rdar://82257764 tracks making this key command preventable by marking it as a key command that should be handled
+ after dispatching key events. For the time being, add this to the list of system key commands that we should
+ avoid in `key-tester.js`, and rebaseline the test.
+
+ * fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt:
+ * fast/events/ios/resources/key-tester.js:
+ * platform/ios-14/TestExpectations:
+ * platform/ios/TestExpectations:
+
2021-08-23 Eric Hutchison <ehutchi...@apple.com>
[BigSur wk2 Debug] http/tests/inspector/network/fetch-network-data.html is a flaky failure.
Modified: trunk/LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt (281476 => 281477)
--- trunk/LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt 2021-08-23 22:40:11 UTC (rev 281476)
+++ trunk/LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt 2021-08-23 22:52:37 UTC (rev 281477)
@@ -320,11 +320,3 @@
type: keyup, key: Shift, code: ShiftLeft, keyIdentifier: Shift, keyCode: 16, charCode: 0, keyCode: 16, which: 16, altKey: false, ctrlKey: false, metaKey: true, shiftKey: false, location: 1, keyLocation: 1
type: keyup, key: Meta, code: MetaLeft, keyIdentifier: Meta, keyCode: 91, charCode: 0, keyCode: 91, which: 91, altKey: false, ctrlKey: false, metaKey: false, shiftKey: false, location: 1, keyLocation: 1
-Test Command + Shift + /:
-type: keydown, key: Meta, code: MetaLeft, keyIdentifier: Meta, keyCode: 91, charCode: 0, keyCode: 91, which: 91, altKey: false, ctrlKey: false, metaKey: true, shiftKey: false, location: 1, keyLocation: 1
-type: keydown, key: Shift, code: ShiftLeft, keyIdentifier: Shift, keyCode: 16, charCode: 0, keyCode: 16, which: 16, altKey: false, ctrlKey: false, metaKey: true, shiftKey: true, location: 1, keyLocation: 1
-type: keydown, key: /, code: Slash, keyIdentifier: U+003F, keyCode: 191, charCode: 0, keyCode: 191, which: 191, altKey: false, ctrlKey: false, metaKey: true, shiftKey: true, location: 0, keyLocation: 0
-type: keypress, key: /, code: Slash, keyIdentifier: , keyCode: 47, charCode: 47, keyCode: 47, which: 47, altKey: false, ctrlKey: false, metaKey: true, shiftKey: true, location: 0, keyLocation: 0
-type: keyup, key: Shift, code: ShiftLeft, keyIdentifier: Shift, keyCode: 16, charCode: 0, keyCode: 16, which: 16, altKey: false, ctrlKey: false, metaKey: true, shiftKey: false, location: 1, keyLocation: 1
-type: keyup, key: Meta, code: MetaLeft, keyIdentifier: Meta, keyCode: 91, charCode: 0, keyCode: 91, which: 91, altKey: false, ctrlKey: false, metaKey: false, shiftKey: false, location: 1, keyLocation: 1
-
Modified: trunk/LayoutTests/fast/events/ios/resources/key-tester.js (281476 => 281477)
--- trunk/LayoutTests/fast/events/ios/resources/key-tester.js 2021-08-23 22:40:11 UTC (rev 281476)
+++ trunk/LayoutTests/fast/events/ios/resources/key-tester.js 2021-08-23 22:52:37 UTC (rev 281477)
@@ -78,6 +78,9 @@
// FIXME: Command + A cannot be prevented from keypress. See <https://bugs.webkit.org/show_bug.cgi?id=199475>.
new KeyCommand("a", ["metaKey"]),
+
+ // FIXME: Command + shift + / cannot be prevented. See <rdar://82257764>.
+ new KeyCommand("/", ["metaKey", "shiftKey"]),
];
for (let i = 1; i <= 9; ++i)
disallowedKeyCommands.push(new KeyCommand(i, ["metaKey"]));
Modified: trunk/LayoutTests/platform/ios/TestExpectations (281476 => 281477)
--- trunk/LayoutTests/platform/ios/TestExpectations 2021-08-23 22:40:11 UTC (rev 281476)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2021-08-23 22:52:37 UTC (rev 281477)
@@ -3401,10 +3401,6 @@
# rdar://80392337 ([ iOS15 ] fast/text/international/system-language/navigator-language/navigator-language-ru.html is a constant failure)
fast/text/international/system-language/navigator-language/navigator-language-ru.html [ Failure ]
-#Batch adding of test expectations group 4:
-# rdar://80385777 ([ iOS15 ] fast/events/ios/key-events-comprehensive/key-events-meta-shift.html is failing)
-fast/events/ios/key-events-comprehensive/key-events-meta-shift.html [ Failure ]
-
# rdar://80386075 ([ iOS15 ] fast/css/ios/system-color-for-css-value.html)
fast/css/ios/system-color-for-css-value.html [ Failure ]
Modified: trunk/LayoutTests/platform/ios-14/TestExpectations (281476 => 281477)
--- trunk/LayoutTests/platform/ios-14/TestExpectations 2021-08-23 22:40:11 UTC (rev 281476)
+++ trunk/LayoutTests/platform/ios-14/TestExpectations 2021-08-23 22:52:37 UTC (rev 281477)
@@ -59,10 +59,6 @@
# rdar://80392337 ([ iOS15 ] fast/text/international/system-language/navigator-language/navigator-language-ru.html is a constant failure)
fast/text/international/system-language/navigator-language/navigator-language-ru.html [ Pass ]
-#Batch adding of test expectations group 4:
-# rdar://80385777 ([ iOS15 ] fast/events/ios/key-events-comprehensive/key-events-meta-shift.html is failing)
-fast/events/ios/key-events-comprehensive/key-events-meta-shift.html [ Pass ]
-
# rdar://80386075 ([ iOS15 ] fast/css/ios/system-color-for-css-value.html)
fast/css/ios/system-color-for-css-value.html [ Pass ]
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
