Title: [281524] trunk/LayoutTests
Revision
281524
Author
[email protected]
Date
2021-08-24 16:12:08 -0700 (Tue, 24 Aug 2021)

Log Message

REGRESSION (r276598): [ iOS ] fast/forms/ios/accessory-bar-navigation.html is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=229471
rdar://80390931

Reviewed by Wenson Hsieh.

* fast/forms/ios/accessory-bar-navigation.html:

r276598 updated this test so that the second input is positioned out of
the viewport on larger devices. However, the change (increasing the margin)
also lead to the first input being positioned out of the viewport on
smaller devices. Consequently, the test times out when run on an iPhone SE
as it is unable to tap on the first input.

To fix, the original margin for the first input is restored, ensuring it is
positioned within the viewport, and can be tapped. Then, a separate margin
is applied to the second input, ensuring it remains positioned outside the
viewport, and the test can verify accessory bar navigation with an
element outside the viewport.

* platform/ios-wk2/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (281523 => 281524)


--- trunk/LayoutTests/ChangeLog	2021-08-24 23:04:18 UTC (rev 281523)
+++ trunk/LayoutTests/ChangeLog	2021-08-24 23:12:08 UTC (rev 281524)
@@ -1,3 +1,27 @@
+2021-08-24  Aditya Keerthi  <[email protected]>
+
+        REGRESSION (r276598): [ iOS ] fast/forms/ios/accessory-bar-navigation.html is a constant timeout
+        https://bugs.webkit.org/show_bug.cgi?id=229471
+        rdar://80390931
+
+        Reviewed by Wenson Hsieh.
+
+        * fast/forms/ios/accessory-bar-navigation.html:
+
+        r276598 updated this test so that the second input is positioned out of
+        the viewport on larger devices. However, the change (increasing the margin)
+        also lead to the first input being positioned out of the viewport on
+        smaller devices. Consequently, the test times out when run on an iPhone SE
+        as it is unable to tap on the first input.
+
+        To fix, the original margin for the first input is restored, ensuring it is
+        positioned within the viewport, and can be tapped. Then, a separate margin
+        is applied to the second input, ensuring it remains positioned outside the
+        viewport, and the test can verify accessory bar navigation with an
+        element outside the viewport.
+
+        * platform/ios-wk2/TestExpectations:
+
 2021-08-24  Eric Hutchison  <[email protected]>
 
         REGRESSION (r281182?): 4 Media tests flakily timing out.

Modified: trunk/LayoutTests/fast/forms/ios/accessory-bar-navigation.html (281523 => 281524)


--- trunk/LayoutTests/fast/forms/ios/accessory-bar-navigation.html	2021-08-24 23:04:18 UTC (rev 281523)
+++ trunk/LayoutTests/fast/forms/ios/accessory-bar-navigation.html	2021-08-24 23:12:08 UTC (rev 281524)
@@ -6,8 +6,11 @@
     <style>
         input[type="text"] {
             display: block;
-            margin: 800px 20px;
+            margin: 400px 20px;
         }
+        #input2 {
+            margin-top: 800px;
+        }
         button {
             display: block;
         }

Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (281523 => 281524)


--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-24 23:04:18 UTC (rev 281523)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-08-24 23:12:08 UTC (rev 281524)
@@ -2019,8 +2019,6 @@
 
 #rdar://80391927 ([ iOS ] fast/forms/ios/ipad/open-picker-using-keyboard.html is a flaky timeout) fast/forms/ios/ipad/open-picker-using-keyboard.html [ Pass Timeout ]
 
-#rdar://80390931 (REGRESSION (r271861): [ iOS ] fast/forms/ios/accessory-bar-navigation.html is a constant timeout) fast/forms/ios/accessory-bar-navigation.html [ Timeout ] 
-
 webkit.org/b/168961 fast/events/wheelevent-in-frame.html [ Pass Timeout ]
 
 webkit.org/b/168961 fast/events/touch/page-scaled-touch-gesture-click.html [ Timeout ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to