[webkit-changes] [281607] trunk/Source/JavaScriptCore

[ysuzuki]

Title: [281607] trunk/Source/_javascript_Core

Revision

281607

Author

ysuz...@apple.com

Date

2021-08-25 17:43:13 -0700 (Wed, 25 Aug 2021)

Log Message

REGRESSION(r281513?): [ JSC Catalina+ Debug ] 16 stress/intl-enumeration.js (JSC Tests) are flaky failing
https://bugs.webkit.org/show_bug.cgi?id=229526

Reviewed by Mark Lam.

Fix debug JSC test failures by using RELEASE_AND_RETURN.

* runtime/IntlObject.cpp:
(JSC::availableCalendars):
(JSC::availableCollations):
(JSC::availableCurrencies):
(JSC::availableNumberingSystems):
(JSC::availableTimeZones):

Modified Paths

• trunk/Source/_javascript_Core/ChangeLog
• trunk/Source/_javascript_Core/runtime/IntlObject.cpp

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (281606 => 281607)

--- trunk/Source/_javascript_Core/ChangeLog	2021-08-26 00:39:38 UTC (rev 281606)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-08-26 00:43:13 UTC (rev 281607)
@@ -1,3 +1,19 @@
+2021-08-25  Yusuke Suzuki  <ysuz...@apple.com>
+
+        REGRESSION(r281513?): [ JSC Catalina+ Debug ] 16 stress/intl-enumeration.js (JSC Tests) are flaky failing
+        https://bugs.webkit.org/show_bug.cgi?id=229526
+
+        Reviewed by Mark Lam.
+
+        Fix debug JSC test failures by using RELEASE_AND_RETURN.
+
+        * runtime/IntlObject.cpp:
+        (JSC::availableCalendars):
+        (JSC::availableCollations):
+        (JSC::availableCurrencies):
+        (JSC::availableNumberingSystems):
+        (JSC::availableTimeZones):
+
 2021-08-25  Yijia Huang  <yijia_hu...@apple.com>
 
         [ARM64] Fix pre-index address mode

Modified: trunk/Source/_javascript_Core/runtime/IntlObject.cpp (281606 => 281607)

--- trunk/Source/_javascript_Core/runtime/IntlObject.cpp	2021-08-26 00:39:38 UTC (rev 281606)
+++ trunk/Source/_javascript_Core/runtime/IntlObject.cpp	2021-08-26 00:43:13 UTC (rev 281607)
@@ -1616,7 +1616,7 @@
             return WTF::codePointCompare(a, b) < 0;
         });
 
-    return createArrayFromStringVector(globalObject, WTFMove(elements));
+    RELEASE_AND_RETURN(scope, createArrayFromStringVector(globalObject, WTFMove(elements)));
 }
 
 // https://tc39.es/proposal-intl-enumeration/#sec-availablecollations
@@ -1663,7 +1663,7 @@
             return WTF::codePointCompare(a, b) < 0;
         });
 
-    return createArrayFromStringVector(globalObject, WTFMove(elements));
+    RELEASE_AND_RETURN(scope, createArrayFromStringVector(globalObject, WTFMove(elements)));
 }
 
 // https://tc39.es/proposal-intl-enumeration/#sec-availablecurrencies
@@ -1704,7 +1704,7 @@
             return WTF::codePointCompare(a, b) < 0;
         });
 
-    return createArrayFromStringVector(globalObject, WTFMove(elements));
+    RELEASE_AND_RETURN(scope, createArrayFromStringVector(globalObject, WTFMove(elements)));
 }
 
 // https://tc39.es/proposal-intl-enumeration/#sec-availablenumberingsystems
@@ -1745,7 +1745,7 @@
             return WTF::codePointCompare(a, b) < 0;
         });
 
-    return createArrayFromStringVector(globalObject, WTFMove(elements));
+    RELEASE_AND_RETURN(scope, createArrayFromStringVector(globalObject, WTFMove(elements)));
 }
 
 // https://tc39.es/proposal-intl-enumeration/#sec-canonicalizetimezonename
@@ -1804,7 +1804,7 @@
             return WTF::codePointCompare(a, b) < 0;
         });
 
-    return createArrayFromStringVector(globalObject, WTFMove(elements));
+    RELEASE_AND_RETURN(scope, createArrayFromStringVector(globalObject, WTFMove(elements)));
 }
 
 // https://tc39.es/proposal-intl-enumeration/#sec-availableunits

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes