Diff
Modified: trunk/Source/_javascript_Core/API/JSValue.h (281736 => 281737)
--- trunk/Source/_javascript_Core/API/JSValue.h 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/_javascript_Core/API/JSValue.h 2021-08-29 01:48:21 UTC (rev 281737)
@@ -322,7 +322,7 @@
If the value is not an object then a _javascript_ TypeError will be thrown.
The property <code>length</code> is read from the object, converted to an unsigned
integer, and an NSArray of this size is allocated. Properties corresponding
- to indicies within the array bounds will be copied to the array, with
+ to indices within the array bounds will be copied to the array, with
JSValues converted to equivalent Objective-C objects as specified.
@result The NSArray containing the recursively converted contents of the
converted _javascript_ array.
Modified: trunk/Source/_javascript_Core/ChangeLog (281736 => 281737)
--- trunk/Source/_javascript_Core/ChangeLog 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-08-29 01:48:21 UTC (rev 281737)
@@ -1,3 +1,14 @@
+2021-08-28 Cameron McCormack <[email protected]>
+
+ Miscellaneous typo fixes
+ https://bugs.webkit.org/show_bug.cgi?id=229642
+
+ Reviewed by Fujii Hironori.
+
+ * API/JSValue.h:
+ * runtime/RegExp.cpp:
+ (JSC::RegExp::matchCompareWithInterpreter):
+
2021-08-27 Stephan Szabo <[email protected]>
[PlayStation][CMake] Add control over whether _javascript_Core should be shared
Modified: trunk/Source/_javascript_Core/runtime/RegExp.cpp (281736 => 281737)
--- trunk/Source/_javascript_Core/runtime/RegExp.cpp 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/_javascript_Core/runtime/RegExp.cpp 2021-08-29 01:48:21 UTC (rev 281737)
@@ -377,8 +377,8 @@
int differences = 0;
// Initialize interpreterOffsetVector with the return value (index 0) and the
- // first subpattern start indicies (even index values) set to -1.
- // No need to init the subpattern end indicies.
+ // first subpattern start indices (even index values) set to -1.
+ // No need to init the subpattern end indices.
for (unsigned j = 0, i = 0; i < m_numSubpatterns + 1; j += 2, i++)
interpreterOffsetVector[j] = -1;
Modified: trunk/Source/WTF/ChangeLog (281736 => 281737)
--- trunk/Source/WTF/ChangeLog 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/WTF/ChangeLog 2021-08-29 01:48:21 UTC (rev 281737)
@@ -1,3 +1,15 @@
+2021-08-28 Cameron McCormack <[email protected]>
+
+ Miscellaneous typo fixes
+ https://bugs.webkit.org/show_bug.cgi?id=229642
+
+ Reviewed by Fujii Hironori.
+
+ * wtf/CrossThreadTask.h:
+ (WTF::callMemberFunctionForCrossThreadTask):
+ * wtf/text/StringImpl.h:
+ (WTF::StringImpl::createSubstringSharingImpl):
+
2021-08-28 David Kilzer <[email protected]>
[WTF] Fix static analyzer warnings about nullptr derefs in StringImpl::copyCharacters() and tryMakeStringFromAdapters()
Modified: trunk/Source/WTF/wtf/CrossThreadTask.h (281736 => 281737)
--- trunk/Source/WTF/wtf/CrossThreadTask.h 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/WTF/wtf/CrossThreadTask.h 2021-08-29 01:48:21 UTC (rev 281737)
@@ -81,10 +81,10 @@
(object->*function)(std::get<ArgsIndex>(std::forward<ArgsTuple>(args))...);
}
-template <typename C, typename MF, typename ArgsTuple, typename ArgsIndicies = std::make_index_sequence<std::tuple_size<ArgsTuple>::value>>
+template <typename C, typename MF, typename ArgsTuple, typename ArgsIndices = std::make_index_sequence<std::tuple_size<ArgsTuple>::value>>
void callMemberFunctionForCrossThreadTask(C* object, MF function, ArgsTuple&& args)
{
- callMemberFunctionForCrossThreadTaskImpl(object, function, std::forward<ArgsTuple>(args), ArgsIndicies());
+ callMemberFunctionForCrossThreadTaskImpl(object, function, std::forward<ArgsTuple>(args), ArgsIndices());
}
template<typename T, typename std::enable_if<std::is_base_of<ThreadSafeRefCountedBase, T>::value, int>::type = 0, typename... Parameters, typename... Arguments>
Modified: trunk/Source/WTF/wtf/text/StringImpl.h (281736 => 281737)
--- trunk/Source/WTF/wtf/text/StringImpl.h 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/WTF/wtf/text/StringImpl.h 2021-08-29 01:48:21 UTC (rev 281737)
@@ -966,7 +966,7 @@
if (!length)
return *empty();
- // Coyping the thing would save more memory sometimes, largely due to the size of pointer.
+ // Copying the thing would save more memory sometimes, largely due to the size of pointer.
size_t substringSize = allocationSize<StringImpl*>(1);
if (rep.is8Bit()) {
if (substringSize >= allocationSize<LChar>(length))
Modified: trunk/Source/WebCore/ChangeLog (281736 => 281737)
--- trunk/Source/WebCore/ChangeLog 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/WebCore/ChangeLog 2021-08-29 01:48:21 UTC (rev 281737)
@@ -1,3 +1,18 @@
+2021-08-28 Cameron McCormack <[email protected]>
+
+ Miscellaneous typo fixes
+ https://bugs.webkit.org/show_bug.cgi?id=229642
+
+ Reviewed by Fujii Hironori.
+
+ * platform/MIMETypeRegistry.cpp:
+ (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
+ * platform/graphics/cpu/arm/filters/FELightingNEON.cpp:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::computeClipPath const):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::rareNonInheritedDataChangeRequiresLayout):
+
2021-08-28 Simon Fraser <[email protected]>
Zooming browser does not properly scale SVG clip paths
Modified: trunk/Source/WebCore/platform/MIMETypeRegistry.cpp (281736 => 281737)
--- trunk/Source/WebCore/platform/MIMETypeRegistry.cpp 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/WebCore/platform/MIMETypeRegistry.cpp 2021-08-29 01:48:21 UTC (rev 281737)
@@ -409,7 +409,7 @@
return false;
static constexpr SortedArraySet supportedImageMIMETypeSet { supportedImageMIMETypeArray };
#if USE(CG) && ASSERT_ENABLED
- // Esnure supportedImageMIMETypeArray matches defaultSupportedImageTypes().
+ // Ensure supportedImageMIMETypeArray matches defaultSupportedImageTypes().
static std::once_flag onceFlag;
std::call_once(onceFlag, [] {
for (auto& imageType : defaultSupportedImageTypes()) {
Modified: trunk/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp (281736 => 281737)
--- trunk/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp 2021-08-29 01:48:21 UTC (rev 281737)
@@ -39,7 +39,7 @@
// Alpha coefficients.
-2, 1, 0, -1, 2, 1, 0, -1,
0, -1, -2, -1, 0, 1, 2, 1,
- // Remapping indicies.
+ // Remapping indices.
0x0f0e, 0x0302, 0x0504, 0x0706,
0x0b0a, 0x1312, 0x1514, 0x1716,
};
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (281736 => 281737)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2021-08-29 01:48:21 UTC (rev 281737)
@@ -3131,7 +3131,7 @@
Path RenderLayer::computeClipPath(const LayoutSize& offsetFromRoot, LayoutRect& rootRelativeBounds, WindRule& windRule) const
{
const RenderStyle& style = renderer().style();
- float deviceSaleFactor = renderer().document().deviceScaleFactor();
+ float deviceScaleFactor = renderer().document().deviceScaleFactor();
if (is<ShapeClipPathOperation>(*style.clipPath())) {
auto& clipPath = downcast<ShapeClipPathOperation>(*style.clipPath());
@@ -3143,7 +3143,7 @@
} else
referenceBox = rootRelativeBounds;
- FloatRect snappedReferenceBox = snapRectToDevicePixels(referenceBox, deviceSaleFactor);
+ FloatRect snappedReferenceBox = snapRectToDevicePixels(referenceBox, deviceScaleFactor);
windRule = clipPath.windRule();
return clipPath.pathForReferenceRect(snappedReferenceBox);
@@ -3152,7 +3152,7 @@
if (is<BoxClipPathOperation>(*style.clipPath()) && is<RenderBox>(renderer())) {
auto& clipPath = downcast<BoxClipPathOperation>(*style.clipPath());
- FloatRoundedRect shapeRect = computeRoundedRectForBoxShape(clipPath.referenceBox(), downcast<RenderBox>(renderer())).pixelSnappedRoundedRectForPainting(deviceSaleFactor);
+ FloatRoundedRect shapeRect = computeRoundedRectForBoxShape(clipPath.referenceBox(), downcast<RenderBox>(renderer())).pixelSnappedRoundedRectForPainting(deviceScaleFactor);
shapeRect.move(offsetFromRoot);
windRule = WindRule::NonZero;
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (281736 => 281737)
--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2021-08-29 01:48:21 UTC (rev 281737)
@@ -724,7 +724,7 @@
#if ENABLE(CSS_COMPOSITING)
if (first.isolation != second.isolation) {
- // Ideally this would trigger a cheaper layout that just updates layer z-order trees (webit.org/b/190088).
+ // Ideally this would trigger a cheaper layout that just updates layer z-order trees (webkit.org/b/190088).
return true;
}
#endif
Modified: trunk/Source/WebKit/ChangeLog (281736 => 281737)
--- trunk/Source/WebKit/ChangeLog 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/WebKit/ChangeLog 2021-08-29 01:48:21 UTC (rev 281737)
@@ -1,3 +1,17 @@
+2021-08-28 Cameron McCormack <[email protected]>
+
+ Miscellaneous typo fixes
+ https://bugs.webkit.org/show_bug.cgi?id=229642
+
+ Reviewed by Fujii Hironori.
+
+ * Platform/IPC/HandleMessage.h:
+ (IPC::callMemberFunction):
+ * Shared/Cocoa/ArgumentCodersCocoa.mm:
+ (IPC::encodeArrayInternal):
+ * Shared/cf/ArgumentCodersCF.cpp:
+ (IPC::ArgumentCoder<CFArrayRef>::encode):
+
2021-08-27 Cameron McCormack <[email protected]>
Fix std::optional<> stripping in MessageArgumentDescriptions.cpp generator
Modified: trunk/Source/WebKit/Platform/IPC/HandleMessage.h (281736 => 281737)
--- trunk/Source/WebKit/Platform/IPC/HandleMessage.h 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/WebKit/Platform/IPC/HandleMessage.h 2021-08-29 01:48:21 UTC (rev 281737)
@@ -43,10 +43,10 @@
(object->*function)(std::get<ArgsIndex>(std::forward<ArgsTuple>(args))...);
}
-template<typename C, typename MF, typename ArgsTuple, typename ArgsIndicies = std::make_index_sequence<std::tuple_size<ArgsTuple>::value>>
+template<typename C, typename MF, typename ArgsTuple, typename ArgsIndices = std::make_index_sequence<std::tuple_size<ArgsTuple>::value>>
void callMemberFunction(ArgsTuple&& args, C* object, MF function)
{
- callMemberFunctionImpl(object, function, std::forward<ArgsTuple>(args), ArgsIndicies());
+ callMemberFunctionImpl(object, function, std::forward<ArgsTuple>(args), ArgsIndices());
}
// Dispatch functions with synchronous reply arguments.
@@ -57,10 +57,10 @@
(object->*function)(std::get<ArgsIndex>(std::forward<ArgsTuple>(args))..., WTFMove(completionHandler));
}
-template<typename C, typename MF, typename CH, typename ArgsTuple, typename ArgsIndicies = std::make_index_sequence<std::tuple_size<ArgsTuple>::value>>
+template<typename C, typename MF, typename CH, typename ArgsTuple, typename ArgsIndices = std::make_index_sequence<std::tuple_size<ArgsTuple>::value>>
void callMemberFunction(ArgsTuple&& args, CompletionHandler<CH>&& completionHandler, C* object, MF function)
{
- callMemberFunctionImpl(object, function, WTFMove(completionHandler), std::forward<ArgsTuple>(args), ArgsIndicies());
+ callMemberFunctionImpl(object, function, WTFMove(completionHandler), std::forward<ArgsTuple>(args), ArgsIndices());
}
// Dispatch functions with connection parameter with synchronous reply arguments.
@@ -71,10 +71,10 @@
(object->*function)(connection, std::get<ArgsIndex>(std::forward<ArgsTuple>(args))..., WTFMove(completionHandler));
}
-template<typename C, typename MF, typename CH, typename ArgsTuple, typename ArgsIndicies = std::make_index_sequence<std::tuple_size<ArgsTuple>::value>>
+template<typename C, typename MF, typename CH, typename ArgsTuple, typename ArgsIndices = std::make_index_sequence<std::tuple_size<ArgsTuple>::value>>
void callMemberFunction(Connection& connection, ArgsTuple&& args, CompletionHandler<CH>&& completionHandler, C* object, MF function)
{
- callMemberFunctionImpl(connection, object, function, WTFMove(completionHandler), std::forward<ArgsTuple>(args), ArgsIndicies());
+ callMemberFunctionImpl(connection, object, function, WTFMove(completionHandler), std::forward<ArgsTuple>(args), ArgsIndices());
}
// Dispatch functions with connection parameter with no reply arguments.
@@ -85,10 +85,10 @@
(object->*function)(connection, std::get<ArgsIndex>(std::forward<ArgsTuple>(args))...);
}
-template<typename C, typename MF, typename ArgsTuple, typename ArgsIndicies = std::make_index_sequence<std::tuple_size<ArgsTuple>::value>>
+template<typename C, typename MF, typename ArgsTuple, typename ArgsIndices = std::make_index_sequence<std::tuple_size<ArgsTuple>::value>>
void callMemberFunction(Connection& connection, ArgsTuple&& args, C* object, MF function)
{
- callMemberFunctionImpl(object, function, connection, std::forward<ArgsTuple>(args), ArgsIndicies());
+ callMemberFunctionImpl(object, function, connection, std::forward<ArgsTuple>(args), ArgsIndices());
}
// Main dispatch functions
Modified: trunk/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm (281736 => 281737)
--- trunk/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm 2021-08-29 01:48:21 UTC (rev 281737)
@@ -236,7 +236,7 @@
return;
}
- HashSet<NSUInteger> invalidIndicies;
+ HashSet<NSUInteger> invalidIndices;
for (NSUInteger i = 0; i < array.count; ++i) {
id value = array[i];
@@ -243,13 +243,13 @@
// Ignore values we don't support.
ASSERT(isSerializableValue(value));
if (!isSerializableValue(value))
- invalidIndicies.add(i);
+ invalidIndices.add(i);
}
- encoder << static_cast<uint64_t>(array.count - invalidIndicies.size());
+ encoder << static_cast<uint64_t>(array.count - invalidIndices.size());
for (NSUInteger i = 0; i < array.count; ++i) {
- if (invalidIndicies.contains(i))
+ if (invalidIndices.contains(i))
continue;
encodeObject(encoder, array[i]);
}
Modified: trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp (281736 => 281737)
--- trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp 2021-08-29 01:31:55 UTC (rev 281736)
+++ trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp 2021-08-29 01:48:21 UTC (rev 281737)
@@ -327,18 +327,18 @@
CFArrayGetValues(array, CFRangeMake(0, size), values.data());
- HashSet<CFIndex> invalidIndicies;
+ HashSet<CFIndex> invalidIndices;
for (CFIndex i = 0; i < size; ++i) {
// Ignore values we don't support.
ASSERT(typeFromCFTypeRef(values[i]) != CFType::Unknown);
if (typeFromCFTypeRef(values[i]) == CFType::Unknown)
- invalidIndicies.add(i);
+ invalidIndices.add(i);
}
- encoder << static_cast<uint64_t>(size - invalidIndicies.size());
+ encoder << static_cast<uint64_t>(size - invalidIndices.size());
for (CFIndex i = 0; i < size; ++i) {
- if (invalidIndicies.contains(i))
+ if (invalidIndices.contains(i))
continue;
encoder << values[i];
}
