- Revision
- 281749
- Author
- [email protected]
- Date
- 2021-08-29 17:53:02 -0700 (Sun, 29 Aug 2021)
Log Message
Run tests in fast/forms/ios by default in EWS
https://bugs.webkit.org/show_bug.cgi?id=229656
Reviewed by Tim Horton.
Adjust test expectations so that tests added to fast/forms/ios run on (open source) iOS simulator test runners
in EWS.
* platform/ios-14/TestExpectations:
* platform/ios-wk2/TestExpectations:
Mark "fast/forms/ios" as PASS by default in the WebKit2 port on iOS, but add a few more expectations for tests
that are currently failing or flaky in non-internal iOS 14 simulator builds.
* pointerevents/ios/inputmode-change-update-keyboard-after-pointerup-expected.txt: Renamed from LayoutTests/fast/forms/ios/inputmode-change-update-keyboard-after-pointerup-expected.txt.
* pointerevents/ios/inputmode-change-update-keyboard-after-pointerup.html: Renamed from LayoutTests/fast/forms/ios/inputmode-change-update-keyboard-after-pointerup.html.
Move a layout tests that depends on pointer events ("pointerup" and "pointerdown") into
LayoutTests/pointerevents/ios, so that we don't start attempting to run this in OpenSource.
Modified Paths
Added Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (281748 => 281749)
--- trunk/LayoutTests/ChangeLog 2021-08-29 21:36:05 UTC (rev 281748)
+++ trunk/LayoutTests/ChangeLog 2021-08-30 00:53:02 UTC (rev 281749)
@@ -1,3 +1,25 @@
+2021-08-29 Wenson Hsieh <[email protected]>
+
+ Run tests in fast/forms/ios by default in EWS
+ https://bugs.webkit.org/show_bug.cgi?id=229656
+
+ Reviewed by Tim Horton.
+
+ Adjust test expectations so that tests added to fast/forms/ios run on (open source) iOS simulator test runners
+ in EWS.
+
+ * platform/ios-14/TestExpectations:
+ * platform/ios-wk2/TestExpectations:
+
+ Mark "fast/forms/ios" as PASS by default in the WebKit2 port on iOS, but add a few more expectations for tests
+ that are currently failing or flaky in non-internal iOS 14 simulator builds.
+
+ * pointerevents/ios/inputmode-change-update-keyboard-after-pointerup-expected.txt: Renamed from LayoutTests/fast/forms/ios/inputmode-change-update-keyboard-after-pointerup-expected.txt.
+ * pointerevents/ios/inputmode-change-update-keyboard-after-pointerup.html: Renamed from LayoutTests/fast/forms/ios/inputmode-change-update-keyboard-after-pointerup.html.
+
+ Move a layout tests that depends on pointer events ("pointerup" and "pointerdown") into
+ LayoutTests/pointerevents/ios, so that we don't start attempting to run this in OpenSource.
+
2021-08-29 Rob Buis <[email protected]>
Nullptr crash in ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline
Deleted: trunk/LayoutTests/fast/forms/ios/inputmode-change-update-keyboard-after-pointerup-expected.txt (281748 => 281749)
--- trunk/LayoutTests/fast/forms/ios/inputmode-change-update-keyboard-after-pointerup-expected.txt 2021-08-29 21:36:05 UTC (rev 281748)
+++ trunk/LayoutTests/fast/forms/ios/inputmode-change-update-keyboard-after-pointerup-expected.txt 2021-08-30 00:53:02 UTC (rev 281749)
@@ -1,17 +0,0 @@
-This tests updating inputmode of an input element from "none" to "text". The software keyboard should be brought up after pointerup.
-To manually test, tap on the input element below. The software keyboard should be brought up
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS textHeight = keyboardRect.height; keyboardRect.height > 0 is true
-PASS logs.length is 2
-PASS logs[0].event.type is "pointerdown"
-PASS logs[0].visualViewportHeight is originalVisualViewportHeight
-PASS logs[1].event.type is "pointerup"
-PASS logs[1].visualViewportHeight is originalVisualViewportHeight
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
-
Deleted: trunk/LayoutTests/fast/forms/ios/inputmode-change-update-keyboard-after-pointerup.html (281748 => 281749)
--- trunk/LayoutTests/fast/forms/ios/inputmode-change-update-keyboard-after-pointerup.html 2021-08-29 21:36:05 UTC (rev 281748)
+++ trunk/LayoutTests/fast/forms/ios/inputmode-change-update-keyboard-after-pointerup.html 2021-08-30 00:53:02 UTC (rev 281749)
@@ -1,60 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=no">
-<script src=""
-<script src=""
-</head>
-<body>
-<input inputmode="none">
-<div id="countdown"></div>
-<script>
-jsTestIsAsync = true;
-
-description('This tests updating inputmode of an input element from "none" to "text". The software keyboard should be brought up after pointerup.<br>'
- + 'To manually test, tap on the input element below. The software keyboard should be brought up');
-
-const input = document.querySelector("input");
-input.focus();
-
-let originalVisualViewportHeight;
-let logs = [];
-async function runTest() {
- if (window.testRunner)
- await UIHelper.setHardwareKeyboardAttached(false);
-
- originalVisualViewportHeight = window.visualViewport.height;
-
- let didResize = () => { };
- window.visualViewport.addEventListener('resize', () => didResize());
- input.addEventListener('pointerdown', (event) => {
- input.inputMode = 'text';
- logs.push({event, visualViewportHeight: visualViewport.height});
- }, {once: true});
- input.addEventListener('pointerup', (event) => {
- logs.push({event, visualViewportHeight: visualViewport.height});
- }, {once: true});
-
- if (window.testRunner) {
- await UIHelper.activateFormControl(input);
- window.keyboardRect = await UIHelper.inputViewBounds();
- shouldBeTrue('textHeight = keyboardRect.height; keyboardRect.height > 0');
- } else {
- await new Promise((resolve) => { didResize = resolve; });
- shouldBeTrue('textHeight = document.documentElement.clientHeight - visualViewport.height; document.documentElement.clientHeight - visualViewport.height < 100');
- }
-
- shouldBe('logs.length', '2');
- shouldBeEqualToString('logs[0].event.type', 'pointerdown');
- shouldBe('logs[0].visualViewportHeight', 'originalVisualViewportHeight');
- shouldBeEqualToString('logs[1].event.type', 'pointerup');
- shouldBe('logs[1].visualViewportHeight', 'originalVisualViewportHeight');
-
- finishJSTest();
-}
-
-window._onload_ = () => setTimeout(runTest, 0);
-
-</script>
-</body>
-</html>
Modified: trunk/LayoutTests/platform/ios-14/TestExpectations (281748 => 281749)
--- trunk/LayoutTests/platform/ios-14/TestExpectations 2021-08-29 21:36:05 UTC (rev 281748)
+++ trunk/LayoutTests/platform/ios-14/TestExpectations 2021-08-30 00:53:02 UTC (rev 281749)
@@ -75,3 +75,20 @@
# rdar://79084756 ((r278618) media/modern-media-controls /overflow-support/chapters.html is timing out since introduction (226828))
media/modern-media-controls/overflow-support/chapters.html [ Pass ]
+
+# These tests fail or are flaky in non-internal iOS 14 simulator
+fast/forms/ios/accessory-bar-navigation.html [ Pass Failure ]
+fast/forms/ios/autocapitalize-words.html [ Pass Failure ]
+fast/forms/ios/focus-input-in-fixed.html [ Pass Failure ]
+fast/forms/ios/focus-input-in-iframe.html [ Pass Failure ]
+fast/forms/ios/focus-input-via-button-no-scaling.html [ Pass Failure ]
+fast/forms/ios/focus-input-via-button.html [ Pass Failure ]
+fast/forms/ios/focus-long-textarea.html [ Pass Failure ]
+fast/forms/ios/inputmode-none-with-hardware-keyboard.html [ Pass Failure ]
+fast/forms/ios/zoom-after-input-tap-wide-input.html [ Pass Failure ]
+fast/forms/ios/zoom-after-input-tap.html [ Pass Failure ]
+
+fast/forms/ios/dismiss-picker-using-keyboard.html [ Pass Timeout ]
+fast/forms/ios/drag-range-thumb.html [ Pass Timeout ]
+fast/forms/ios/inputmode-change-update-keyboard.html [ Pass Timeout ]
+fast/forms/ios/ipad/open-picker-using-keyboard.html [ Pass Timeout ]
\ No newline at end of file
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (281748 => 281749)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-08-29 21:36:05 UTC (rev 281748)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-08-30 00:53:02 UTC (rev 281749)
@@ -16,6 +16,7 @@
contact-picker/contacts-select.html [ Pass ]
fast/device-orientation [ Pass ]
http/tests/device-orientation [ Pass ]
+fast/forms/ios [ Pass ]
fast/history/ios [ Pass ]
fast/scrolling/ios [ Pass ]
fast/speechrecognition/ios [ Pass ]
Copied: trunk/LayoutTests/pointerevents/ios/inputmode-change-update-keyboard-after-pointerup-expected.txt (from rev 281748, trunk/LayoutTests/fast/forms/ios/inputmode-change-update-keyboard-after-pointerup-expected.txt) (0 => 281749)
--- trunk/LayoutTests/pointerevents/ios/inputmode-change-update-keyboard-after-pointerup-expected.txt (rev 0)
+++ trunk/LayoutTests/pointerevents/ios/inputmode-change-update-keyboard-after-pointerup-expected.txt 2021-08-30 00:53:02 UTC (rev 281749)
@@ -0,0 +1,17 @@
+This tests updating inputmode of an input element from "none" to "text". The software keyboard should be brought up after pointerup.
+To manually test, tap on the input element below. The software keyboard should be brought up
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS textHeight = keyboardRect.height; keyboardRect.height > 0 is true
+PASS logs.length is 2
+PASS logs[0].event.type is "pointerdown"
+PASS logs[0].visualViewportHeight is originalVisualViewportHeight
+PASS logs[1].event.type is "pointerup"
+PASS logs[1].visualViewportHeight is originalVisualViewportHeight
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
+
Copied: trunk/LayoutTests/pointerevents/ios/inputmode-change-update-keyboard-after-pointerup.html (from rev 281748, trunk/LayoutTests/fast/forms/ios/inputmode-change-update-keyboard-after-pointerup.html) (0 => 281749)
--- trunk/LayoutTests/pointerevents/ios/inputmode-change-update-keyboard-after-pointerup.html (rev 0)
+++ trunk/LayoutTests/pointerevents/ios/inputmode-change-update-keyboard-after-pointerup.html 2021-08-30 00:53:02 UTC (rev 281749)
@@ -0,0 +1,60 @@
+<!DOCTYPE html>
+<html>
+<head>
+<meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=no">
+<script src=""
+<script src=""
+</head>
+<body>
+<input inputmode="none">
+<div id="countdown"></div>
+<script>
+jsTestIsAsync = true;
+
+description('This tests updating inputmode of an input element from "none" to "text". The software keyboard should be brought up after pointerup.<br>'
+ + 'To manually test, tap on the input element below. The software keyboard should be brought up');
+
+const input = document.querySelector("input");
+input.focus();
+
+let originalVisualViewportHeight;
+let logs = [];
+async function runTest() {
+ if (window.testRunner)
+ await UIHelper.setHardwareKeyboardAttached(false);
+
+ originalVisualViewportHeight = window.visualViewport.height;
+
+ let didResize = () => { };
+ window.visualViewport.addEventListener('resize', () => didResize());
+ input.addEventListener('pointerdown', (event) => {
+ input.inputMode = 'text';
+ logs.push({event, visualViewportHeight: visualViewport.height});
+ }, {once: true});
+ input.addEventListener('pointerup', (event) => {
+ logs.push({event, visualViewportHeight: visualViewport.height});
+ }, {once: true});
+
+ if (window.testRunner) {
+ await UIHelper.activateFormControl(input);
+ window.keyboardRect = await UIHelper.inputViewBounds();
+ shouldBeTrue('textHeight = keyboardRect.height; keyboardRect.height > 0');
+ } else {
+ await new Promise((resolve) => { didResize = resolve; });
+ shouldBeTrue('textHeight = document.documentElement.clientHeight - visualViewport.height; document.documentElement.clientHeight - visualViewport.height < 100');
+ }
+
+ shouldBe('logs.length', '2');
+ shouldBeEqualToString('logs[0].event.type', 'pointerdown');
+ shouldBe('logs[0].visualViewportHeight', 'originalVisualViewportHeight');
+ shouldBeEqualToString('logs[1].event.type', 'pointerup');
+ shouldBe('logs[1].visualViewportHeight', 'originalVisualViewportHeight');
+
+ finishJSTest();
+}
+
+window._onload_ = () => setTimeout(runTest, 0);
+
+</script>
+</body>
+</html>
