Title: [281755] trunk/Tools
- Revision
- 281755
- Author
- [email protected]
- Date
- 2021-08-30 07:24:14 -0700 (Mon, 30 Aug 2021)
Log Message
[WPE][webkitpy] Sanitize browser name testcase environment
https://bugs.webkit.org/show_bug.cgi?id=229667
Reviewed by Carlos Garcia Campos.
Around 2021-08-19, the WPE release bot changed its environment to
ensure WPE_BROWSER points to MiniBrowser while Cog webdriver support
was not present. Since then, the WPE webkitpy test
test_browser_name_with_cog_built was failing, as the host envvar
affected the code being tested.
This commits ensures the variable is empty for proper testing.
* Scripts/webkitpy/port/wpe_unittest.py:
(WPEPortTest.test_browser_name_with_cog_built):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (281754 => 281755)
--- trunk/Tools/ChangeLog 2021-08-30 14:12:45 UTC (rev 281754)
+++ trunk/Tools/ChangeLog 2021-08-30 14:24:14 UTC (rev 281755)
@@ -1,3 +1,21 @@
+2021-08-30 Lauro Moura <[email protected]>
+
+ [WPE][webkitpy] Sanitize browser name testcase environment
+ https://bugs.webkit.org/show_bug.cgi?id=229667
+
+ Reviewed by Carlos Garcia Campos.
+
+ Around 2021-08-19, the WPE release bot changed its environment to
+ ensure WPE_BROWSER points to MiniBrowser while Cog webdriver support
+ was not present. Since then, the WPE webkitpy test
+ test_browser_name_with_cog_built was failing, as the host envvar
+ affected the code being tested.
+
+ This commits ensures the variable is empty for proper testing.
+
+ * Scripts/webkitpy/port/wpe_unittest.py:
+ (WPEPortTest.test_browser_name_with_cog_built):
+
2021-08-29 Diego Pino Garcia <[email protected]>
[GTK][WPE] Add ICU 63.1 to JHBuild minimal dependencies
Modified: trunk/Tools/Scripts/webkitpy/port/wpe_unittest.py (281754 => 281755)
--- trunk/Tools/Scripts/webkitpy/port/wpe_unittest.py 2021-08-30 14:12:45 UTC (rev 281754)
+++ trunk/Tools/Scripts/webkitpy/port/wpe_unittest.py 2021-08-30 14:24:14 UTC (rev 281755)
@@ -83,11 +83,12 @@
self.assertEqual(port.browser_name(), "minibrowser")
def test_browser_name_with_cog_built(self):
- port = self.make_port()
- port._filesystem = MockFileSystem({
- "/mock-build/Tools/cog-prefix/src/cog-build/cog": "",
- })
- self.assertEqual(port.browser_name(), "cog")
+ with patch('os.environ', {'WPE_BROWSER': ''}):
+ port = self.make_port()
+ port._filesystem = MockFileSystem({
+ "/mock-build/Tools/cog-prefix/src/cog-build/cog": "",
+ })
+ self.assertEqual(port.browser_name(), "cog")
def test_browser_name_override_minibrowser_with_cog_built(self):
with patch('os.environ', {'WPE_BROWSER': 'MiniBrowser'}):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
