Title: [281831] trunk
- Revision
- 281831
- Author
- katherine_che...@apple.com
- Date
- 2021-08-31 16:10:54 -0700 (Tue, 31 Aug 2021)
Log Message
Use after move in ServiceWorkerThreadProxy
https://bugs.webkit.org/show_bug.cgi?id=229731
Reviewed by Chris Dumez.
Source/WebCore:
* workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy):
Source/WebKit:
* WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):
Tools:
While trying to test that this change did not cause regressions,
I found a bug in the test code from the mass renaming that happened
a few weeks ago. This patch fixes that.
* TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (281830 => 281831)
--- trunk/Source/WebCore/ChangeLog 2021-08-31 23:07:44 UTC (rev 281830)
+++ trunk/Source/WebCore/ChangeLog 2021-08-31 23:10:54 UTC (rev 281831)
@@ -1,3 +1,13 @@
+2021-08-31 Kate Cheney <katherine_che...@apple.com>
+
+ Use after move in ServiceWorkerThreadProxy
+ https://bugs.webkit.org/show_bug.cgi?id=229731
+
+ Reviewed by Chris Dumez.
+
+ * workers/service/context/ServiceWorkerThreadProxy.cpp:
+ (WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy):
+
2021-08-31 Marcos Caceres <mar...@marcosc.com>
[Payment Request] Calling PaymentRequest's show() should consume user activation
Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp (281830 => 281831)
--- trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp 2021-08-31 23:07:44 UTC (rev 281830)
+++ trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp 2021-08-31 23:10:54 UTC (rev 281831)
@@ -116,9 +116,6 @@
m_remoteDebuggable->setRemoteDebuggingAllowed(true);
m_remoteDebuggable->init();
#endif
-
- if (data.lastNavigationWasAppInitiated)
- setLastNavigationWasAppInitiated(data.lastNavigationWasAppInitiated == LastNavigationWasAppInitiated::Yes);
}
ServiceWorkerThreadProxy::~ServiceWorkerThreadProxy()
Modified: trunk/Source/WebKit/ChangeLog (281830 => 281831)
--- trunk/Source/WebKit/ChangeLog 2021-08-31 23:07:44 UTC (rev 281830)
+++ trunk/Source/WebKit/ChangeLog 2021-08-31 23:10:54 UTC (rev 281831)
@@ -1,3 +1,13 @@
+2021-08-31 Kate Cheney <katherine_che...@apple.com>
+
+ Use after move in ServiceWorkerThreadProxy
+ https://bugs.webkit.org/show_bug.cgi?id=229731
+
+ Reviewed by Chris Dumez.
+
+ * WebProcess/Storage/WebSWContextManagerConnection.cpp:
+ (WebKit::WebSWContextManagerConnection::installServiceWorker):
+
2021-08-31 Aditya Keerthi <akeer...@apple.com>
[iOS] Move the implementation of -[WKWebView _dynamicUserInterfaceTraitDidChange] out of the testing category
Modified: trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp (281830 => 281831)
--- trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp 2021-08-31 23:07:44 UTC (rev 281830)
+++ trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp 2021-08-31 23:10:54 UTC (rev 281831)
@@ -161,7 +161,13 @@
#if !RELEASE_LOG_DISABLED
auto serviceWorkerIdentifier = data.serviceWorkerIdentifier;
#endif
+
+ auto lastNavigationWasAppInitiated = data.lastNavigationWasAppInitiated;
auto serviceWorkerThreadProxy = ServiceWorkerThreadProxy::create(WTFMove(pageConfiguration), WTFMove(data), WTFMove(effectiveUserAgent), WebProcess::singleton().cacheStorageProvider(), m_storageBlockingPolicy);
+
+ if (lastNavigationWasAppInitiated)
+ serviceWorkerThreadProxy->setLastNavigationWasAppInitiated(lastNavigationWasAppInitiated == WebCore::LastNavigationWasAppInitiated::Yes);
+
SWContextManager::singleton().registerServiceWorkerThreadForInstall(WTFMove(serviceWorkerThreadProxy));
RELEASE_LOG(ServiceWorker, "Created service worker %" PRIu64 " in process PID %i", serviceWorkerIdentifier.toUInt64(), getCurrentProcessID());
Modified: trunk/Tools/ChangeLog (281830 => 281831)
--- trunk/Tools/ChangeLog 2021-08-31 23:07:44 UTC (rev 281830)
+++ trunk/Tools/ChangeLog 2021-08-31 23:10:54 UTC (rev 281831)
@@ -1,3 +1,16 @@
+2021-08-31 Kate Cheney <katherine_che...@apple.com>
+
+ Use after move in ServiceWorkerThreadProxy
+ https://bugs.webkit.org/show_bug.cgi?id=229731
+
+ Reviewed by Chris Dumez.
+
+ While trying to test that this change did not cause regressions,
+ I found a bug in the test code from the mass renaming that happened
+ a few weeks ago. This patch fixes that.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:
+
2021-08-31 Jonathan Bedard <jbed...@apple.com>
[git-webkit] Automatic rebasing or pull-requests
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm (281830 => 281831)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm 2021-08-31 23:07:44 UTC (rev 281830)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm 2021-08-31 23:10:54 UTC (rev 281831)
@@ -603,7 +603,7 @@
async function queryAppPrivacyReportValue(event, haveSentInitialMessage)
{
- var result = await internals.lastNavigationWasAppPrivacyReport();
+ var result = await internals.lastNavigationWasAppInitiated();
if (result) {
if (event.data == "FIRST") {
event.source.postMessage('app initiated');
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
