Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (281836 => 281837)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-01 02:25:28 UTC (rev 281837)
@@ -1,3 +1,15 @@
+2021-08-31 Lauro Moura <[email protected]>
+
+ Non-unified build partial fixes, late late August 2021
+ https://bugs.webkit.org/show_bug.cgi?id=229741
+
+ Unreviewed non-unified build fixes.
+
+ * bytecode/PutByStatus.cpp: Add missing header.
+ * bytecode/PutByVariant.h: Ditto.
+ * runtime/TemporalCalendar.cpp: Ditto.
+ * runtime/TemporalCalendarPrototype.cpp: Ditto.
+
2021-08-31 Yusuke Suzuki <[email protected]>
[JSC] Enable Object.hasOwn
Modified: trunk/Source/_javascript_Core/bytecode/PutByStatus.cpp (281836 => 281837)
--- trunk/Source/_javascript_Core/bytecode/PutByStatus.cpp 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/_javascript_Core/bytecode/PutByStatus.cpp 2021-09-01 02:25:28 UTC (rev 281837)
@@ -27,6 +27,7 @@
#include "PutByStatus.h"
#include "BytecodeStructs.h"
+#include "CacheableIdentifierInlines.h"
#include "CodeBlock.h"
#include "ComplexGetStatus.h"
#include "GetterSetterAccessCase.h"
Modified: trunk/Source/_javascript_Core/bytecode/PutByVariant.h (281836 => 281837)
--- trunk/Source/_javascript_Core/bytecode/PutByVariant.h 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/_javascript_Core/bytecode/PutByVariant.h 2021-09-01 02:25:28 UTC (rev 281837)
@@ -25,6 +25,7 @@
#pragma once
+#include "CacheableIdentifier.h"
#include "ObjectPropertyConditionSet.h"
#include "PropertyOffset.h"
#include "StructureSet.h"
Modified: trunk/Source/_javascript_Core/runtime/TemporalCalendar.cpp (281836 => 281837)
--- trunk/Source/_javascript_Core/runtime/TemporalCalendar.cpp 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/_javascript_Core/runtime/TemporalCalendar.cpp 2021-09-01 02:25:28 UTC (rev 281837)
@@ -26,6 +26,9 @@
#include "config.h"
#include "TemporalCalendar.h"
+#include "JSObjectInlines.h"
+#include "StructureInlines.h"
+
namespace JSC {
const ClassInfo TemporalCalendar::s_info = { "Object", &Base::s_info, nullptr, nullptr, CREATE_METHOD_TABLE(TemporalCalendar) };
Modified: trunk/Source/_javascript_Core/runtime/TemporalCalendarPrototype.cpp (281836 => 281837)
--- trunk/Source/_javascript_Core/runtime/TemporalCalendarPrototype.cpp 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/_javascript_Core/runtime/TemporalCalendarPrototype.cpp 2021-09-01 02:25:28 UTC (rev 281837)
@@ -30,6 +30,7 @@
#include "IteratorOperations.h"
#include "JSCInlines.h"
#include "ObjectConstructor.h"
+#include "TemporalCalendar.h"
namespace JSC {
Modified: trunk/Source/WebCore/ChangeLog (281836 => 281837)
--- trunk/Source/WebCore/ChangeLog 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebCore/ChangeLog 2021-09-01 02:25:28 UTC (rev 281837)
@@ -1,3 +1,23 @@
+2021-08-31 Lauro Moura <[email protected]>
+
+ Non-unified build partial fixes, late late August 2021
+ https://bugs.webkit.org/show_bug.cgi?id=229741
+
+ Unreviewed non-unified build fixes.
+
+ Still missing a strange WebCoreTestSupport.a-related link error.
+
+ * Modules/mediastream/RTCIceTransportBackend.h: Add missing header.
+ * Modules/mediastream/RTCPeerConnection.cpp: Ditto.
+ * Modules/mediastream/libwebrtc/LibWebRTCIceTransportBackend.cpp:
+ Ditto.
+ * html/FormController.cpp:
+ (WebCore::formSignature): Namespace HTMLNames.
+ * html/FormController.h: Add missing header.
+ * html/track/LoadableTextTrack.cpp: Add missing header.
+ * loader/PrivateClickMeasurement.cpp: Ditto.
+ * page/PageConfiguration.cpp: Ditto.
+
2021-08-31 Chris Dumez <[email protected]>
Enable SharedArrayBuffer support when COOP/COEP headers are used
Modified: trunk/Source/WebCore/Modules/mediastream/RTCIceTransportBackend.h (281836 => 281837)
--- trunk/Source/WebCore/Modules/mediastream/RTCIceTransportBackend.h 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebCore/Modules/mediastream/RTCIceTransportBackend.h 2021-09-01 02:25:28 UTC (rev 281837)
@@ -28,6 +28,7 @@
#include "RTCIceGatheringState.h"
#include "RTCIceTransportState.h"
+#include <wtf/WeakPtr.h>
namespace WebCore {
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (281836 => 281837)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2021-09-01 02:25:28 UTC (rev 281837)
@@ -55,6 +55,8 @@
#include "RTCDtlsTransportBackend.h"
#include "RTCIceCandidate.h"
#include "RTCIceCandidateInit.h"
+#include "RTCIceTransport.h"
+#include "RTCIceTransportBackend.h"
#include "RTCOfferOptions.h"
#include "RTCPeerConnectionIceErrorEvent.h"
#include "RTCPeerConnectionIceEvent.h"
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCIceTransportBackend.cpp (281836 => 281837)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCIceTransportBackend.cpp 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCIceTransportBackend.cpp 2021-09-01 02:25:28 UTC (rev 281837)
@@ -25,6 +25,8 @@
#include "config.h"
#include "LibWebRTCIceTransportBackend.h"
+#include "LibWebRTCProvider.h"
+
#if ENABLE(WEB_RTC) && USE(LIBWEBRTC)
ALLOW_UNUSED_PARAMETERS_BEGIN
Modified: trunk/Source/WebCore/html/FormController.cpp (281836 => 281837)
--- trunk/Source/WebCore/html/FormController.cpp 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebCore/html/FormController.cpp 2021-09-01 02:25:28 UTC (rev 281837)
@@ -179,7 +179,7 @@
// Remove the query part because it might contain volatile parameters such as a session key.
// FIXME: But leave the fragment identifier? Perhaps we should switch to removeQueryAndFragmentIdentifier.
- URL actionURL = form.getURLAttribute(actionAttr);
+ URL actionURL = form.getURLAttribute(HTMLNames::actionAttr);
actionURL.setQuery({ });
builder.append(actionURL.string());
Modified: trunk/Source/WebCore/html/FormController.h (281836 => 281837)
--- trunk/Source/WebCore/html/FormController.h 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebCore/html/FormController.h 2021-09-01 02:25:28 UTC (rev 281837)
@@ -22,6 +22,7 @@
#pragma once
#include <wtf/Forward.h>
+#include <wtf/HashMap.h>
namespace WebCore {
Modified: trunk/Source/WebCore/html/track/LoadableTextTrack.cpp (281836 => 281837)
--- trunk/Source/WebCore/html/track/LoadableTextTrack.cpp 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebCore/html/track/LoadableTextTrack.cpp 2021-09-01 02:25:28 UTC (rev 281837)
@@ -34,6 +34,7 @@
#include "VTTCue.h"
#include "VTTRegionList.h"
#include <wtf/IsoMallocInlines.h>
+#include <wtf/SetForScope.h>
namespace WebCore {
Modified: trunk/Source/WebCore/loader/PrivateClickMeasurement.cpp (281836 => 281837)
--- trunk/Source/WebCore/loader/PrivateClickMeasurement.cpp 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebCore/loader/PrivateClickMeasurement.cpp 2021-09-01 02:25:28 UTC (rev 281837)
@@ -28,6 +28,7 @@
#include "Logging.h"
#include "RuntimeEnabledFeatures.h"
+#include <wtf/CrossThreadCopier.h>
#include <wtf/Expected.h>
#include <wtf/RandomNumber.h>
#include <wtf/URL.h>
Modified: trunk/Source/WebCore/page/PageConfiguration.cpp (281836 => 281837)
--- trunk/Source/WebCore/page/PageConfiguration.cpp 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebCore/page/PageConfiguration.cpp 2021-09-01 02:25:28 UTC (rev 281837)
@@ -40,6 +40,7 @@
#include "LibWebRTCProvider.h"
#include "MediaRecorderProvider.h"
#include "PerformanceLoggingClient.h"
+#include "PermissionController.h"
#include "PluginInfoProvider.h"
#include "ProgressTrackerClient.h"
#include "SocketProvider.h"
Modified: trunk/Source/WebKit/ChangeLog (281836 => 281837)
--- trunk/Source/WebKit/ChangeLog 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebKit/ChangeLog 2021-09-01 02:25:28 UTC (rev 281837)
@@ -1,3 +1,22 @@
+2021-08-31 Lauro Moura <[email protected]>
+
+ Non-unified build partial fixes, late late August 2021
+ https://bugs.webkit.org/show_bug.cgi?id=229741
+
+ Unreviewed non-unified build fixes.
+
+ * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
+ Add missing header.
+ * NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:
+ Add missing header.
+ (WebKit::PCM::Database::attributePrivateClickMeasurement): Namespace
+ some names.
+ (WebKit::PCM::Database::removeUnattributed): Ditto.
+ (WebKit::PCM::Database::clearPrivateClickMeasurement): Ditto.
+ (WebKit::PCM::Database::clearSentAttribution): Ditto.
+ * NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h:
+ Add missing header.
+
2021-08-31 Chris Dumez <[email protected]>
Enable SharedArrayBuffer support when COOP/COEP headers are used
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp (281836 => 281837)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2021-09-01 02:25:28 UTC (rev 281837)
@@ -32,6 +32,7 @@
#include "NetworkSession.h"
#include "PluginProcessManager.h"
#include "PluginProcessProxy.h"
+#include "PrivateClickMeasurementManager.h"
#include "ResourceLoadStatisticsMemoryStore.h"
#include "StorageAccessStatus.h"
#include "WebProcessProxy.h"
Modified: trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp (281836 => 281837)
--- trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp 2021-09-01 02:25:28 UTC (rev 281837)
@@ -29,6 +29,7 @@
#include "Logging.h"
#include "PrivateClickMeasurementDebugInfo.h"
#include "PrivateClickMeasurementManager.h"
+#include <WebCore/RegistrableDomain.h>
#include <WebCore/SQLiteStatement.h>
#include <WebCore/SQLiteStatementAutoResetScope.h>
#include <WebCore/SQLiteTransaction.h>
@@ -235,7 +236,7 @@
return std::make_pair(unattributedPrivateClickMeasurement, attributedPrivateClickMeasurement);
}
-std::pair<std::optional<PrivateClickMeasurement::AttributionSecondsUntilSendData>, DebugInfo> Database::attributePrivateClickMeasurement(const WebCore::PrivateClickMeasurement::SourceSite& sourceSite, const WebCore::PrivateClickMeasurement::AttributionDestinationSite& destinationSite, WebCore::PrivateClickMeasurement::AttributionTriggerData&& attributionTriggerData)
+std::pair<std::optional<WebCore::PrivateClickMeasurement::AttributionSecondsUntilSendData>, DebugInfo> Database::attributePrivateClickMeasurement(const WebCore::PrivateClickMeasurement::SourceSite& sourceSite, const WebCore::PrivateClickMeasurement::AttributionDestinationSite& destinationSite, WebCore::PrivateClickMeasurement::AttributionTriggerData&& attributionTriggerData)
{
ASSERT(!RunLoop::isMain());
@@ -252,7 +253,7 @@
RELEASE_LOG_INFO(PrivateClickMeasurement, "Got an attribution with attribution trigger data: %{public}u and priority: %{public}u.", data, priority);
debugInfo.messages.append({ MessageLevel::Info, makeString("[Private Click Measurement] Got an attribution with attribution trigger data: '"_s, data, "' and priority: '"_s, priority, "'."_s) });
- PrivateClickMeasurement::AttributionSecondsUntilSendData secondsUntilSend { std::nullopt, std::nullopt };
+ WebCore::PrivateClickMeasurement::AttributionSecondsUntilSendData secondsUntilSend { std::nullopt, std::nullopt };
auto attribution = findPrivateClickMeasurement(sourceSite, destinationSite);
auto& previouslyUnattributed = attribution.first;
@@ -300,7 +301,7 @@
return { secondsUntilSend, WTFMove(debugInfo) };
}
-void Database::removeUnattributed(PrivateClickMeasurement& attribution)
+void Database::removeUnattributed(WebCore::PrivateClickMeasurement& attribution)
{
ASSERT(!RunLoop::isMain());
auto sourceSiteDomainID = domainID(attribution.sourceSite().registrableDomain);
@@ -439,7 +440,7 @@
}
}
-void Database::clearPrivateClickMeasurement(std::optional<RegistrableDomain> domain)
+void Database::clearPrivateClickMeasurement(std::optional<WebCore::RegistrableDomain> domain)
{
ASSERT(!RunLoop::isMain());
@@ -479,7 +480,7 @@
}
}
-void Database::clearSentAttribution(WebCore::PrivateClickMeasurement&& attribution, PrivateClickMeasurement::AttributionReportEndpoint attributionReportEndpoint)
+void Database::clearSentAttribution(WebCore::PrivateClickMeasurement&& attribution, WebCore::PrivateClickMeasurement::AttributionReportEndpoint attributionReportEndpoint)
{
ASSERT(!RunLoop::isMain());
auto timesToSend = earliestTimesToSend(attribution);
@@ -493,7 +494,7 @@
return;
switch (attributionReportEndpoint) {
- case PrivateClickMeasurement::AttributionReportEndpoint::Source:
+ case WebCore::PrivateClickMeasurement::AttributionReportEndpoint::Source:
if (!sourceEarliestTimeToSend) {
ASSERT_NOT_REACHED();
return;
@@ -501,7 +502,7 @@
markReportAsSentToSource(*sourceSiteDomainID, *destinationSiteDomainID);
sourceEarliestTimeToSend = std::nullopt;
break;
- case PrivateClickMeasurement::AttributionReportEndpoint::Destination:
+ case WebCore::PrivateClickMeasurement::AttributionReportEndpoint::Destination:
if (!destinationEarliestTimeToSend) {
ASSERT_NOT_REACHED();
return;
Modified: trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h (281836 => 281837)
--- trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h 2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h 2021-09-01 02:25:28 UTC (rev 281837)
@@ -26,6 +26,7 @@
#pragma once
#include "DatabaseUtilities.h"
+#include <WebCore/PrivateClickMeasurement.h>
#include <wtf/ThreadSafeRefCounted.h>
namespace WebKit {
