Title: [281867] trunk/Source/WebCore
- Revision
- 281867
- Author
- [email protected]
- Date
- 2021-09-01 12:50:04 -0700 (Wed, 01 Sep 2021)
Log Message
REGRESSION(r280928) The smooth keyboard scrolling is unconditionally enabled for PageUp and PageDown keys
https://bugs.webkit.org/show_bug.cgi?id=229733
Reviewed by Tim Horton.
Even though WinCairo port doesn't enable
EventHandlerDrivenSmoothKeyboardScrollingEnabled yet, it had been
enabled only for PageUp and PageDown keys since r280928. Other
keys (Space and Arrow keys) don't trigger the smooth scrolling.
r280928 changed to call startKeyboardScrolling for PageUp and
PageDown keys, but it didn't check the setting.
* page/EventHandler.cpp:
(WebCore::EventHandler::startKeyboardScrolling):
(WebCore::EventHandler::defaultKeyboardEventHandler):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (281866 => 281867)
--- trunk/Source/WebCore/ChangeLog 2021-09-01 19:03:04 UTC (rev 281866)
+++ trunk/Source/WebCore/ChangeLog 2021-09-01 19:50:04 UTC (rev 281867)
@@ -1,3 +1,22 @@
+2021-09-01 Fujii Hironori <[email protected]>
+
+ REGRESSION(r280928) The smooth keyboard scrolling is unconditionally enabled for PageUp and PageDown keys
+ https://bugs.webkit.org/show_bug.cgi?id=229733
+
+ Reviewed by Tim Horton.
+
+ Even though WinCairo port doesn't enable
+ EventHandlerDrivenSmoothKeyboardScrollingEnabled yet, it had been
+ enabled only for PageUp and PageDown keys since r280928. Other
+ keys (Space and Arrow keys) don't trigger the smooth scrolling.
+
+ r280928 changed to call startKeyboardScrolling for PageUp and
+ PageDown keys, but it didn't check the setting.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::startKeyboardScrolling):
+ (WebCore::EventHandler::defaultKeyboardEventHandler):
+
2021-09-01 Kimmo Kinnunen <[email protected]>
ImageRenderingMode.h is not used
Modified: trunk/Source/WebCore/page/EventHandler.cpp (281866 => 281867)
--- trunk/Source/WebCore/page/EventHandler.cpp 2021-09-01 19:03:04 UTC (rev 281866)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2021-09-01 19:50:04 UTC (rev 281867)
@@ -4288,6 +4288,9 @@
bool EventHandler::startKeyboardScrolling(KeyboardEvent& event)
{
+ if (!m_frame.settings().eventHandlerDrivenSmoothKeyboardScrollingEnabled())
+ return false;
+
Ref protectedFrame = m_frame;
FrameView* view = m_frame.view();
@@ -4304,8 +4307,7 @@
ASSERT(event.type() == eventNames().keydownEvent);
if (!isSpatialNavigationEnabled(&m_frame)) {
- if (m_frame.settings().eventHandlerDrivenSmoothKeyboardScrollingEnabled())
- startKeyboardScrolling(event);
+ startKeyboardScrolling(event);
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
