Title: [281877] trunk/Source/WebCore
- Revision
- 281877
- Author
- [email protected]
- Date
- 2021-09-01 14:28:01 -0700 (Wed, 01 Sep 2021)
Log Message
'Show Next Frame' and 'Show Previous Frame' keyboard shortcuts seem out of context and only pause video
https://bugs.webkit.org/show_bug.cgi?id=229538
rdar://78161031
Reviewed by Eric Carlson.
On its own, this change will do nothing as currently AVKit doesn't check those properties
and will always attempt to seek one frame forward or backward which isn't currently
supported.
AVKit will be amended so that it will call canSeekFrameBackward/canSeekFrameForward
as necessary.
This change will be reverted once https://bugs.webkit.org/show_bug.cgi?id=229539 is
complete.
* platform/ios/WebAVPlayerController.mm:
(-[WebAVPlayerController canSeekFrameBackward]):
(-[WebAVPlayerController canSeekFrameForward]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (281876 => 281877)
--- trunk/Source/WebCore/ChangeLog 2021-09-01 21:24:50 UTC (rev 281876)
+++ trunk/Source/WebCore/ChangeLog 2021-09-01 21:28:01 UTC (rev 281877)
@@ -1,3 +1,23 @@
+2021-09-01 Jean-Yves Avenard <[email protected]>
+
+ 'Show Next Frame' and 'Show Previous Frame' keyboard shortcuts seem out of context and only pause video
+ https://bugs.webkit.org/show_bug.cgi?id=229538
+ rdar://78161031
+
+ Reviewed by Eric Carlson.
+
+ On its own, this change will do nothing as currently AVKit doesn't check those properties
+ and will always attempt to seek one frame forward or backward which isn't currently
+ supported.
+ AVKit will be amended so that it will call canSeekFrameBackward/canSeekFrameForward
+ as necessary.
+ This change will be reverted once https://bugs.webkit.org/show_bug.cgi?id=229539 is
+ complete.
+
+ * platform/ios/WebAVPlayerController.mm:
+ (-[WebAVPlayerController canSeekFrameBackward]):
+ (-[WebAVPlayerController canSeekFrameForward]):
+
2021-09-01 David Kilzer <[email protected]>
[WebRTC] Leak or over-release of CFPixelBufferRef returned from webrtc::createPixelBufferFromFrame()
Modified: trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm (281876 => 281877)
--- trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm 2021-09-01 21:24:50 UTC (rev 281876)
+++ trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm 2021-09-01 21:28:01 UTC (rev 281877)
@@ -462,12 +462,12 @@
- (BOOL)canSeekFrameBackward
{
- return YES;
+ return NO;
}
- (BOOL)canSeekFrameForward
{
- return YES;
+ return NO;
}
- (BOOL)hasMediaSelectionOptions
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
