Title: [281884] trunk/Source/WebCore
Revision
281884
Author
[email protected]
Date
2021-09-01 15:49:44 -0700 (Wed, 01 Sep 2021)

Log Message

PerformanceNavigationTiming should be instantiated before scripts run then updated when response finishes
https://bugs.webkit.org/show_bug.cgi?id=229751

Patch by Alex Christensen <[email protected]> on 2021-09-01
Reviewed by Chris Dumez.

This removes an optimistic assertion that was firing in some appcache tests.

* page/Performance.cpp:
(WebCore::Performance::navigationFinished):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (281883 => 281884)


--- trunk/Source/WebCore/ChangeLog	2021-09-01 22:46:29 UTC (rev 281883)
+++ trunk/Source/WebCore/ChangeLog	2021-09-01 22:49:44 UTC (rev 281884)
@@ -1,3 +1,15 @@
+2021-09-01  Alex Christensen  <[email protected]>
+
+        PerformanceNavigationTiming should be instantiated before scripts run then updated when response finishes
+        https://bugs.webkit.org/show_bug.cgi?id=229751
+
+        Reviewed by Chris Dumez.
+
+        This removes an optimistic assertion that was firing in some appcache tests.
+
+        * page/Performance.cpp:
+        (WebCore::Performance::navigationFinished):
+
 2021-09-01  Eric Carlson  <[email protected]>
 
         [macOS] getDisplayMedia should capture at the constrained size if possible

Modified: trunk/Source/WebCore/page/Performance.cpp (281883 => 281884)


--- trunk/Source/WebCore/page/Performance.cpp	2021-09-01 22:46:29 UTC (rev 281883)
+++ trunk/Source/WebCore/page/Performance.cpp	2021-09-01 22:49:44 UTC (rev 281884)
@@ -253,10 +253,8 @@
 
 void Performance::navigationFinished(const NetworkLoadMetrics& metrics)
 {
-    if (!m_navigationTiming) {
-        ASSERT_NOT_REACHED();
+    if (!m_navigationTiming)
         return;
-    }
     m_navigationTiming->navigationFinished(metrics);
 
     queueEntry(*m_navigationTiming);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to