Title: [281899] branches/safari-612-branch/Source/WebCore
Revision
281899
Author
[email protected]
Date
2021-09-01 18:05:09 -0700 (Wed, 01 Sep 2021)

Log Message

Cherry-pick r281813. rdar://problem/82651722

    REGRESSION (r272900): wpt.fyi loading performance is very slow (regressed, and slower than other browsers)
    https://bugs.webkit.org/show_bug.cgi?id=229680
    <rdar://problem/82541045>

    Reviewed by Darin Adler.

    The page is inserting new children to shadow host and on each insertion we are traversing the composed
    tree to tear down renderers, even though there are none.

    * rendering/updating/RenderTreeUpdater.cpp:
    (WebCore::RenderTreeUpdater::tearDownRenderersAfterSlotChange):

    If the host doesn't have a renderer or 'display:contents' there can't be any renderers left in the subtree.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (281898 => 281899)


--- branches/safari-612-branch/Source/WebCore/ChangeLog	2021-09-02 01:05:06 UTC (rev 281898)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog	2021-09-02 01:05:09 UTC (rev 281899)
@@ -1,5 +1,42 @@
 2021-09-01  Russell Epstein  <[email protected]>
 
+        Cherry-pick r281813. rdar://problem/82651722
+
+    REGRESSION (r272900): wpt.fyi loading performance is very slow (regressed, and slower than other browsers)
+    https://bugs.webkit.org/show_bug.cgi?id=229680
+    <rdar://problem/82541045>
+    
+    Reviewed by Darin Adler.
+    
+    The page is inserting new children to shadow host and on each insertion we are traversing the composed
+    tree to tear down renderers, even though there are none.
+    
+    * rendering/updating/RenderTreeUpdater.cpp:
+    (WebCore::RenderTreeUpdater::tearDownRenderersAfterSlotChange):
+    
+    If the host doesn't have a renderer or 'display:contents' there can't be any renderers left in the subtree.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-08-31  Antti Koivisto  <[email protected]>
+
+            REGRESSION (r272900): wpt.fyi loading performance is very slow (regressed, and slower than other browsers)
+            https://bugs.webkit.org/show_bug.cgi?id=229680
+            <rdar://problem/82541045>
+
+            Reviewed by Darin Adler.
+
+            The page is inserting new children to shadow host and on each insertion we are traversing the composed
+            tree to tear down renderers, even though there are none.
+
+            * rendering/updating/RenderTreeUpdater.cpp:
+            (WebCore::RenderTreeUpdater::tearDownRenderersAfterSlotChange):
+
+            If the host doesn't have a renderer or 'display:contents' there can't be any renderers left in the subtree.
+
+2021-09-01  Russell Epstein  <[email protected]>
+
         Cherry-pick r281787. rdar://problem/82651372
 
     Web Inspector: Refactor `WorkerInspectorAgent` to use weak pointers for `WorkerInspectorProxy`s

Modified: branches/safari-612-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp (281898 => 281899)


--- branches/safari-612-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp	2021-09-02 01:05:06 UTC (rev 281898)
+++ branches/safari-612-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp	2021-09-02 01:05:09 UTC (rev 281899)
@@ -539,6 +539,8 @@
 void RenderTreeUpdater::tearDownRenderersAfterSlotChange(Element& host)
 {
     ASSERT(host.shadowRoot());
+    if (!host.renderer() && !host.hasDisplayContents())
+        return;
     auto* view = host.document().renderView();
     if (!view)
         return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to