Title: [281902] branches/safari-612-branch/Source/WebCore
- Revision
- 281902
- Author
- [email protected]
- Date
- 2021-09-01 18:05:20 -0700 (Wed, 01 Sep 2021)
Log Message
Cherry-pick r281884. rdar://problem/82651913
PerformanceNavigationTiming should be instantiated before scripts run then updated when response finishes
https://bugs.webkit.org/show_bug.cgi?id=229751
Patch by Alex Christensen <[email protected]> on 2021-09-01
Reviewed by Chris Dumez.
This removes an optimistic assertion that was firing in some appcache tests.
* page/Performance.cpp:
(WebCore::Performance::navigationFinished):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (281901 => 281902)
--- branches/safari-612-branch/Source/WebCore/ChangeLog 2021-09-02 01:05:18 UTC (rev 281901)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog 2021-09-02 01:05:20 UTC (rev 281902)
@@ -1,5 +1,34 @@
2021-09-01 Russell Epstein <[email protected]>
+ Cherry-pick r281884. rdar://problem/82651913
+
+ PerformanceNavigationTiming should be instantiated before scripts run then updated when response finishes
+ https://bugs.webkit.org/show_bug.cgi?id=229751
+
+ Patch by Alex Christensen <[email protected]> on 2021-09-01
+ Reviewed by Chris Dumez.
+
+ This removes an optimistic assertion that was firing in some appcache tests.
+
+ * page/Performance.cpp:
+ (WebCore::Performance::navigationFinished):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-09-01 Alex Christensen <[email protected]>
+
+ PerformanceNavigationTiming should be instantiated before scripts run then updated when response finishes
+ https://bugs.webkit.org/show_bug.cgi?id=229751
+
+ Reviewed by Chris Dumez.
+
+ This removes an optimistic assertion that was firing in some appcache tests.
+
+ * page/Performance.cpp:
+ (WebCore::Performance::navigationFinished):
+
+2021-09-01 Russell Epstein <[email protected]>
+
Cherry-pick r281860. rdar://problem/82651913
PerformanceNavigationTiming should be instantiated before scripts run then updated when response finishes
Modified: branches/safari-612-branch/Source/WebCore/page/Performance.cpp (281901 => 281902)
--- branches/safari-612-branch/Source/WebCore/page/Performance.cpp 2021-09-02 01:05:18 UTC (rev 281901)
+++ branches/safari-612-branch/Source/WebCore/page/Performance.cpp 2021-09-02 01:05:20 UTC (rev 281902)
@@ -245,10 +245,8 @@
void Performance::navigationFinished(const NetworkLoadMetrics& metrics)
{
- if (!m_navigationTiming) {
- ASSERT_NOT_REACHED();
+ if (!m_navigationTiming)
return;
- }
m_navigationTiming->navigationFinished(metrics);
queueEntry(*m_navigationTiming);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
