Title: [281909] trunk/Source/WebCore
Revision
281909
Author
[email protected]
Date
2021-09-01 22:47:21 -0700 (Wed, 01 Sep 2021)

Log Message

Implement ANGLE version of WebGL layer snapshot copyImageSnapshotWithColorSpace
https://bugs.webkit.org/show_bug.cgi?id=217377
<rdar://problem/70248151>

Patch by Kimmo Kinnunen <[email protected]> on 2021-09-01
Reviewed by Tim Horton.

Remove the function. The snapshots go through the paint codepath now.

* platform/graphics/cocoa/WebGLLayer.h:
* platform/graphics/cocoa/WebGLLayer.mm:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (281908 => 281909)


--- trunk/Source/WebCore/ChangeLog	2021-09-02 05:11:06 UTC (rev 281908)
+++ trunk/Source/WebCore/ChangeLog	2021-09-02 05:47:21 UTC (rev 281909)
@@ -1,3 +1,16 @@
+2021-09-01  Kimmo Kinnunen  <[email protected]>
+
+        Implement ANGLE version of WebGL layer snapshot copyImageSnapshotWithColorSpace
+        https://bugs.webkit.org/show_bug.cgi?id=217377
+        <rdar://problem/70248151>
+
+        Reviewed by Tim Horton.
+
+        Remove the function. The snapshots go through the paint codepath now.
+
+        * platform/graphics/cocoa/WebGLLayer.h:
+        * platform/graphics/cocoa/WebGLLayer.mm:
+
 2021-09-01  Alan Bujtas  <[email protected]>
 
         [LFC][IFC] Do not generate integration runs out of IFC's display runs

Modified: trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.h (281908 => 281909)


--- trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.h	2021-09-02 05:11:06 UTC (rev 281908)
+++ trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.h	2021-09-02 05:47:21 UTC (rev 281909)
@@ -36,8 +36,6 @@
 
 - (id)initWithDevicePixelRatio:(float)devicePixelRatio contentsOpaque:(bool)contentsOpaque;
 
-- (CGImageRef)copyImageSnapshotWithColorSpace:(CGColorSpaceRef)colorSpace;
-
 - (WebCore::GraphicsContextGLIOSurfaceSwapChain&) swapChain;
 
 @end

Modified: trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.mm (281908 => 281909)


--- trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.mm	2021-09-02 05:11:06 UTC (rev 281908)
+++ trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.mm	2021-09-02 05:47:21 UTC (rev 281909)
@@ -75,13 +75,6 @@
     [super setAnchorPoint:CGPointMake(p.x, 1.0 - p.y)];
 }
 
-- (CGImageRef)copyImageSnapshotWithColorSpace:(CGColorSpaceRef)colorSpace
-{
-    // FIXME: implement. https://bugs.webkit.org/show_bug.cgi?id=217377
-    // When implementing, remember to use self.contentsScale.
-    UNUSED_PARAM(colorSpace);
-    return nullptr;
-}
 - (WebCore::GraphicsContextGLIOSurfaceSwapChain&) swapChain
 {
     return _swapChain.value();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to