Title: [281932] trunk/Websites/webkit.org
- Revision
- 281932
- Author
- [email protected]
- Date
- 2021-09-02 09:42:55 -0700 (Thu, 02 Sep 2021)
Log Message
[contributors.json] Relocation (Part 3)
https://bugs.webkit.org/show_bug.cgi?id=229690
<rdar://problem/82552403>
Reviewed by Aakash Jain.
* commit-review.md: Link to metadata/contributors.json.
* wp-content/themes/webkit/team.php: Load from metadata/contributors.json,
load list instead of dictionary.
Modified Paths
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (281931 => 281932)
--- trunk/Websites/webkit.org/ChangeLog 2021-09-02 16:41:20 UTC (rev 281931)
+++ trunk/Websites/webkit.org/ChangeLog 2021-09-02 16:42:55 UTC (rev 281932)
@@ -1,3 +1,15 @@
+2021-09-02 Jonathan Bedard <[email protected]>
+
+ [contributors.json] Relocation (Part 3)
+ https://bugs.webkit.org/show_bug.cgi?id=229690
+ <rdar://problem/82552403>
+
+ Reviewed by Aakash Jain.
+
+ * commit-review.md: Link to metadata/contributors.json.
+ * wp-content/themes/webkit/team.php: Load from metadata/contributors.json,
+ load list instead of dictionary.
+
2021-08-31 Jonathan Bedard <[email protected]>
[contributors.json] Replace class=bot with status=bot
Modified: trunk/Websites/webkit.org/commit-review.md (281931 => 281932)
--- trunk/Websites/webkit.org/commit-review.md 2021-09-02 16:41:20 UTC (rev 281931)
+++ trunk/Websites/webkit.org/commit-review.md 2021-09-02 16:42:55 UTC (rev 281932)
@@ -10,7 +10,7 @@
Once someone is successfully nominated for WebKit Committer status, Apple will take care of sending the committer agreement and setting up a Subversion account once signed and received.
-Once someone is successfully nominated for WebKit Reviewer status, the nominating Reviewer or another responsible party should inform the candidate and ask for indication of acceptance from the potential new reviewer. If the candidate accepts, [contributors.json](http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json) will be updated.
+Once someone is successfully nominated for WebKit Reviewer status, the nominating Reviewer or another responsible party should inform the candidate and ask for indication of acceptance from the potential new reviewer. If the candidate accepts, [contributors.json](http://trac.webkit.org/browser/trunk/metadata/contributors.json) will be updated.
## Criteria for Committers
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/team.php (281931 => 281932)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/team.php 2021-09-02 16:41:20 UTC (rev 281931)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/team.php 2021-09-02 16:42:55 UTC (rev 281932)
@@ -157,21 +157,18 @@
};
function parseContributorsJSON(text) {
- var contributorsJSON = JSON.parse(text);
- var contributors = [];
-
- for (var contributor in contributorsJSON) {
- var data = ""
- if (data.status == "bot")
- continue;
+ let contributors = [];
+ JSON.parse(text).forEach(contributor => {
+ if (contributor.class == "bot")
+ return;
contributors.push({
- name: contributor,
- kind: data.status ? data.status : 'contributor',
- emails: data.emails,
- nicks: data.nicks,
- expertise: data.expertise
+ name: contributor.name,
+ kind: contributor.status ? contributor.status : 'contributor',
+ emails: contributor.emails,
+ nicks: contributor.nicks,
+ expertise: contributor.expertise
});
- }
+ });
return contributors;
}
@@ -266,7 +263,7 @@
populateContributorList(contributors, 'contributor');
};
xhr._onerror_ = function () { document.getElementById('team').textContent = 'There was an issue loading data for the WebKit Team. not obtain contributors.json'; };
-xhr.open('GET', svnTrunkUrl + 'Tools/Scripts/webkitpy/common/config/contributors.json');
+xhr.open('GET', svnTrunkUrl + 'metadata/contributors.json');
xhr.send();
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
